Added wm::IsWindowUserPositionable(...) method in window_util.h.

Added wm::IsWindowUserPositionable(...) method in window_util.h.

Many places in ash were checking that window types were NORMAL or PANEL.
The wm::IsWindowUserPositionable(...) encapsulates this check.

BUG=None

Committed: https://crrev.com/b7056f63218b3ceb0301278334b8b8c203c6a3f0
Cr-Commit-Position: refs/heads/master@{#332907}

[bruthig, 2015-06-03 16:45:09]

bruthig@chromium.org changed reviewers:
+ oshima@chromium.org

[bruthig, 2015-06-03 16:45:09]

oshima@, can you please have a look?
 - */*

[oshima, 2015-06-04 18:11:41]

nice. one request.

Would you mind adding method to WindowState::IsUserPositionable, and let
wm::IsWindowPositionable uses this method?

[bruthig, 2015-06-04 19:10:56]

oshima@, can you take another look?

[oshima, 2015-06-04 19:49:12]

lgtm with nits

https://codereview.chromium.org/1157843009/diff/20001/ash/accelerators/accele...
File ash/accelerators/accelerator_controller.cc (right):

https://codereview.chromium.org/1157843009/diff/20001/ash/accelerators/accele...
ash/accelerators/accelerator_controller.cc:468:
wm::IsWindowUserPositionable(window_state->window()) &&
window_state->IsUserPositionable() ?

https://codereview.chromium.org/1157843009/diff/20001/ash/wm/default_state.cc
File ash/wm/default_state.cc (right):

https://codereview.chromium.org/1157843009/diff/20001/ash/wm/default_state.cc...
ash/wm/default_state.cc:425: if
(!wm::IsWindowUserPositionable(window_state->window()))
ditto

https://codereview.chromium.org/1157843009/diff/20001/ash/wm/overview/window_...
File ash/wm/overview/window_selector.cc (right):

https://codereview.chromium.org/1157843009/diff/20001/ash/wm/overview/window_...
ash/wm/overview/window_selector.cc:228: return
wm::IsWindowUserPositionable(window);
ditto

[bruthig, 2015-06-04 19:56:23]

Updated call sites to use WindowState::IsUserPositionable().

No need to review.

https://codereview.chromium.org/1157843009/diff/20001/ash/accelerators/accele...
File ash/accelerators/accelerator_controller.cc (right):

https://codereview.chromium.org/1157843009/diff/20001/ash/accelerators/accele...
ash/accelerators/accelerator_controller.cc:468:
wm::IsWindowUserPositionable(window_state->window()) &&
On 2015/06/04 19:49:11, oshima wrote:
> window_state->IsUserPositionable() ?

Done.

https://codereview.chromium.org/1157843009/diff/20001/ash/wm/default_state.cc
File ash/wm/default_state.cc (right):

https://codereview.chromium.org/1157843009/diff/20001/ash/wm/default_state.cc...
ash/wm/default_state.cc:425: if
(!wm::IsWindowUserPositionable(window_state->window()))
On 2015/06/04 19:49:12, oshima wrote:
> ditto

Done.

https://codereview.chromium.org/1157843009/diff/20001/ash/wm/overview/window_...
File ash/wm/overview/window_selector.cc (right):

https://codereview.chromium.org/1157843009/diff/20001/ash/wm/overview/window_...
ash/wm/overview/window_selector.cc:228: return
wm::IsWindowUserPositionable(window);
On 2015/06/04 19:49:12, oshima wrote:
> ditto

Done.

[bruthig, 2015-06-04 19:56:27]

The CQ bit was checked by bruthig@chromium.org

[bruthig, 2015-06-04 19:56:27]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/1157843009/#ps40001
(title: "Updated callsites to use WindowState::IsUserPositionable().")

[commit-bot: I haz the power, 2015-06-04 19:58:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1157843009/40001

[commit-bot: I haz the power, 2015-06-04 21:05:01]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-06-04 21:05:54]

Patchset 3 (id:??) landed as
https://crrev.com/b7056f63218b3ceb0301278334b8b8c203c6a3f0
Cr-Commit-Position: refs/heads/master@{#332907}