ash/wm/default_state.cc - Issue 1157843009: Added wm::IsWindowUserPositionable(...) method in window_util.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/default_state.cc

Issue 1157843009: Added wm::IsWindowUserPositionable(...) method in window_util.h. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated callsites to use WindowState::IsUserPositionable(). Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/wm/default_state.cc

diff --git a/ash/wm/default_state.cc b/ash/wm/default_state.cc

index 3364d298dde9131b18c49ea3738b699e4dd7ee83..61a3dc6b09120e7fcb0529e2ee51659898c6b010 100644

--- a/ash/wm/default_state.cc

+++ b/ash/wm/default_state.cc

@@ -422,10 +422,8 @@ bool DefaultState::ProcessWorkspaceEvents(WindowState* window_state,

// adjusted to have minimum visibility, because they are positioned by the

// user and user should always be able to interact with them. Other

// windows are positioned programmatically.

- if (window_state->window()->type() != ui::wm::WINDOW_TYPE_NORMAL &&

- window_state->window()->type() != ui::wm::WINDOW_TYPE_PANEL) {

+ if (!window_state->IsUserPositionable())

return true;

- }

// Use entire display instead of workarea because the workarea can

// be further shrunk by the docked area. The logic ensures 30%

« no previous file with comments | « ash/shell/window_watcher.cc ('k') | ash/wm/drag_window_resizer.cc » ('j') | no next file with comments »