ash/wm/overview/window_selector.cc - Issue 1157843009: Added wm::IsWindowUserPositionable(...) method in window_util.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/overview/window_selector.cc

Issue 1157843009: Added wm::IsWindowUserPositionable(...) method in window_util.h. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated callsites to use WindowState::IsUserPositionable(). Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/wm/overview/window_selector.cc

diff --git a/ash/wm/overview/window_selector.cc b/ash/wm/overview/window_selector.cc

index 91458cf78042f4f653578f93402f1c0b018cbe96..61664d75432719c875ebf6ae8201373821984126 100644

--- a/ash/wm/overview/window_selector.cc

+++ b/ash/wm/overview/window_selector.cc

@@ -22,6 +22,7 @@

#include "ash/wm/overview/window_selector_item.h"

#include "ash/wm/panels/panel_layout_manager.h"

#include "ash/wm/window_state.h"

+#include "ash/wm/window_util.h"

#include "base/auto_reset.h"

#include "base/command_line.h"

#include "base/metrics/histogram.h"

@@ -224,8 +225,7 @@ bool WindowSelector::IsSelectable(aura::Window* window) {

state->GetStateType() == wm::WINDOW_STATE_TYPE_DOCKED_MINIMIZED) {

return false;

}

- return window->type() == ui::wm::WINDOW_TYPE_NORMAL ||

- window->type() == ui::wm::WINDOW_TYPE_PANEL;

+ return state->IsUserPositionable();

}

WindowSelector::WindowSelector(WindowSelectorDelegate* delegate)

« no previous file with comments | « ash/wm/drag_window_resizer.cc ('k') | ash/wm/window_state.h » ('j') | no next file with comments »