ash/shell/window_watcher.cc - Issue 1157843009: Added wm::IsWindowUserPositionable(...) method in window_util.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/shell/window_watcher.cc

Issue 1157843009: Added wm::IsWindowUserPositionable(...) method in window_util.h. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated callsites to use WindowState::IsUserPositionable(). Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/shell/window_watcher.cc

diff --git a/ash/shell/window_watcher.cc b/ash/shell/window_watcher.cc

index 990cef1e949d1a200da5bcff02065b771875412b..f5b194c56b07425a144dbdf373f1d86bda30d86f 100644

--- a/ash/shell/window_watcher.cc

+++ b/ash/shell/window_watcher.cc

@@ -13,6 +13,7 @@

#include "ash/shell.h"

#include "ash/shell/window_watcher_shelf_item_delegate.h"

#include "ash/shell_window_ids.h"

+#include "ash/wm/window_util.h"

#include "ui/aura/window.h"

#include "ui/aura/window_event_dispatcher.h"

#include "ui/gfx/display.h"

@@ -90,8 +91,7 @@ aura::Window* WindowWatcher::GetWindowByID(ash::ShelfID id) {

// aura::WindowObserver overrides:

void WindowWatcher::OnWindowAdded(aura::Window* new_window) {

- if (new_window->type() != ui::wm::WINDOW_TYPE_NORMAL &&

- new_window->type() != ui::wm::WINDOW_TYPE_PANEL)

+ if (!wm::IsWindowUserPositionable(new_window))

return;

static int image_count = 0;

« no previous file with comments | « ash/root_window_controller.cc ('k') | ash/wm/default_state.cc » ('j') | no next file with comments »