ash/root_window_controller.cc - Issue 1157843009: Added wm::IsWindowUserPositionable(...) method in window_util.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/root_window_controller.cc

Issue 1157843009: Added wm::IsWindowUserPositionable(...) method in window_util.h. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated callsites to use WindowState::IsUserPositionable(). Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/root_window_controller.cc

diff --git a/ash/root_window_controller.cc b/ash/root_window_controller.cc

index c8a3aba4190c0921ebbcc21bb83d5ef3a5165c26..3a5733ed3984ef2d98532e3db4ca8cc84fb20e8b 100644

--- a/ash/root_window_controller.cc

+++ b/ash/root_window_controller.cc

@@ -613,8 +613,7 @@ const aura::Window* RootWindowController::GetWindowForFullscreenMode() const {

GetContainer(kShellWindowId_DefaultContainer)->children();

for (aura::Window::Windows::const_reverse_iterator iter = windows.rbegin();

iter != windows.rend(); ++iter) {

- if (((*iter)->type() == ui::wm::WINDOW_TYPE_NORMAL ||

- (*iter)->type() == ui::wm::WINDOW_TYPE_PANEL) &&

+ if (wm::IsWindowUserPositionable(*iter) &&

(*iter)->layer()->GetTargetVisibility()) {

topmost_window = *iter;

break;

« no previous file with comments | « ash/accelerators/accelerator_controller.cc ('k') | ash/shell/window_watcher.cc » ('j') | no next file with comments »