CacheStorage: Pass an error object allocated on heap to WebCallbacks::onError (2)

CacheStorage: Pass an error object allocated on heap to WebCallbacks::onError (2)

This is a preliminary patch to simplify memory management in
CallbackPromiseAdapter. See (1) for details.

(1) Chromium: https://codereview.chromium.org/1152003008
(2) Blink: THIS PATCH
(3) Chromium: https://codereview.chromium.org/1150333003
(4) Blink: https://codereview.chromium.org/1150413004

BUG=494884
TEST=n/a

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197315

[nhiroki, 2015-06-17 08:23:31]

Patchset #1 (id:1) has been deleted

[nhiroki, 2015-06-17 08:23:37]

Patchset #1 (id:20001) has been deleted

[nhiroki, 2015-06-17 08:38:48]

nhiroki@chromium.org changed reviewers:
+ jkarlin@chromium.org

[nhiroki, 2015-06-17 08:38:48]

PTAL, thanks!

[jkarlin, 2015-06-17 11:16:16]

lgtm after fixing one issue

https://codereview.chromium.org/1155573003/diff/40001/Source/modules/cachesto...
File Source/modules/cachestorage/Cache.cpp (right):

https://codereview.chromium.org/1155573003/diff/40001/Source/modules/cachesto...
Source/modules/cachestorage/Cache.cpp:128:
m_resolver->reject(CacheStorageError::createException(*reason));
Why is this function different from above?

[kinuko, 2015-06-17 18:21:05]

kinuko@chromium.org changed reviewers:
+ kinuko@chromium.org

[kinuko, 2015-06-17 18:21:05]

https://codereview.chromium.org/1155573003/diff/40001/Source/modules/cachesto...
File Source/modules/cachestorage/Cache.cpp (right):

https://codereview.chromium.org/1155573003/diff/40001/Source/modules/cachesto...
Source/modules/cachestorage/Cache.cpp:39: #ifdef CRBUG_494884
Hmm, I have the same question... why we need this ifdef in the same patch where
we define it?

[nhiroki, 2015-06-17 23:34:41]

https://codereview.chromium.org/1155573003/diff/40001/Source/modules/cachesto...
File Source/modules/cachestorage/Cache.cpp (right):

https://codereview.chromium.org/1155573003/diff/40001/Source/modules/cachesto...
Source/modules/cachestorage/Cache.cpp:39: #ifdef CRBUG_494884
On 2015/06/17 18:21:05, kinuko wrote:
> Hmm, I have the same question... why we need this ifdef in the same patch
where
> we define it?

Right, these aren't necessary. Removed.

[nhiroki, 2015-06-17 23:35:21]

nhiroki@chromium.org changed reviewers:
+ tkent@chromium.org

[nhiroki, 2015-06-17 23:35:22]

+tkent@, can you review WebServiceWorkerCacheError.h?

[tkent, 2015-06-18 00:45:18]

lgtm

[nhiroki, 2015-06-18 00:50:15]

The CQ bit was checked by nhiroki@chromium.org

[nhiroki, 2015-06-18 00:50:16]

The patchset sent to the CQ was uploaded after l-g-t-m from jkarlin@chromium.org
Link to the patchset: https://codereview.chromium.org/1155573003/#ps60001
(title: "remove ifdef")

[commit-bot: I haz the power, 2015-06-18 00:51:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1155573003/60001

[commit-bot: I haz the power, 2015-06-18 01:11:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-18 01:11:12]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/59385)

[nhiroki, 2015-06-18 02:57:29]

The CQ bit was checked by nhiroki@chromium.org

[nhiroki, 2015-06-18 02:57:30]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
jkarlin@chromium.org
Link to the patchset: https://codereview.chromium.org/1155573003/#ps80001
(title: "fix unittests")

[commit-bot: I haz the power, 2015-06-18 02:57:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1155573003/80001

[commit-bot: I haz the power, 2015-06-18 03:38:38]

Committed patchset #3 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197315