Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 1152003008: CacheStorage: Pass an error object allocated on heap to WebCallbacks::onError (1) (Closed)

Created:
5 years, 6 months ago by nhiroki
Modified:
5 years, 6 months ago
Reviewers:
jkarlin
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, nhiroki, darin-cc_chromium.org, jkarlin+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, serviceworker-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CacheStorage: Pass an error object allocated on heap to WebCallbacks::onError (1) This is a preliminary patch to simplify memory management in CallbackPromiseAdapter. Before this CL, CacheStorageDispatcher passes an error object allocated on stack to WebCallbacks::onError, and this prevents CallbackPromiseAdapter from uniformly managing the passed object with a smart pointer. (All other adapter clients pass an on-heap object) (1) Chromium: THIS PATCH (2) Blink: https://codereview.chromium.org/1155573003 (3) Chromium: https://codereview.chromium.org/1150333003 (4) Blink: https://codereview.chromium.org/1150413004 BUG=494884 TEST=n/a Committed: https://crrev.com/c42996a97da1d32a5a35dd7f09eb82ada88b9b43 Cr-Commit-Position: refs/heads/master@{#334970}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
M content/renderer/cache_storage/cache_storage_dispatcher.cc View 10 chunks +42 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
nhiroki
PTAL, thanks!
5 years, 6 months ago (2015-06-17 08:38:18 UTC) #3
jkarlin
lgtm
5 years, 6 months ago (2015-06-17 11:11:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152003008/1
5 years, 6 months ago (2015-06-17 23:35:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-18 00:47:29 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-18 00:48:30 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c42996a97da1d32a5a35dd7f09eb82ada88b9b43
Cr-Commit-Position: refs/heads/master@{#334970}

Powered by Google App Engine
This is Rietveld 408576698