Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(993)

Unified Diff: Source/modules/cachestorage/Cache.cpp

Issue 1155573003: CacheStorage: Pass an error object allocated on heap to WebCallbacks::onError (2) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: fix unittests Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/modules/cachestorage/CacheStorage.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/cachestorage/Cache.cpp
diff --git a/Source/modules/cachestorage/Cache.cpp b/Source/modules/cachestorage/Cache.cpp
index e26f38a07b7ae4176c592184ae64a0fa2b14b98e..bbe9c75e7693d29c83e60a08481562561573c82e 100644
--- a/Source/modules/cachestorage/Cache.cpp
+++ b/Source/modules/cachestorage/Cache.cpp
@@ -36,8 +36,10 @@ public:
m_resolver.clear();
}
- virtual void onError(WebServiceWorkerCacheError* reason) override
+ // Ownership of |rawReason| must be passed.
+ virtual void onError(WebServiceWorkerCacheError* rawReason) override
{
+ OwnPtr<WebServiceWorkerCacheError> reason = adoptPtr(rawReason);
if (*reason == WebServiceWorkerCacheErrorNotFound)
m_resolver->resolve();
else
@@ -65,8 +67,10 @@ public:
m_resolver.clear();
}
- virtual void onError(WebServiceWorkerCacheError* reason) override
+ // Ownership of |rawReason| must be passed.
+ virtual void onError(WebServiceWorkerCacheError* rawReason) override
{
+ OwnPtr<WebServiceWorkerCacheError> reason = adoptPtr(rawReason);
m_resolver->reject(CacheStorageError::createException(*reason));
m_resolver.clear();
}
@@ -88,8 +92,10 @@ public:
m_resolver.clear();
}
- void onError(WebServiceWorkerCacheError* reason) override
+ // Ownership of |rawReason| must be passed.
+ virtual void onError(WebServiceWorkerCacheError* rawReason) override
{
+ OwnPtr<WebServiceWorkerCacheError> reason = adoptPtr(rawReason);
if (*reason == WebServiceWorkerCacheErrorNotFound)
m_resolver->resolve(false);
else
@@ -117,8 +123,10 @@ public:
m_resolver.clear();
}
- virtual void onError(WebServiceWorkerCacheError* reason) override
+ // Ownership of |rawReason| must be passed.
+ virtual void onError(WebServiceWorkerCacheError* rawReason) override
{
+ OwnPtr<WebServiceWorkerCacheError> reason = adoptPtr(rawReason);
m_resolver->reject(CacheStorageError::createException(*reason));
m_resolver.clear();
}
« no previous file with comments | « no previous file | Source/modules/cachestorage/CacheStorage.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698