CacheStorage: Pass an error object allocated on heap to WebCallbacks::onError (2)

Source/modules/cachestorage/CacheTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "modules/cachestorage/Cache.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/ScriptFunction.h"
 #include "bindings/core/v8/ScriptPromise.h"
@@ skipping 94 matching lines @@
     void setExpectedBatchOperations(const WebVector<BatchOperation>* expectedBatchOperations) { m_expectedBatchOperations = expectedBatchOperations; }
 
     // From WebServiceWorkerCache:
     virtual void dispatchMatch(CacheMatchCallbacks* callbacks, const WebServiceWorkerRequest& webRequest, const QueryParams& queryParams) override
     {
         m_lastErrorWebCacheMethodCalled = "dispatchMatch";
         checkUrlIfProvided(webRequest.url());
         checkQueryParamsIfProvided(queryParams);
 
         OwnPtr<CacheMatchCallbacks> ownedCallbacks(adoptPtr(callbacks));
-        WebServiceWorkerCacheError error = m_error;
-        return callbacks->onError(&error);
+        return callbacks->onError(new WebServiceWorkerCacheError(m_error));
     }
 
     virtual void dispatchMatchAll(CacheWithResponsesCallbacks* callbacks, const WebServiceWorkerRequest& webRequest, const QueryParams& queryParams) override
     {
         m_lastErrorWebCacheMethodCalled = "dispatchMatchAll";
         checkUrlIfProvided(webRequest.url());
         checkQueryParamsIfProvided(queryParams);
 
         OwnPtr<CacheWithResponsesCallbacks> ownedCallbacks(adoptPtr(callbacks));
-        WebServiceWorkerCacheError error = m_error;
-        return callbacks->onError(&error);
+        return callbacks->onError(new WebServiceWorkerCacheError(m_error));
     }
 
     virtual void dispatchKeys(CacheWithRequestsCallbacks* callbacks, const WebServiceWorkerRequest* webRequest, const QueryParams& queryParams) override
     {
         m_lastErrorWebCacheMethodCalled = "dispatchKeys";
         if (webRequest) {
             checkUrlIfProvided(webRequest->url());
             checkQueryParamsIfProvided(queryParams);
         }
 
         OwnPtr<CacheWithRequestsCallbacks> ownedCallbacks(adoptPtr(callbacks));
-        WebServiceWorkerCacheError error = m_error;
-        return callbacks->onError(&error);
+        return callbacks->onError(new WebServiceWorkerCacheError(m_error));
     }
 
     virtual void dispatchBatch(CacheBatchCallbacks* callbacks, const WebVector<BatchOperation>& batchOperations) override
     {
         m_lastErrorWebCacheMethodCalled = "dispatchBatch";
         checkBatchOperationsIfProvided(batchOperations);
 
         OwnPtr<CacheBatchCallbacks> ownedCallbacks(adoptPtr(callbacks));
-        WebServiceWorkerCacheError error = m_error;
-        return callbacks->onError(&error);
+        return callbacks->onError(new WebServiceWorkerCacheError(m_error));
     }
 
 protected:
     void checkUrlIfProvided(const KURL& url)
     {
         if (!m_expectedUrl)
             return;
         EXPECT_EQ(*m_expectedUrl, url);
     }
 
@@ skipping 486 matching lines @@
 
     ScriptPromise addResult = cache->add(scriptState(), requestToRequestInfo(request), exceptionState());
 
     EXPECT_EQ(kNotImplementedString, getRejectString(addResult));
     EXPECT_EQ(1, fetcher()->fetchCount());
     EXPECT_EQ("dispatchBatch", testCache->getAndClearLastErrorWebCacheMethodCalled());
 }
 
 } // namespace
 } // namespace blink