Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 1150413004: CacheStorage: Pass an error object allocated on heap to WebCallbacks::onError (4) (Closed)

Created:
4 years, 11 months ago by nhiroki
Modified:
4 years, 10 months ago
Reviewers:
tkent, jkarlin
CC:
blink-reviews, dglazkov+blink, serviceworker-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@cache_error_2
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

CacheStorage: Pass an error object allocated on heap to WebCallbacks::onError (4) This is a preliminary patch to simplify memory management in CallbackPromiseAdapter. See (1) for details. (1) Chromium: https://codereview.chromium.org/1152003008 (2) Blink: https://codereview.chromium.org/1155573003 (3) Chromium: https://codereview.chromium.org/1150333003 (4) Blink: THIS PATCH BUG=494884 TEST=n/a Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197360

Patch Set 1 : #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M public/platform/WebServiceWorkerCacheError.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
jkarlin
lgtm
4 years, 10 months ago (2015-06-17 12:14:36 UTC) #3
nhiroki
+tkent@, ptal, thanks!
4 years, 10 months ago (2015-06-18 01:05:24 UTC) #5
tkent
lgtm
4 years, 10 months ago (2015-06-18 01:06:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1150413004/40001
4 years, 10 months ago (2015-06-18 13:56:14 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2015-06-18 15:19:35 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197360

Powered by Google App Engine
This is Rietveld 408576698