Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 115113006: Rename Launcher to Shelf. (Closed)

Created:
7 years ago by tfarina
Modified:
7 years ago
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org, tfarina
Visibility:
Public.

Description

Rename Launcher to Shelf. - move launcher* from launcher to shelf. - rename to launcher.* to shelf.* and launcher_unittest.cc to shelf_unittest.cc - rename LauncherTestAPI to ShelfTestAPI. - rename to launcher_test_api.* to shelf_test_api.* BUG=248353 TEST=None, no functional changes R=jamescook@chromium.org,harrym@chromium.org TBR=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241794

Patch Set 1 #

Patch Set 2 : first buck of changes #

Patch Set 3 : LINK #

Patch Set 4 : ShelfTestAPI #

Total comments: 10

Patch Set 5 : James review #

Patch Set 6 : fix window_sizer_ash_uitest.cc #

Patch Set 7 : fixes to chrome_launcher_controller_browsertest.cc #

Patch Set 8 : fix win #

Patch Set 9 : rebase #

Patch Set 10 : shelf_view_unittest.cc fixes #

Patch Set 11 : chrome_launcher_controller_browsertest.cc fixes #

Patch Set 12 : more fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+926 lines, -1461 lines) Patch
M ash/accelerators/accelerator_controller.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M ash/ash.gyp View 1 2 3 4 5 6 7 8 9 6 chunks +7 lines, -7 lines 0 comments Download
M ash/dip_unittest.cc View 1 2 3 chunks +7 lines, -7 lines 0 comments Download
M ash/display/display_controller_unittest.cc View 1 2 13 chunks +25 lines, -25 lines 0 comments Download
M ash/display/root_window_transformers_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/first_run/first_run_helper_impl.cc View 1 2 3 chunks +5 lines, -6 lines 0 comments Download
M ash/focus_cycler_unittest.cc View 1 2 3 4 3 chunks +5 lines, -5 lines 0 comments Download
D ash/launcher/launcher.h View 1 chunk +0 lines, -132 lines 0 comments Download
D ash/launcher/launcher.cc View 1 chunk +0 lines, -198 lines 0 comments Download
M ash/launcher/launcher_types.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
D ash/launcher/launcher_unittest.cc View 1 chunk +0 lines, -166 lines 0 comments Download
M ash/metrics/user_metrics_recorder.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M ash/root_window_controller.h View 1 2 4 chunks +9 lines, -9 lines 0 comments Download
M ash/root_window_controller.cc View 1 2 3 4 5 3 chunks +9 lines, -9 lines 0 comments Download
M ash/shelf/overflow_bubble.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ash/shelf/overflow_bubble_view.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/overflow_bubble_view.cc View 1 2 3 4 4 chunks +10 lines, -13 lines 0 comments Download
M ash/shelf/overflow_button.cc View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
A + ash/shelf/shelf.h View 1 2 3 7 chunks +25 lines, -26 lines 0 comments Download
A + ash/shelf/shelf.cc View 1 2 6 chunks +36 lines, -36 lines 0 comments Download
M ash/shelf/shelf_alignment_menu.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_delegate.h View 1 1 chunk +11 lines, -11 lines 0 comments Download
M ash/shelf/shelf_layout_manager.h View 1 2 11 chunks +17 lines, -17 lines 0 comments Download
M ash/shelf/shelf_layout_manager.cc View 1 2 12 chunks +20 lines, -20 lines 0 comments Download
M ash/shelf/shelf_layout_manager_unittest.cc View 1 2 3 16 chunks +32 lines, -33 lines 0 comments Download
M ash/shelf/shelf_navigator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_tooltip_manager_unittest.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
A + ash/shelf/shelf_unittest.cc View 1 2 3 8 chunks +21 lines, -22 lines 0 comments Download
M ash/shelf/shelf_util.h View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M ash/shelf/shelf_util.cc View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M ash/shelf/shelf_view.cc View 1 2 3 4 5 6 15 chunks +18 lines, -18 lines 0 comments Download
M ash/shelf/shelf_view_unittest.cc View 1 2 3 4 5 6 7 8 9 28 chunks +54 lines, -57 lines 0 comments Download
M ash/shelf/shelf_widget.h View 1 2 3 4 3 chunks +9 lines, -9 lines 0 comments Download
M ash/shelf/shelf_widget.cc View 1 2 3 4 10 chunks +74 lines, -56 lines 0 comments Download
M ash/shelf/shelf_widget_unittest.cc View 1 2 3 7 chunks +24 lines, -24 lines 0 comments Download
M ash/shelf/shelf_window_watcher.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M ash/shelf/shelf_window_watcher_unittest.cc View 1 2 3 4 6 chunks +12 lines, -12 lines 0 comments Download
M ash/shell.h View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M ash/shell.cc View 1 2 3 4 6 chunks +11 lines, -11 lines 0 comments Download
M ash/shell/content_client/shell_browser_main_parts.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/context_menu.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/shelf_delegate_impl.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ash/shell/shelf_delegate_impl.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ash/shell/window_watcher.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M ash/shell/window_watcher_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/shell_unittest.cc View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M ash/system/chromeos/audio/tray_audio.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/audio/tray_audio.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/brightness/tray_brightness.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/brightness/tray_brightness.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/system/status_area_widget.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M ash/system/status_area_widget.cc View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M ash/system/tray/system_tray.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/tray/system_tray.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M ash/system/tray/system_tray_bubble.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/tray/system_tray_bubble.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/tray/system_tray_item.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M ash/system/tray/system_tray_item.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_background_view.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ash/system/web_notification/web_notification_tray.h View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/web_notification/web_notification_tray.cc View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -2 lines 0 comments Download
M ash/test/launcher_test_api.h View 1 2 3 1 chunk +0 lines, -43 lines 0 comments Download
M ash/test/launcher_test_api.cc View 1 2 3 1 chunk +0 lines, -28 lines 0 comments Download
A + ash/test/shelf_test_api.h View 1 2 3 3 chunks +10 lines, -10 lines 0 comments Download
A ash/test/shelf_test_api.cc View 1 2 3 1 chunk +28 lines, -0 lines 0 comments Download
M ash/test/test_session_state_delegate.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ash/test/test_shelf_delegate.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ash/test/test_shelf_delegate.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M ash/wm/app_list_controller.cc View 1 2 9 chunks +11 lines, -11 lines 0 comments Download
M ash/wm/base_layout_manager_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/dock/docked_window_layout_manager.h View 1 6 chunks +8 lines, -8 lines 0 comments Download
M ash/wm/dock/docked_window_layout_manager.cc View 1 2 11 chunks +56 lines, -49 lines 0 comments Download
M ash/wm/dock/docked_window_layout_manager_unittest.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/dock/docked_window_resizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/dock/docked_window_resizer_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/gestures/system_pinch_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/overview/window_selector_unittest.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/panels/panel_layout_manager.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
M ash/wm/panels/panel_layout_manager.cc View 1 2 16 chunks +37 lines, -39 lines 0 comments Download
M ash/wm/panels/panel_layout_manager_unittest.cc View 1 2 3 4 16 chunks +33 lines, -36 lines 0 comments Download
M ash/wm/panels/panel_window_resizer.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M ash/wm/panels/panel_window_resizer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/system_gesture_event_filter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_animations.cc View 1 2 4 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/metro_viewer/chrome_metro_viewer_process_host_aurawin.cc View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.h View 1 2 3 4 5 6 7 8 9 10 11 13 chunks +22 lines, -22 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 1 2 3 4 3 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 61 chunks +145 lines, -150 lines 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/shelf_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 2 3 4 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_ash_uitest.cc View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
tfarina
Big rename (that was my Sunday). PTAL.
7 years ago (2013-12-16 01:55:10 UTC) #1
James Cook
LGTM with nits. Wow, this must have been a lot of work. harrym is out ...
7 years ago (2013-12-16 23:34:52 UTC) #2
tfarina
https://codereview.chromium.org/115113006/diff/60001/ash/shelf/overflow_bubble_view.h File ash/shelf/overflow_bubble_view.h (right): https://codereview.chromium.org/115113006/diff/60001/ash/shelf/overflow_bubble_view.h#newcode58 ash/shelf/overflow_bubble_view.h:58: ShelfLayoutManager* GetShelfLayoutManagerForShelf() const; On 2013/12/16 23:34:52, James Cook wrote: ...
7 years ago (2013-12-17 00:45:23 UTC) #3
tfarina
https://codereview.chromium.org/115113006/diff/60001/ash/shelf/overflow_bubble_view.h File ash/shelf/overflow_bubble_view.h (right): https://codereview.chromium.org/115113006/diff/60001/ash/shelf/overflow_bubble_view.h#newcode58 ash/shelf/overflow_bubble_view.h:58: ShelfLayoutManager* GetShelfLayoutManagerForShelf() const; On 2013/12/16 23:34:52, James Cook wrote: ...
7 years ago (2013-12-17 00:45:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/115113006/80001
7 years ago (2013-12-17 00:56:10 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=41727
7 years ago (2013-12-17 01:21:49 UTC) #6
tfarina
TBRing Scott for chrome/browser/ui/window_sizer/window_sizer_ash_uitest.cc
7 years ago (2013-12-17 01:27:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/115113006/80001
7 years ago (2013-12-17 01:30:02 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) app_list_unittests, ash_unittests, aura_unittests, base_unittests, browser_tests, cacheinvalidation_unittests, ...
7 years ago (2013-12-17 04:07:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/115113006/100001
7 years ago (2013-12-17 12:22:05 UTC) #10
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) app_list_unittests, ash_unittests, aura_unittests, base_unittests, browser_tests, cacheinvalidation_unittests, ...
7 years ago (2013-12-17 13:30:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/115113006/120002
7 years ago (2013-12-17 23:49:10 UTC) #12
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) app_list_unittests, ash_unittests, aura_unittests, base_unittests, browser_tests, cacheinvalidation_unittests, ...
7 years ago (2013-12-18 01:06:40 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/115113006/150001
7 years ago (2013-12-18 12:48:05 UTC) #14
commit-bot: I haz the power
Retried try job too often on linux_chromeos_clang for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos_clang&number=64056
7 years ago (2013-12-18 13:53:30 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/115113006/170001
7 years ago (2013-12-18 22:28:56 UTC) #16
commit-bot: I haz the power
Failed to trigger a try job on linux_chromeos HTTP Error 400: Bad Request
7 years ago (2013-12-18 23:21:13 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/115113006/190001
7 years ago (2013-12-18 23:22:09 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/115113006/210001
7 years ago (2013-12-19 01:35:26 UTC) #19
commit-bot: I haz the power
7 years ago (2013-12-19 04:19:44 UTC) #20
Message was sent while issue was closed. 
Change committed as 241794

Powered by Google App Engine
This is Rietveld 408576698