Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc

Issue 115113006: Rename Launcher to Shelf. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more fixes Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc
diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc
index bf4ad29597140b1f330e25e3b8167420b99e23b9..e5a8ff790a19cd2d48a58d5f8efae2c0b6d1f4a1 100644
--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc
+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc
@@ -9,14 +9,14 @@
#include "apps/ui/native_app_window.h"
#include "ash/ash_switches.h"
#include "ash/display/display_controller.h"
-#include "ash/launcher/launcher.h"
+#include "ash/shelf/shelf.h"
#include "ash/shelf/shelf_button.h"
#include "ash/shelf/shelf_model.h"
#include "ash/shelf/shelf_util.h"
#include "ash/shelf/shelf_view.h"
#include "ash/shell.h"
#include "ash/test/app_list_controller_test_api.h"
-#include "ash/test/launcher_test_api.h"
+#include "ash/test/shelf_test_api.h"
#include "ash/test/shelf_view_test_api.h"
#include "ash/test/shell_test_api.h"
#include "ash/wm/window_state.h"
@@ -114,13 +114,13 @@ class TestShellWindowRegistryObserver
class LauncherPlatformAppBrowserTest
: public extensions::PlatformAppBrowserTest {
protected:
- LauncherPlatformAppBrowserTest() : launcher_(NULL), controller_(NULL) {
+ LauncherPlatformAppBrowserTest() : shelf_(NULL), controller_(NULL) {
}
virtual ~LauncherPlatformAppBrowserTest() {}
virtual void RunTestOnMainThreadLoop() OVERRIDE {
- launcher_ = ash::Launcher::ForPrimaryDisplay();
+ shelf_ = ash::Shelf::ForPrimaryDisplay();
controller_ = ChromeLauncherController::instance();
return extensions::PlatformAppBrowserTest::RunTestOnMainThreadLoop();
}
@@ -141,7 +141,7 @@ class LauncherPlatformAppBrowserTest
}
const ash::LauncherItem& GetLastLauncherPanelItem() {
- // Panels show up on the right side of the launcher, so the desired item
+ // Panels show up on the right side of the shelf, so the desired item
// will be the last one.
return shelf_model()->items()[shelf_model()->item_count() - 1];
}
@@ -163,12 +163,12 @@ class LauncherPlatformAppBrowserTest
return num_items;
}
- // Activate the launcher item with the given |id|.
- void ActivateLauncherItem(int id) {
- launcher_->ActivateLauncherItem(id);
+ // Activate the shelf item with the given |id|.
+ void ActivateShelfItem(int id) {
+ shelf_->ActivateShelfItem(id);
}
- ash::Launcher* launcher_;
+ ash::Shelf* shelf_;
ChromeLauncherController* controller_;
private:
@@ -187,15 +187,15 @@ enum RipOffCommand {
RIP_OFF_ITEM_AND_DONT_RELEASE_MOUSE,
};
-class LauncherAppBrowserTest : public ExtensionBrowserTest {
+class ShelfAppBrowserTest : public ExtensionBrowserTest {
protected:
- LauncherAppBrowserTest() : launcher_(NULL), model_(NULL), controller_(NULL) {
+ ShelfAppBrowserTest() : shelf_(NULL), model_(NULL), controller_(NULL) {
}
- virtual ~LauncherAppBrowserTest() {}
+ virtual ~ShelfAppBrowserTest() {}
virtual void RunTestOnMainThreadLoop() OVERRIDE {
- launcher_ = ash::Launcher::ForPrimaryDisplay();
+ shelf_ = ash::Shelf::ForPrimaryDisplay();
model_ = ash::test::ShellTestApi(ash::Shell::GetInstance()).shelf_model();
controller_ = ChromeLauncherController::instance();
return ExtensionBrowserTest::RunTestOnMainThreadLoop();
@@ -255,9 +255,9 @@ class LauncherAppBrowserTest : public ExtensionBrowserTest {
controller_->Unpin(id);
}
- // Activate the launcher item with the given |id|.
- void ActivateLauncherItem(int id) {
- launcher_->ActivateLauncherItem(id);
+ // Activate the shelf item with the given |id|.
+ void ActivateShelfItem(int id) {
+ shelf_->ActivateShelfItem(id);
}
ash::LauncherID PinFakeApp(const std::string& name) {
@@ -300,37 +300,36 @@ class LauncherAppBrowserTest : public ExtensionBrowserTest {
}
}
- ash::Launcher* launcher_;
+ ash::Shelf* shelf_;
ash::ShelfModel* model_;
ChromeLauncherController* controller_;
private:
- DISALLOW_COPY_AND_ASSIGN(LauncherAppBrowserTest);
+ DISALLOW_COPY_AND_ASSIGN(ShelfAppBrowserTest);
};
-class LauncherAppBrowserTestNoDefaultBrowser : public LauncherAppBrowserTest {
+class ShelfAppBrowserTestNoDefaultBrowser : public ShelfAppBrowserTest {
protected:
- LauncherAppBrowserTestNoDefaultBrowser() {}
- virtual ~LauncherAppBrowserTestNoDefaultBrowser() {}
+ ShelfAppBrowserTestNoDefaultBrowser() {}
+ virtual ~ShelfAppBrowserTestNoDefaultBrowser() {}
virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {
- LauncherAppBrowserTest::SetUpCommandLine(command_line);
+ ShelfAppBrowserTest::SetUpCommandLine(command_line);
command_line->AppendSwitch(switches::kNoStartupWindow);
}
private:
- DISALLOW_COPY_AND_ASSIGN(LauncherAppBrowserTestNoDefaultBrowser);
+ DISALLOW_COPY_AND_ASSIGN(ShelfAppBrowserTestNoDefaultBrowser);
};
// Since the default for minimizing on click might change, I added both classes
// to either get the minimize on click or not.
-class LauncherAppBrowserNoMinimizeOnClick
- : public LauncherPlatformAppBrowserTest {
+class ShelfAppBrowserNoMinimizeOnClick : public LauncherPlatformAppBrowserTest {
protected:
- LauncherAppBrowserNoMinimizeOnClick() {}
- virtual ~LauncherAppBrowserNoMinimizeOnClick() {}
+ ShelfAppBrowserNoMinimizeOnClick() {}
+ virtual ~ShelfAppBrowserNoMinimizeOnClick() {}
virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {
LauncherPlatformAppBrowserTest::SetUpCommandLine(command_line);
@@ -340,10 +339,10 @@ class LauncherAppBrowserNoMinimizeOnClick
private:
- DISALLOW_COPY_AND_ASSIGN(LauncherAppBrowserNoMinimizeOnClick);
+ DISALLOW_COPY_AND_ASSIGN(ShelfAppBrowserNoMinimizeOnClick);
};
-typedef LauncherPlatformAppBrowserTest LauncherAppBrowserMinimizeOnClick;
+typedef LauncherPlatformAppBrowserTest ShelfAppBrowserMinimizeOnClick;
// Test that we can launch a platform app and get a running item.
IN_PROC_BROWSER_TEST_F(LauncherPlatformAppBrowserTest, LaunchUnpinned) {
@@ -583,14 +582,14 @@ IN_PROC_BROWSER_TEST_F(LauncherPlatformAppBrowserTest, WindowActivation) {
EXPECT_EQ(ash::STATUS_RUNNING, shelf_model()->ItemByID(item_id1)->status);
// Activate first one.
- ActivateLauncherItem(shelf_model()->ItemIndexByID(item_id1));
+ ActivateShelfItem(shelf_model()->ItemIndexByID(item_id1));
EXPECT_EQ(ash::STATUS_ACTIVE, shelf_model()->ItemByID(item_id1)->status);
EXPECT_EQ(ash::STATUS_RUNNING, shelf_model()->ItemByID(item_id2)->status);
EXPECT_TRUE(ash::wm::IsActiveWindow(window1->GetNativeWindow()));
EXPECT_FALSE(ash::wm::IsActiveWindow(window2->GetNativeWindow()));
// Activate second one.
- ActivateLauncherItem(shelf_model()->ItemIndexByID(item_id2));
+ ActivateShelfItem(shelf_model()->ItemIndexByID(item_id2));
EXPECT_EQ(ash::STATUS_RUNNING, shelf_model()->ItemByID(item_id1)->status);
EXPECT_EQ(ash::STATUS_ACTIVE, shelf_model()->ItemByID(item_id2)->status);
EXPECT_FALSE(ash::wm::IsActiveWindow(window1->GetNativeWindow()));
@@ -604,20 +603,20 @@ IN_PROC_BROWSER_TEST_F(LauncherPlatformAppBrowserTest, WindowActivation) {
EXPECT_TRUE(ash::wm::IsActiveWindow(window1b->GetNativeWindow()));
// Activate launcher item for app1, this will activate the first app window.
- ActivateLauncherItem(shelf_model()->ItemIndexByID(item_id1));
+ ActivateShelfItem(shelf_model()->ItemIndexByID(item_id1));
EXPECT_TRUE(ash::wm::IsActiveWindow(window1->GetNativeWindow()));
EXPECT_FALSE(ash::wm::IsActiveWindow(window1b->GetNativeWindow()));
- ActivateLauncherItem(shelf_model()->ItemIndexByID(item_id1));
+ ActivateShelfItem(shelf_model()->ItemIndexByID(item_id1));
EXPECT_TRUE(ash::wm::IsActiveWindow(window1b->GetNativeWindow()));
// Activate the second app again
- ActivateLauncherItem(shelf_model()->ItemIndexByID(item_id2));
+ ActivateShelfItem(shelf_model()->ItemIndexByID(item_id2));
EXPECT_FALSE(ash::wm::IsActiveWindow(window1->GetNativeWindow()));
EXPECT_TRUE(ash::wm::IsActiveWindow(window2->GetNativeWindow()));
EXPECT_FALSE(ash::wm::IsActiveWindow(window1b->GetNativeWindow()));
// Activate the first app again
- ActivateLauncherItem(shelf_model()->ItemIndexByID(item_id1));
+ ActivateShelfItem(shelf_model()->ItemIndexByID(item_id1));
EXPECT_TRUE(ash::wm::IsActiveWindow(window1b->GetNativeWindow()));
EXPECT_FALSE(ash::wm::IsActiveWindow(window2->GetNativeWindow()));
EXPECT_FALSE(ash::wm::IsActiveWindow(window1->GetNativeWindow()));
@@ -637,8 +636,7 @@ IN_PROC_BROWSER_TEST_F(LauncherPlatformAppBrowserTest, WindowActivation) {
}
// Confirm that Click behavior for app windows is correnct.
-IN_PROC_BROWSER_TEST_F(LauncherAppBrowserNoMinimizeOnClick,
- AppClickBehavior) {
+IN_PROC_BROWSER_TEST_F(ShelfAppBrowserNoMinimizeOnClick, AppClickBehavior) {
// Launch a platform app and create a window for it.
const Extension* extension1 = LoadAndLaunchPlatformApp("launch");
ShellWindow* window1 = CreateShellWindow(extension1);
@@ -675,7 +673,7 @@ IN_PROC_BROWSER_TEST_F(LauncherAppBrowserNoMinimizeOnClick,
}
// Confirm the minimizing click behavior for apps.
-IN_PROC_BROWSER_TEST_F(LauncherAppBrowserMinimizeOnClick,
+IN_PROC_BROWSER_TEST_F(ShelfAppBrowserMinimizeOnClick,
PackagedAppClickBehaviorInMinimizeMode) {
// Launch one platform app and create a window for it.
const Extension* extension1 = LoadAndLaunchPlatformApp("launch");
@@ -793,7 +791,7 @@ IN_PROC_BROWSER_TEST_F(LauncherPlatformAppBrowserTest, SetIcon) {
CommandLine::ForCurrentProcess()->AppendSwitch(
extensions::switches::kEnableExperimentalExtensionApis);
- int base_launcher_item_count = shelf_model()->item_count();
+ int base_shelf_item_count = shelf_model()->item_count();
ExtensionTestMessageListener launched_listener("Launched", false);
ExtensionTestMessageListener completed_listener("Completed", false);
LoadAndLaunchPlatformApp("app_icon");
@@ -809,13 +807,13 @@ IN_PROC_BROWSER_TEST_F(LauncherPlatformAppBrowserTest, SetIcon) {
}
// This test creates one shell window and one panel window.
- int launcher_item_count = shelf_model()->item_count();
- ASSERT_EQ(base_launcher_item_count + 2, launcher_item_count);
+ int shelf_item_count = shelf_model()->item_count();
+ ASSERT_EQ(base_shelf_item_count + 2, shelf_item_count);
// The Panel will be the last item, the app second-to-last.
const ash::LauncherItem& app_item =
- shelf_model()->items()[launcher_item_count - 2];
+ shelf_model()->items()[shelf_item_count - 2];
const ash::LauncherItem& panel_item =
- shelf_model()->items()[launcher_item_count - 1];
+ shelf_model()->items()[shelf_item_count - 1];
const LauncherItemController* app_item_controller =
GetItemController(app_item.id);
const LauncherItemController* panel_item_controller =
@@ -830,12 +828,12 @@ IN_PROC_BROWSER_TEST_F(LauncherPlatformAppBrowserTest, SetIcon) {
}
// Test that we can launch an app with a shortcut.
-IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, LaunchPinned) {
+IN_PROC_BROWSER_TEST_F(ShelfAppBrowserTest, LaunchPinned) {
TabStripModel* tab_strip = browser()->tab_strip_model();
int tab_count = tab_strip->count();
ash::LauncherID shortcut_id = CreateShortcut("app1");
EXPECT_EQ(ash::STATUS_CLOSED, (*model_->ItemByID(shortcut_id)).status);
- ActivateLauncherItem(model_->ItemIndexByID(shortcut_id));
+ ActivateShelfItem(model_->ItemIndexByID(shortcut_id));
EXPECT_EQ(++tab_count, tab_strip->count());
EXPECT_EQ(ash::STATUS_ACTIVE, (*model_->ItemByID(shortcut_id)).status);
WebContents* tab = tab_strip->GetActiveWebContents();
@@ -847,7 +845,7 @@ IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, LaunchPinned) {
}
// Launch the app first and then create the shortcut.
-IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, LaunchUnpinned) {
+IN_PROC_BROWSER_TEST_F(ShelfAppBrowserTest, LaunchUnpinned) {
TabStripModel* tab_strip = browser()->tab_strip_model();
int tab_count = tab_strip->count();
LoadAndLaunchExtension("app1", extensions::LAUNCH_CONTAINER_TAB,
@@ -865,7 +863,7 @@ IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, LaunchUnpinned) {
// Launches an app in the background and then tries to open it. This is test for
// a crash we had.
-IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, LaunchInBackground) {
+IN_PROC_BROWSER_TEST_F(ShelfAppBrowserTest, LaunchInBackground) {
TabStripModel* tab_strip = browser()->tab_strip_model();
int tab_count = tab_strip->count();
LoadAndLaunchExtension("app1", extensions::LAUNCH_CONTAINER_TAB,
@@ -878,7 +876,7 @@ IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, LaunchInBackground) {
// Confirm that clicking a icon for an app running in one of 2 maxmized windows
// activates the right window.
-IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, LaunchMaximized) {
+IN_PROC_BROWSER_TEST_F(ShelfAppBrowserTest, LaunchMaximized) {
aura::Window* window1 = browser()->window()->GetNativeWindow();
ash::wm::WindowState* window1_state = ash::wm::GetWindowState(window1);
window1_state->Maximize();
@@ -894,7 +892,7 @@ IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, LaunchMaximized) {
ash::wm::GetWindowState(window2)->Maximize();
ash::LauncherID shortcut_id = CreateShortcut("app1");
- ActivateLauncherItem(model_->ItemIndexByID(shortcut_id));
+ ActivateShelfItem(model_->ItemIndexByID(shortcut_id));
EXPECT_EQ(++tab_count, tab_strip->count());
EXPECT_EQ(ash::STATUS_ACTIVE, (*model_->ItemByID(shortcut_id)).status);
@@ -902,12 +900,12 @@ IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, LaunchMaximized) {
window1_state->Activate();
EXPECT_EQ(ash::STATUS_RUNNING, (*model_->ItemByID(shortcut_id)).status);
- ActivateLauncherItem(model_->ItemIndexByID(shortcut_id));
+ ActivateShelfItem(model_->ItemIndexByID(shortcut_id));
EXPECT_EQ(ash::STATUS_ACTIVE, (*model_->ItemByID(shortcut_id)).status);
}
// Activating the same app multiple times should launch only a single copy.
-IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, ActivateApp) {
+IN_PROC_BROWSER_TEST_F(ShelfAppBrowserTest, ActivateApp) {
TabStripModel* tab_strip = browser()->tab_strip_model();
int tab_count = tab_strip->count();
const Extension* extension =
@@ -924,7 +922,7 @@ IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, ActivateApp) {
}
// Launching the same app multiple times should launch a copy for each call.
-IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, LaunchApp) {
+IN_PROC_BROWSER_TEST_F(ShelfAppBrowserTest, LaunchApp) {
TabStripModel* tab_strip = browser()->tab_strip_model();
int tab_count = tab_strip->count();
const Extension* extension =
@@ -941,7 +939,7 @@ IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, LaunchApp) {
}
// Launch 2 apps and toggle which is active.
-IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, MultipleApps) {
+IN_PROC_BROWSER_TEST_F(ShelfAppBrowserTest, MultipleApps) {
int item_count = model_->item_count();
TabStripModel* tab_strip = browser()->tab_strip_model();
int tab_count = tab_strip->count();
@@ -951,13 +949,13 @@ IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, MultipleApps) {
EXPECT_EQ(++item_count, model_->item_count());
// Launch first app.
- ActivateLauncherItem(model_->ItemIndexByID(shortcut1));
+ ActivateShelfItem(model_->ItemIndexByID(shortcut1));
EXPECT_EQ(++tab_count, tab_strip->count());
WebContents* tab1 = tab_strip->GetActiveWebContents();
EXPECT_EQ(ash::STATUS_ACTIVE, (*model_->ItemByID(shortcut1)).status);
// Launch second app.
- ActivateLauncherItem(model_->ItemIndexByID(shortcut2));
+ ActivateShelfItem(model_->ItemIndexByID(shortcut2));
EXPECT_EQ(++tab_count, tab_strip->count());
WebContents* tab2 = tab_strip->GetActiveWebContents();
ASSERT_NE(tab1, tab2);
@@ -965,7 +963,7 @@ IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, MultipleApps) {
EXPECT_EQ(ash::STATUS_ACTIVE, (*model_->ItemByID(shortcut2)).status);
// Reactivate first app.
- ActivateLauncherItem(model_->ItemIndexByID(shortcut1));
+ ActivateShelfItem(model_->ItemIndexByID(shortcut1));
EXPECT_EQ(tab_count, tab_strip->count());
EXPECT_EQ(tab_strip->GetActiveWebContents(), tab1);
EXPECT_EQ(ash::STATUS_ACTIVE, (*model_->ItemByID(shortcut1)).status);
@@ -982,14 +980,14 @@ IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, MultipleApps) {
EXPECT_EQ(ash::STATUS_ACTIVE, (*model_->ItemByID(shortcut2)).status);
// Reactivate first app.
- ActivateLauncherItem(model_->ItemIndexByID(shortcut1));
+ ActivateShelfItem(model_->ItemIndexByID(shortcut1));
EXPECT_EQ(tab_count, tab_strip->count());
EXPECT_EQ(tab_strip->GetActiveWebContents(), tab1);
EXPECT_EQ(ash::STATUS_ACTIVE, (*model_->ItemByID(shortcut1)).status);
EXPECT_EQ(ash::STATUS_RUNNING, (*model_->ItemByID(shortcut2)).status);
// And second again. This time the second tab should become active.
- ActivateLauncherItem(model_->ItemIndexByID(shortcut2));
+ ActivateShelfItem(model_->ItemIndexByID(shortcut2));
EXPECT_EQ(tab_count, tab_strip->count());
EXPECT_EQ(tab_strip->GetActiveWebContents(), tab2);
EXPECT_EQ(ash::STATUS_RUNNING, (*model_->ItemByID(shortcut1)).status);
@@ -998,10 +996,10 @@ IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, MultipleApps) {
// Confirm that a page can be navigated from and to while maintaining the
// correct running state.
-IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, Navigation) {
+IN_PROC_BROWSER_TEST_F(ShelfAppBrowserTest, Navigation) {
ash::LauncherID shortcut_id = CreateShortcut("app1");
EXPECT_EQ(ash::STATUS_CLOSED, (*model_->ItemByID(shortcut_id)).status);
- ActivateLauncherItem(model_->ItemIndexByID(shortcut_id));
+ ActivateShelfItem(model_->ItemIndexByID(shortcut_id));
EXPECT_EQ(ash::STATUS_ACTIVE, (*model_->ItemByID(shortcut_id)).status);
// Navigate away.
@@ -1017,7 +1015,7 @@ IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, Navigation) {
// Confirm that a tab can be moved between browsers while maintaining the
// correct running state.
-IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, TabDragAndDrop) {
+IN_PROC_BROWSER_TEST_F(ShelfAppBrowserTest, TabDragAndDrop) {
TabStripModel* tab_strip_model1 = browser()->tab_strip_model();
EXPECT_EQ(1, tab_strip_model1->count());
int browser_index = GetIndexOfShelfItemType(ash::TYPE_BROWSER_SHORTCUT);
@@ -1030,7 +1028,7 @@ IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, TabDragAndDrop) {
EXPECT_EQ(ash::STATUS_CLOSED, (*model_->ItemByID(shortcut_id)).status);
// Activate app1 and check its item status.
- ActivateLauncherItem(model_->ItemIndexByID(shortcut_id));
+ ActivateShelfItem(model_->ItemIndexByID(shortcut_id));
EXPECT_EQ(2, tab_strip_model1->count());
EXPECT_EQ(ash::STATUS_RUNNING, model_->items()[browser_index].status);
EXPECT_EQ(ash::STATUS_ACTIVE, (*model_->ItemByID(shortcut_id)).status);
@@ -1058,11 +1056,11 @@ IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, TabDragAndDrop) {
tab_strip_model2->CloseAllTabs();
}
-IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, MultipleOwnedTabs) {
+IN_PROC_BROWSER_TEST_F(ShelfAppBrowserTest, MultipleOwnedTabs) {
TabStripModel* tab_strip = browser()->tab_strip_model();
int tab_count = tab_strip->count();
ash::LauncherID shortcut_id = CreateShortcut("app1");
- ActivateLauncherItem(model_->ItemIndexByID(shortcut_id));
+ ActivateShelfItem(model_->ItemIndexByID(shortcut_id));
EXPECT_EQ(++tab_count, tab_strip->count());
EXPECT_EQ(ash::STATUS_ACTIVE, model_->ItemByID(shortcut_id)->status);
WebContents* first_tab = tab_strip->GetActiveWebContents();
@@ -1088,16 +1086,16 @@ IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, MultipleOwnedTabs) {
EXPECT_EQ(ash::STATUS_RUNNING, model_->ItemByID(shortcut_id)->status);
// Activating app makes first tab active again.
- ActivateLauncherItem(model_->ItemIndexByID(shortcut_id));
+ ActivateShelfItem(model_->ItemIndexByID(shortcut_id));
EXPECT_EQ(ash::STATUS_ACTIVE, model_->ItemByID(shortcut_id)->status);
EXPECT_EQ(tab_strip->GetActiveWebContents(), first_tab);
}
-IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, RefocusFilter) {
+IN_PROC_BROWSER_TEST_F(ShelfAppBrowserTest, RefocusFilter) {
TabStripModel* tab_strip = browser()->tab_strip_model();
int tab_count = tab_strip->count();
ash::LauncherID shortcut_id = CreateShortcut("app1");
- ActivateLauncherItem(model_->ItemIndexByID(shortcut_id));
+ ActivateShelfItem(model_->ItemIndexByID(shortcut_id));
EXPECT_EQ(++tab_count, tab_strip->count());
EXPECT_EQ(ash::STATUS_ACTIVE, model_->ItemByID(shortcut_id)->status);
WebContents* first_tab = tab_strip->GetActiveWebContents();
@@ -1126,12 +1124,12 @@ IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, RefocusFilter) {
// Activating app makes first tab active again, because second tab isn't
// in its refocus url path.
- ActivateLauncherItem(model_->ItemIndexByID(shortcut_id));
+ ActivateShelfItem(model_->ItemIndexByID(shortcut_id));
EXPECT_EQ(ash::STATUS_ACTIVE, model_->ItemByID(shortcut_id)->status);
EXPECT_EQ(tab_strip->GetActiveWebContents(), first_tab);
}
-IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, RefocusFilterLaunch) {
+IN_PROC_BROWSER_TEST_F(ShelfAppBrowserTest, RefocusFilterLaunch) {
TabStripModel* tab_strip = browser()->tab_strip_model();
int tab_count = tab_strip->count();
ash::LauncherID shortcut_id = CreateShortcut("app1");
@@ -1151,7 +1149,7 @@ IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, RefocusFilterLaunch) {
// Activating app should launch new tab, because second tab isn't
// in its refocus url path.
- ActivateLauncherItem(model_->ItemIndexByID(shortcut_id));
+ ActivateShelfItem(model_->ItemIndexByID(shortcut_id));
EXPECT_EQ(++tab_count, tab_strip->count());
WebContents* second_tab = tab_strip->GetActiveWebContents();
EXPECT_EQ(ash::STATUS_ACTIVE, model_->ItemByID(shortcut_id)->status);
@@ -1160,7 +1158,7 @@ IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, RefocusFilterLaunch) {
}
// Check the launcher activation state for applications and browser.
-IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, ActivationStateCheck) {
+IN_PROC_BROWSER_TEST_F(ShelfAppBrowserTest, ActivationStateCheck) {
TabStripModel* tab_strip = browser()->tab_strip_model();
// Get the browser item index
int browser_index = GetIndexOfShelfItemType(ash::TYPE_BROWSER_SHORTCUT);
@@ -1203,7 +1201,7 @@ IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, ActivationStateCheck) {
// Check that the launcher activation state for a V1 application stays closed
// even after an asynchronous browser event comes in after the tab got
// destroyed.
-IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, AsyncActivationStateCheck) {
+IN_PROC_BROWSER_TEST_F(ShelfAppBrowserTest, AsyncActivationStateCheck) {
TabStripModel* tab_strip = browser()->tab_strip_model();
ash::LauncherID shortcut_id = CreateShortcut("app1");
@@ -1232,7 +1230,7 @@ IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, AsyncActivationStateCheck) {
}
// Checks that a windowed application does not add an item to the browser list.
-IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTestNoDefaultBrowser,
+IN_PROC_BROWSER_TEST_F(ShelfAppBrowserTestNoDefaultBrowser,
WindowedAppDoesNotAddToBrowser) {
// Get the number of items in the browser menu.
size_t items = NumberOfDetectedLauncherBrowsers(false);
@@ -1255,8 +1253,8 @@ IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTestNoDefaultBrowser,
}
// Checks the functionality to enumerate all browsers vs. all tabs.
-IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTestNoDefaultBrowser,
- EnumerateALlBrowsersAndTabs) {
+IN_PROC_BROWSER_TEST_F(ShelfAppBrowserTestNoDefaultBrowser,
+ EnumerateALlBrowsersAndTabs) {
// Create at least one browser.
LoadAndLaunchExtension("app1", extensions::LAUNCH_CONTAINER_TAB, NEW_WINDOW);
size_t browsers = NumberOfDetectedLauncherBrowsers(false);
@@ -1278,7 +1276,7 @@ IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTestNoDefaultBrowser,
// Check that the keyboard activation of a launcher item tabs properly through
// the items at hand.
-IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, AltNumberTabsTabbing) {
+IN_PROC_BROWSER_TEST_F(ShelfAppBrowserTest, AltNumberTabsTabbing) {
TabStripModel* tab_strip = browser()->tab_strip_model();
ash::LauncherID shortcut_id = CreateShortcut("app");
@@ -1311,9 +1309,9 @@ IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, AltNumberTabsTabbing) {
// The active tab should still be the unnamed tab. Then we switch and reach
// the first app and stay there.
EXPECT_EQ(content1a, tab_strip->GetActiveWebContents());
- ActivateLauncherItem(shortcut_index);
+ ActivateShelfItem(shortcut_index);
EXPECT_EQ(content1, tab_strip->GetActiveWebContents());
- ActivateLauncherItem(shortcut_index);
+ ActivateShelfItem(shortcut_index);
EXPECT_EQ(content1, tab_strip->GetActiveWebContents());
ui_test_utils::NavigateToURLWithDisposition(
@@ -1324,9 +1322,9 @@ IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, AltNumberTabsTabbing) {
content::WebContents* content2 = tab_strip->GetActiveWebContents();
EXPECT_EQ(content2, browser()->tab_strip_model()->GetActiveWebContents());
- ActivateLauncherItem(shortcut_index);
+ ActivateShelfItem(shortcut_index);
EXPECT_EQ(content1, browser()->tab_strip_model()->GetActiveWebContents());
- ActivateLauncherItem(shortcut_index);
+ ActivateShelfItem(shortcut_index);
EXPECT_EQ(content2, browser()->tab_strip_model()->GetActiveWebContents());
}
@@ -1350,18 +1348,18 @@ IN_PROC_BROWSER_TEST_F(LauncherPlatformAppBrowserTest,
// By now the browser should be active. Issue Alt keystrokes several times to
// see that we stay on that application.
EXPECT_TRUE(window2->IsActive());
- ActivateLauncherItem(app_index);
+ ActivateShelfItem(app_index);
EXPECT_TRUE(window1->IsActive());
- ActivateLauncherItem(app_index);
+ ActivateShelfItem(app_index);
EXPECT_TRUE(window1->IsActive());
ui::BaseWindow* window1a = CreateShellWindow(extension1)->GetBaseWindow();
EXPECT_TRUE(window1a->IsActive());
EXPECT_FALSE(window1->IsActive());
- ActivateLauncherItem(app_index);
+ ActivateShelfItem(app_index);
EXPECT_TRUE(window1->IsActive());
- ActivateLauncherItem(app_index);
+ ActivateShelfItem(app_index);
EXPECT_TRUE(window1a->IsActive());
}
@@ -1417,15 +1415,15 @@ IN_PROC_BROWSER_TEST_F(LauncherPlatformAppBrowserTest, WindowAttentionStatus) {
}
// Checks that the browser Alt "tabbing" is properly done.
-IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTestNoDefaultBrowser,
- AltNumberBrowserTabbing) {
+IN_PROC_BROWSER_TEST_F(ShelfAppBrowserTestNoDefaultBrowser,
+ AltNumberBrowserTabbing) {
// Get the number of items in the browser menu.
EXPECT_EQ(0u, chrome::GetTotalBrowserCount());
// The first activation should create a browser at index 1 (App List @ 0).
- launcher_->ActivateLauncherItem(1);
+ shelf_->ActivateShelfItem(1);
EXPECT_EQ(1u, chrome::GetTotalBrowserCount());
// A second activation should not create a new instance.
- launcher_->ActivateLauncherItem(1);
+ shelf_->ActivateShelfItem(1);
Browser* browser1 = chrome::FindBrowserWithWindow(ash::wm::GetActiveWindow());
EXPECT_TRUE(browser1);
aura::Window* window1 = browser1->window()->GetNativeWindow();
@@ -1437,9 +1435,9 @@ IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTestNoDefaultBrowser,
EXPECT_EQ(window2, ash::wm::GetActiveWindow());
// Activate multiple times the switcher to see that the windows get activated.
- launcher_->ActivateLauncherItem(1);
+ shelf_->ActivateShelfItem(1);
EXPECT_EQ(window1, ash::wm::GetActiveWindow());
- launcher_->ActivateLauncherItem(1);
+ shelf_->ActivateShelfItem(1);
EXPECT_EQ(window2, ash::wm::GetActiveWindow());
// Create a third browser - make sure that we do not toggle simply between
@@ -1452,13 +1450,13 @@ IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTestNoDefaultBrowser,
EXPECT_NE(window2, window3);
EXPECT_EQ(window3, ash::wm::GetActiveWindow());
- launcher_->ActivateLauncherItem(1);
+ shelf_->ActivateShelfItem(1);
EXPECT_EQ(window1, ash::wm::GetActiveWindow());
- launcher_->ActivateLauncherItem(1);
+ shelf_->ActivateShelfItem(1);
EXPECT_EQ(window2, ash::wm::GetActiveWindow());
- launcher_->ActivateLauncherItem(1);
+ shelf_->ActivateShelfItem(1);
EXPECT_EQ(window3, ash::wm::GetActiveWindow());
- launcher_->ActivateLauncherItem(1);
+ shelf_->ActivateShelfItem(1);
EXPECT_EQ(window1, ash::wm::GetActiveWindow());
// Create anther app and make sure that none of our browsers is active.
@@ -1467,13 +1465,13 @@ IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTestNoDefaultBrowser,
EXPECT_NE(window2, ash::wm::GetActiveWindow());
// After activation our browser should be active again.
- launcher_->ActivateLauncherItem(1);
+ shelf_->ActivateShelfItem(1);
EXPECT_EQ(window1, ash::wm::GetActiveWindow());
}
// Checks that after a session restore, we do not start applications on an
// activation.
-IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, ActivateAfterSessionRestore) {
+IN_PROC_BROWSER_TEST_F(ShelfAppBrowserTest, ActivateAfterSessionRestore) {
EXPECT_EQ(1u, chrome::GetTotalBrowserCount());
// Create a known application.
@@ -1531,12 +1529,12 @@ IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, ActivateAfterSessionRestore) {
// Do various drag and drop interaction tests between the application list and
// the launcher.
-IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, DragAndDrop) {
+IN_PROC_BROWSER_TEST_F(ShelfAppBrowserTest, DragAndDrop) {
// Get a number of interfaces we need.
aura::test::EventGenerator generator(
ash::Shell::GetPrimaryRootWindow(), gfx::Point());
ash::test::ShelfViewTestAPI test(
- ash::test::LauncherTestAPI(launcher_).shelf_view());
+ ash::test::ShelfTestAPI(shelf_).shelf_view());
AppListService* service = AppListService::Get(chrome::GetActiveDesktop());
// There should be two items in our launcher by this time.
@@ -1576,13 +1574,12 @@ IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, DragAndDrop) {
EXPECT_FALSE(grid_view->forward_events_to_drag_and_drop_host_for_test());
- // Drag the item into the launcher and check that a new item gets created.
- const views::ViewModel* vm_launcher =
- test.shelf_view()->view_model_for_test();
- views::View* launcher1 = vm_launcher->view_at(1);
- gfx::Rect bounds_launcher_1 = launcher1->GetBoundsInScreen();
- generator.MoveMouseTo(bounds_launcher_1.CenterPoint().x(),
- bounds_launcher_1.CenterPoint().y());
+ // Drag the item into the shelf and check that a new item gets created.
+ const views::ViewModel* vm_shelf = test.shelf_view()->view_model_for_test();
+ views::View* shelf1 = vm_shelf->view_at(1);
+ gfx::Rect bounds_shelf_1 = shelf1->GetBoundsInScreen();
+ generator.MoveMouseTo(bounds_shelf_1.CenterPoint().x(),
+ bounds_shelf_1.CenterPoint().y());
base::MessageLoop::current()->RunUntilIdle();
// Check that a new item got created.
@@ -1610,8 +1607,8 @@ IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, DragAndDrop) {
generator.MoveMouseTo(bounds_grid_1.CenterPoint().x(),
bounds_grid_1.CenterPoint().y());
generator.PressLeftButton();
- generator.MoveMouseTo(bounds_launcher_1.CenterPoint().x(),
- bounds_launcher_1.CenterPoint().y());
+ generator.MoveMouseTo(bounds_shelf_1.CenterPoint().x(),
+ bounds_shelf_1.CenterPoint().y());
base::MessageLoop::current()->RunUntilIdle();
EXPECT_EQ(3, model_->item_count());
EXPECT_TRUE(grid_view->forward_events_to_drag_and_drop_host_for_test());
@@ -1626,8 +1623,8 @@ IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, DragAndDrop) {
generator.MoveMouseTo(bounds_grid_1.CenterPoint().x(),
bounds_grid_1.CenterPoint().y());
generator.PressLeftButton();
- generator.MoveMouseTo(bounds_launcher_1.CenterPoint().x(),
- bounds_launcher_1.CenterPoint().y());
+ generator.MoveMouseTo(bounds_shelf_1.CenterPoint().x(),
+ bounds_shelf_1.CenterPoint().y());
base::MessageLoop::current()->RunUntilIdle();
EXPECT_EQ(3, model_->item_count()); // No new item got added.
EXPECT_TRUE(grid_view->forward_events_to_drag_and_drop_host_for_test());
@@ -1640,8 +1637,8 @@ IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, DragAndDrop) {
generator.MoveMouseTo(bounds_grid_1.CenterPoint().x(),
bounds_grid_1.CenterPoint().y());
generator.PressLeftButton();
- generator.MoveMouseTo(bounds_launcher_1.CenterPoint().x(),
- bounds_launcher_1.CenterPoint().y());
+ generator.MoveMouseTo(bounds_shelf_1.CenterPoint().x(),
+ bounds_shelf_1.CenterPoint().y());
base::MessageLoop::current()->RunUntilIdle();
// Issue an ESC and see that the operation gets cancelled.
generator.PressKey(ui::VKEY_ESCAPE, 0);
@@ -1654,39 +1651,38 @@ IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, DragAndDrop) {
#if !defined(OS_WIN)
// Used to test drag & drop an item between app list and shelf with multi
// display environment.
-class LauncherAppBrowserTestWithMultiMonitor
- : public LauncherAppBrowserTestNoDefaultBrowser {
+class ShelfAppBrowserTestWithMultiMonitor
+ : public ShelfAppBrowserTestNoDefaultBrowser {
protected:
- LauncherAppBrowserTestWithMultiMonitor() {}
- virtual ~LauncherAppBrowserTestWithMultiMonitor() {}
+ ShelfAppBrowserTestWithMultiMonitor() {}
+ virtual ~ShelfAppBrowserTestWithMultiMonitor() {}
virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {
- LauncherAppBrowserTestNoDefaultBrowser::SetUpCommandLine(command_line);
+ ShelfAppBrowserTestNoDefaultBrowser::SetUpCommandLine(command_line);
command_line->AppendSwitchASCII("ash-host-window-bounds",
"800x600,801+0-800x600");
}
private:
- DISALLOW_COPY_AND_ASSIGN(LauncherAppBrowserTestWithMultiMonitor);
+ DISALLOW_COPY_AND_ASSIGN(ShelfAppBrowserTestWithMultiMonitor);
};
// Do basic drag and drop interaction tests between the application list and
// the launcher in the secondary monitor.
-IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTestWithMultiMonitor,
+IN_PROC_BROWSER_TEST_F(ShelfAppBrowserTestWithMultiMonitor,
BasicDragAndDrop) {
// Get a number of interfaces we need.
DCHECK_EQ(ash::Shell::GetAllRootWindows().size(), 2U);
aura::Window* secondary_root_window = ash::Shell::GetAllRootWindows()[1];
- ash::Launcher* secondary_launcher =
- ash::Launcher::ForWindow(secondary_root_window);
+ ash::Shelf* secondary_shelf = ash::Shelf::ForWindow(secondary_root_window);
aura::test::EventGenerator generator(secondary_root_window, gfx::Point());
ash::test::ShelfViewTestAPI test(
- ash::test::LauncherTestAPI(secondary_launcher).shelf_view());
+ ash::test::ShelfTestAPI(secondary_shelf).shelf_view());
AppListService* service = AppListService::Get(chrome::GetActiveDesktop());
- // There should be two items in our launcher by this time.
+ // There should be two items in our shelf by this time.
EXPECT_EQ(2, model_->item_count());
EXPECT_FALSE(service->IsAppListVisible());
@@ -1714,7 +1710,7 @@ IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTestWithMultiMonitor,
const views::ViewModel* vm_grid = grid_view->view_model_for_test();
EXPECT_EQ(2, vm_grid->view_size());
- // Drag an app list item which does not exist yet in the launcher.
+ // Drag an app list item which does not exist yet in the shelf.
// Keeping it dragged, see that a new item gets created.
// Continuing to drag it out should remove it again.
@@ -1729,14 +1725,13 @@ IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTestWithMultiMonitor,
EXPECT_FALSE(grid_view->forward_events_to_drag_and_drop_host_for_test());
- // Drag the item into the launcher and check that a new item gets created.
- const views::ViewModel* vm_launcher =
- test.shelf_view()->view_model_for_test();
- views::View* launcher1 = vm_launcher->view_at(1);
- gfx::Rect bounds_launcher_1 = launcher1->GetBoundsInScreen();
- bounds_launcher_1.Offset(-origin.x(), -origin.y());
- generator.MoveMouseTo(bounds_launcher_1.CenterPoint().x(),
- bounds_launcher_1.CenterPoint().y());
+ // Drag the item into the shelf and check that a new item gets created.
+ const views::ViewModel* vm_shelf = test.shelf_view()->view_model_for_test();
+ views::View* shelf1 = vm_shelf->view_at(1);
+ gfx::Rect bounds_shelf_1 = shelf1->GetBoundsInScreen();
+ bounds_shelf_1.Offset(-origin.x(), -origin.y());
+ generator.MoveMouseTo(bounds_shelf_1.CenterPoint().x(),
+ bounds_shelf_1.CenterPoint().y());
base::MessageLoop::current()->RunUntilIdle();
// Check that a new item got created.
@@ -1750,7 +1745,7 @@ IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTestWithMultiMonitor,
EXPECT_EQ(2, model_->item_count());
EXPECT_FALSE(grid_view->forward_events_to_drag_and_drop_host_for_test());
- // Dropping it should keep the launcher as it originally was.
+ // Dropping it should keep the shelf as it originally was.
generator.ReleaseLeftButton();
base::MessageLoop::current()->RunUntilIdle();
EXPECT_EQ(2, model_->item_count());
@@ -1758,13 +1753,13 @@ IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTestWithMultiMonitor,
#endif
// Do tests for removal of items from the shelf by dragging.
-IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, DragOffShelf) {
+IN_PROC_BROWSER_TEST_F(ShelfAppBrowserTest, DragOffShelf) {
aura::test::EventGenerator generator(
ash::Shell::GetPrimaryRootWindow(), gfx::Point());
ash::test::ShelfViewTestAPI test(
- ash::test::LauncherTestAPI(launcher_).shelf_view());
+ ash::test::ShelfTestAPI(shelf_).shelf_view());
test.SetAnimationDuration(1); // Speed up animations for test.
- // Create a known application and check that we have 3 items in the launcher.
+ // Create a known application and check that we have 3 items in the shelf.
CreateShortcut("app1");
test.RunMessageLoopUntilAnimationsDone();
EXPECT_EQ(3, model_->item_count());
@@ -1845,7 +1840,7 @@ IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, DragOffShelf) {
int total_count = model_->item_count();
app_index = GetIndexOfShelfItemType(ash::TYPE_APP_SHORTCUT);
RipOffItemIndex(app_index, &generator, &test, RIP_OFF_ITEM);
- // When an item is ripped off from the launcher that has overflow button
+ // When an item is ripped off from the shelf that has overflow button
// (see crbug.com/3050787), it was hidden accidentally and was then
// suppressing any further events. If handled correctly the operation will
// however correctly done and the item will get removed (as well as the
@@ -1859,15 +1854,15 @@ IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, DragOffShelf) {
EXPECT_FALSE(test.IsOverflowButtonVisible());
}
-// Check that clicking on an app launcher item launches a new browser.
-IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, ClickItem) {
+// Check that clicking on an app shelf item launches a new browser.
+IN_PROC_BROWSER_TEST_F(ShelfAppBrowserTest, ClickItem) {
// Get a number of interfaces we need.
aura::test::EventGenerator generator(
ash::Shell::GetPrimaryRootWindow(), gfx::Point());
ash::test::ShelfViewTestAPI test(
- ash::test::LauncherTestAPI(launcher_).shelf_view());
+ ash::test::ShelfTestAPI(shelf_).shelf_view());
AppListService* service = AppListService::Get(chrome::GetActiveDesktop());
- // There should be two items in our launcher by this time.
+ // There should be two items in our shelf by this time.
EXPECT_EQ(2, model_->item_count());
EXPECT_FALSE(service->IsAppListVisible());
@@ -1898,8 +1893,8 @@ IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, ClickItem) {
}
// Check LauncherItemController of Browser Shortcut functionality.
-IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTestNoDefaultBrowser,
- BrowserShortcutLauncherItemController) {
+IN_PROC_BROWSER_TEST_F(ShelfAppBrowserTestNoDefaultBrowser,
+ BrowserShortcutLauncherItemController) {
LauncherItemController* item_controller =
controller_->GetBrowserShortcutLauncherItemController();
@@ -1930,7 +1925,7 @@ IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTestNoDefaultBrowser,
}
// Check that GetLauncherIDForWindow() returns |LauncherID| of the active tab.
-IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, MatchingLauncherIDandActiveTab) {
+IN_PROC_BROWSER_TEST_F(ShelfAppBrowserTest, MatchingLauncherIDandActiveTab) {
EXPECT_EQ(1u, chrome::GetTotalBrowserCount());
EXPECT_EQ(1, browser()->tab_strip_model()->count());
EXPECT_EQ(0, browser()->tab_strip_model()->active_index());
@@ -1947,7 +1942,7 @@ IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, MatchingLauncherIDandActiveTab) {
// Creates a new tab for "app1" and checks that GetLauncherIDForWindow()
// returns |LauncherID| of "app1".
- ActivateLauncherItem(model_->ItemIndexByID(app_id));
+ ActivateShelfItem(model_->ItemIndexByID(app_id));
EXPECT_EQ(2, browser()->tab_strip_model()->count());
EXPECT_EQ(1, browser()->tab_strip_model()->active_index());
EXPECT_EQ(app_id, ash::GetLauncherIDForWindow(window));
@@ -1959,15 +1954,15 @@ IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, MatchingLauncherIDandActiveTab) {
EXPECT_EQ(browser_id, ash::GetLauncherIDForWindow(window));
}
-IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, OverflowBubble) {
+IN_PROC_BROWSER_TEST_F(ShelfAppBrowserTest, OverflowBubble) {
// Make sure to have a browser window
chrome::NewTab(browser());
// No overflow yet.
- EXPECT_FALSE(launcher_->IsShowingOverflowBubble());
+ EXPECT_FALSE(shelf_->IsShowingOverflowBubble());
ash::test::ShelfViewTestAPI test(
- ash::test::LauncherTestAPI(launcher_).shelf_view());
+ ash::test::ShelfTestAPI(shelf_).shelf_view());
int items_added = 0;
while (!test.IsOverflowButtonVisible()) {
@@ -1980,18 +1975,18 @@ IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, OverflowBubble) {
// Now show overflow bubble.
test.ShowOverflowBubble();
- EXPECT_TRUE(launcher_->IsShowingOverflowBubble());
+ EXPECT_TRUE(shelf_->IsShowingOverflowBubble());
// Unpin first pinned app and there should be no crash.
controller_->UnpinAppWithID(std::string("fake_app_0"));
test.RunMessageLoopUntilAnimationsDone();
- EXPECT_FALSE(launcher_->IsShowingOverflowBubble());
+ EXPECT_FALSE(shelf_->IsShowingOverflowBubble());
}
// Check that a windowed V1 application can navigate away from its domain, but
// still gets detected properly.
-IN_PROC_BROWSER_TEST_F(LauncherAppBrowserTest, V1AppNavigation) {
+IN_PROC_BROWSER_TEST_F(ShelfAppBrowserTest, V1AppNavigation) {
// We assume that the web store is always there (which it apparently is).
controller_->PinAppWithID(extension_misc::kWebStoreAppId);
ash::LauncherID id = controller_->GetLauncherIDForAppID(

Powered by Google App Engine
This is Rietveld 408576698