Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1150323002: Move work to omit unnecessary ObjectLiteral stores to the numbering pass. (Closed)

Created:
5 years, 7 months ago by mvstanton
Modified:
5 years, 7 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move work to omit unnecessary ObjectLiteral stores to the numbering pass. The reason is that this information will be needed to compute the number of vector ic slots done at numbering time. BUG= Committed: https://crrev.com/32de677805877bbf8d697926e09c23963a27e191 Cr-Commit-Position: refs/heads/master@{#28615}

Patch Set 1 #

Patch Set 2 : REBASE. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -37 lines) Patch
M src/arm/full-codegen-arm.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M src/ast-numbering.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mvstanton
Hi Jakob, here is something I'll need in order to calculate the required number of ...
5 years, 7 months ago (2015-05-22 14:57:21 UTC) #2
Jakob Kummerow
Very LGTM!
5 years, 7 months ago (2015-05-26 08:11:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1150323002/20001
5 years, 7 months ago (2015-05-26 08:22:33 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-26 09:05:59 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-26 09:06:14 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/32de677805877bbf8d697926e09c23963a27e191
Cr-Commit-Position: refs/heads/master@{#28615}

Powered by Google App Engine
This is Rietveld 408576698