Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Unified Diff: src/compiler/ast-graph-builder.cc

Issue 1150323002: Move work to omit unnecessary ObjectLiteral stores to the numbering pass. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: REBASE. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ast-numbering.cc ('k') | src/hydrogen.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/ast-graph-builder.cc
diff --git a/src/compiler/ast-graph-builder.cc b/src/compiler/ast-graph-builder.cc
index d3506e7550c7a036c0f23cb1643882c6a293cd1b..9e9834ab71d526eb7769fe16b6a6511a7bfa2fd7 100644
--- a/src/compiler/ast-graph-builder.cc
+++ b/src/compiler/ast-graph-builder.cc
@@ -1786,11 +1786,6 @@ void AstGraphBuilder::VisitObjectLiteral(ObjectLiteral* expr) {
// property values and is the value of the entire expression.
environment()->Push(literal);
- // Mark all computed expressions that are bound to a key that is shadowed by
- // a later occurrence of the same key. For the marked expressions, no store
- // code is emitted.
- expr->CalculateEmitStore(zone());
-
// Create nodes to store computed values into the literal.
int property_index = 0;
AccessorTable accessor_table(zone());
« no previous file with comments | « src/ast-numbering.cc ('k') | src/hydrogen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698