Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/arm64/full-codegen-arm64.cc

Issue 1150323002: Move work to omit unnecessary ObjectLiteral stores to the numbering pass. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: REBASE. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/ast-numbering.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM64 7 #if V8_TARGET_ARCH_ARM64
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1634 matching lines...) Expand 10 before | Expand all | Expand 10 after
1645 } else { 1645 } else {
1646 FastCloneShallowObjectStub stub(isolate(), expr->properties_count()); 1646 FastCloneShallowObjectStub stub(isolate(), expr->properties_count());
1647 __ CallStub(&stub); 1647 __ CallStub(&stub);
1648 } 1648 }
1649 PrepareForBailoutForId(expr->CreateLiteralId(), TOS_REG); 1649 PrepareForBailoutForId(expr->CreateLiteralId(), TOS_REG);
1650 1650
1651 // If result_saved is true the result is on top of the stack. If 1651 // If result_saved is true the result is on top of the stack. If
1652 // result_saved is false the result is in x0. 1652 // result_saved is false the result is in x0.
1653 bool result_saved = false; 1653 bool result_saved = false;
1654 1654
1655 // Mark all computed expressions that are bound to a key that
1656 // is shadowed by a later occurrence of the same key. For the
1657 // marked expressions, no store code is emitted.
1658 expr->CalculateEmitStore(zone());
1659
1660 AccessorTable accessor_table(zone()); 1655 AccessorTable accessor_table(zone());
1661 int property_index = 0; 1656 int property_index = 0;
1662 for (; property_index < expr->properties()->length(); property_index++) { 1657 for (; property_index < expr->properties()->length(); property_index++) {
1663 ObjectLiteral::Property* property = expr->properties()->at(property_index); 1658 ObjectLiteral::Property* property = expr->properties()->at(property_index);
1664 if (property->is_computed_name()) break; 1659 if (property->is_computed_name()) break;
1665 if (property->IsCompileTimeValue()) continue; 1660 if (property->IsCompileTimeValue()) continue;
1666 1661
1667 Literal* key = property->key()->AsLiteral(); 1662 Literal* key = property->key()->AsLiteral();
1668 Expression* value = property->value(); 1663 Expression* value = property->value();
1669 if (!result_saved) { 1664 if (!result_saved) {
(...skipping 3823 matching lines...) Expand 10 before | Expand all | Expand 10 after
5493 } 5488 }
5494 } 5489 }
5495 5490
5496 return INTERRUPT; 5491 return INTERRUPT;
5497 } 5492 }
5498 5493
5499 5494
5500 } } // namespace v8::internal 5495 } } // namespace v8::internal
5501 5496
5502 #endif // V8_TARGET_ARCH_ARM64 5497 #endif // V8_TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/ast-numbering.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698