Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1105)

Side by Side Diff: src/arm/full-codegen-arm.cc

Issue 1150323002: Move work to omit unnecessary ObjectLiteral stores to the numbering pass. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: REBASE. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM 7 #if V8_TARGET_ARCH_ARM
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1658 matching lines...) Expand 10 before | Expand all | Expand 10 after
1669 } else { 1669 } else {
1670 FastCloneShallowObjectStub stub(isolate(), expr->properties_count()); 1670 FastCloneShallowObjectStub stub(isolate(), expr->properties_count());
1671 __ CallStub(&stub); 1671 __ CallStub(&stub);
1672 } 1672 }
1673 PrepareForBailoutForId(expr->CreateLiteralId(), TOS_REG); 1673 PrepareForBailoutForId(expr->CreateLiteralId(), TOS_REG);
1674 1674
1675 // If result_saved is true the result is on top of the stack. If 1675 // If result_saved is true the result is on top of the stack. If
1676 // result_saved is false the result is in r0. 1676 // result_saved is false the result is in r0.
1677 bool result_saved = false; 1677 bool result_saved = false;
1678 1678
1679 // Mark all computed expressions that are bound to a key that
1680 // is shadowed by a later occurrence of the same key. For the
1681 // marked expressions, no store code is emitted.
1682 expr->CalculateEmitStore(zone());
1683
1684 AccessorTable accessor_table(zone()); 1679 AccessorTable accessor_table(zone());
1685 int property_index = 0; 1680 int property_index = 0;
1686 for (; property_index < expr->properties()->length(); property_index++) { 1681 for (; property_index < expr->properties()->length(); property_index++) {
1687 ObjectLiteral::Property* property = expr->properties()->at(property_index); 1682 ObjectLiteral::Property* property = expr->properties()->at(property_index);
1688 if (property->is_computed_name()) break; 1683 if (property->is_computed_name()) break;
1689 if (property->IsCompileTimeValue()) continue; 1684 if (property->IsCompileTimeValue()) continue;
1690 1685
1691 Literal* key = property->key()->AsLiteral(); 1686 Literal* key = property->key()->AsLiteral();
1692 Expression* value = property->value(); 1687 Expression* value = property->value();
1693 if (!result_saved) { 1688 if (!result_saved) {
(...skipping 3830 matching lines...) Expand 10 before | Expand all | Expand 10 after
5524 5519
5525 DCHECK(interrupt_address == 5520 DCHECK(interrupt_address ==
5526 isolate->builtins()->OsrAfterStackCheck()->entry()); 5521 isolate->builtins()->OsrAfterStackCheck()->entry());
5527 return OSR_AFTER_STACK_CHECK; 5522 return OSR_AFTER_STACK_CHECK;
5528 } 5523 }
5529 5524
5530 5525
5531 } } // namespace v8::internal 5526 } } // namespace v8::internal
5532 5527
5533 #endif // V8_TARGET_ARCH_ARM 5528 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698