Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Side by Side Diff: src/mips/full-codegen-mips.cc

Issue 1150323002: Move work to omit unnecessary ObjectLiteral stores to the numbering pass. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: REBASE. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ia32/full-codegen-ia32.cc ('k') | src/mips64/full-codegen-mips64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_MIPS 7 #if V8_TARGET_ARCH_MIPS
8 8
9 // Note on Mips implementation: 9 // Note on Mips implementation:
10 // 10 //
(...skipping 1643 matching lines...) Expand 10 before | Expand all | Expand 10 after
1654 } else { 1654 } else {
1655 FastCloneShallowObjectStub stub(isolate(), expr->properties_count()); 1655 FastCloneShallowObjectStub stub(isolate(), expr->properties_count());
1656 __ CallStub(&stub); 1656 __ CallStub(&stub);
1657 } 1657 }
1658 PrepareForBailoutForId(expr->CreateLiteralId(), TOS_REG); 1658 PrepareForBailoutForId(expr->CreateLiteralId(), TOS_REG);
1659 1659
1660 // If result_saved is true the result is on top of the stack. If 1660 // If result_saved is true the result is on top of the stack. If
1661 // result_saved is false the result is in v0. 1661 // result_saved is false the result is in v0.
1662 bool result_saved = false; 1662 bool result_saved = false;
1663 1663
1664 // Mark all computed expressions that are bound to a key that
1665 // is shadowed by a later occurrence of the same key. For the
1666 // marked expressions, no store code is emitted.
1667 expr->CalculateEmitStore(zone());
1668
1669 AccessorTable accessor_table(zone()); 1664 AccessorTable accessor_table(zone());
1670 int property_index = 0; 1665 int property_index = 0;
1671 for (; property_index < expr->properties()->length(); property_index++) { 1666 for (; property_index < expr->properties()->length(); property_index++) {
1672 ObjectLiteral::Property* property = expr->properties()->at(property_index); 1667 ObjectLiteral::Property* property = expr->properties()->at(property_index);
1673 if (property->is_computed_name()) break; 1668 if (property->is_computed_name()) break;
1674 if (property->IsCompileTimeValue()) continue; 1669 if (property->IsCompileTimeValue()) continue;
1675 1670
1676 Literal* key = property->key()->AsLiteral(); 1671 Literal* key = property->key()->AsLiteral();
1677 Expression* value = property->value(); 1672 Expression* value = property->value();
1678 if (!result_saved) { 1673 if (!result_saved) {
(...skipping 3785 matching lines...) Expand 10 before | Expand all | Expand 10 after
5464 Assembler::target_address_at(pc_immediate_load_address)) == 5459 Assembler::target_address_at(pc_immediate_load_address)) ==
5465 reinterpret_cast<uint32_t>( 5460 reinterpret_cast<uint32_t>(
5466 isolate->builtins()->OsrAfterStackCheck()->entry())); 5461 isolate->builtins()->OsrAfterStackCheck()->entry()));
5467 return OSR_AFTER_STACK_CHECK; 5462 return OSR_AFTER_STACK_CHECK;
5468 } 5463 }
5469 5464
5470 5465
5471 } } // namespace v8::internal 5466 } } // namespace v8::internal
5472 5467
5473 #endif // V8_TARGET_ARCH_MIPS 5468 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/ia32/full-codegen-ia32.cc ('k') | src/mips64/full-codegen-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698