Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 11491003: Revert 171714 - Use an auxiliary list of animation controllers. (Closed)

Created:
8 years ago by Ian Vollick
Modified:
8 years ago
Reviewers:
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

Revert 171714 - Use an auxiliary list of animation controllers. > With this patch we accomplish the following: > 1. layer animation controllers are ref counted (so they can be shared by the two impl trees) > 2. the layer tree hosts now own a list of active animation controllers. This allows for a couple of nice things > __a. Ticking the animation controllers no longer requires a tree walk > __b. We will be able to support ticking of animation controllers for layers that are not yet added to the layer tree. (Support coming in a future patch). > 3. animation controllers register and unregister themselves from their respective layer tree host's list when they have an animation to tick. > > BUG=162111 > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171714 TBR=vollick@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171981

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+434 lines, -414 lines) Patch
D cc/animation_registrar.h View 1 chunk +0 lines, -35 lines 0 comments Download
M cc/cc.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M cc/layer.h View 1 7 chunks +15 lines, -7 lines 0 comments Download
M cc/layer.cc View 1 11 chunks +49 lines, -25 lines 0 comments Download
M cc/layer_animation_controller.h View 4 chunks +18 lines, -36 lines 0 comments Download
M cc/layer_animation_controller.cc View 13 chunks +17 lines, -70 lines 0 comments Download
M cc/layer_animation_controller_unittest.cc View 23 chunks +113 lines, -78 lines 0 comments Download
M cc/layer_impl.h View 6 chunks +10 lines, -5 lines 0 comments Download
M cc/layer_impl.cc View 5 chunks +28 lines, -15 lines 0 comments Download
M cc/layer_tree_host.h View 7 chunks +3 lines, -25 lines 0 comments Download
M cc/layer_tree_host.cc View 7 chunks +33 lines, -34 lines 0 comments Download
M cc/layer_tree_host_common_unittest.cc View 2 chunks +13 lines, -13 lines 0 comments Download
M cc/layer_tree_host_impl.h View 6 chunks +4 lines, -17 lines 0 comments Download
M cc/layer_tree_host_impl.cc View 7 chunks +40 lines, -39 lines 0 comments Download
M cc/proxy.h View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/single_thread_proxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/single_thread_proxy.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/test/animation_test_common.h View 1 chunk +17 lines, -0 lines 0 comments Download
M cc/test/animation_test_common.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M cc/test/fake_proxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/test/layer_tree_test_common.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/test/layer_tree_test_common.cc View 4 chunks +22 lines, -6 lines 0 comments Download
M cc/thread_proxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/tree_synchronizer_unittest.cc View 2 chunks +8 lines, -8 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698