Issue 114883004: Add base:: namespace to straggling string16s left in chrome/browser/ui.

Issue 114883004: Add base:: namespace to straggling string16s left in chrome/browser/ui. (Closed)

Created:
7 years ago by Dan Beam

Modified:
7 years ago

Reviewers:
msw

CC:
chromium-reviews, davidben+watch_chromium.org, cbentzel+watch_chromium.org, skanuj+watch_chromium.org, melevin+watch_chromium.org, tburkard+watch_chromium.org, tfarina, dougw+watch_chromium.org, donnd+watch_chromium.org, dominich, gavinp+prer_chromium.org, dominich+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, dhollowa+watch_chromium.org, kmadhusu+watch_chromium.org, Jered

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add base:: namespace to straggling string16s left in chrome/browser/ui. R=msw@chromium.org BUG=none TEST=compile Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241220

Patch Set 1 : nit #

Patch Set 2 : found more #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -58 lines)			Patch
M	chrome/browser/ui/browser.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/browser.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_all_tabs_controller_unittest.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_editor_base_controller_unittest.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/bookmarks/bookmark_editor_controller_unittest.mm	View	1	6 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/one_click_signin_bubble_controller.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/website_settings_bubble_controller.mm	View		5 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/search/instant_search_prerenderer.h	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/search/instant_search_prerenderer.cc	View		2 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/search/instant_search_prerenderer_unittest.cc	View	1	4 chunks	+6 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/search/search_tab_helper_unittest.cc	View	1	3 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/views/extensions/extension_message_bubble_view.cc	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/views/infobars/after_translate_infobar.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/toolbar/site_chip_view.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/toolbar/site_chip_view.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/history_ui.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/performance_monitor/performance_monitor_l10n.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/signin/user_manager_screen_handler.cc	View	1	4 chunks	+9 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/114883004/40001

7 years ago (2013-12-17 04:28:52 UTC) #3

Message was sent while issue was closed.

Change committed as 241220

Expand Messages | Collapse Messages