chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm - Issue 114883004: Add base:: namespace to straggling string16s left in chrome/browser/ui.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm

Issue 114883004: Add base:: namespace to straggling string16s left in chrome/browser/ui. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: found more Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_editor_controller_unittest.mm ('k') | chrome/browser/ui/cocoa/one_click_signin_bubble_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm

diff --git a/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm b/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm

index 4303a61a17886dea608dd20ee96a4f8b81af9013..f6662f159f4d43d11857f80a38f42570c043b83d 100644

--- a/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm

+++ b/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm

@@ -212,7 +212,7 @@ const float kRightEdgeOffset = 25;

// The textbox is empty so we reset.

findTabHelper->StopFinding(FindBarController::kClearSelectionOnPage);

[self updateUIForFindResult:findTabHelper->find_result()

- withText:string16()];

+ withText:base::string16()];

}

@@ -383,7 +383,7 @@ const float kRightEdgeOffset = 25;

- (void)clearResults:(const FindNotificationDetails&)results {

// Just call updateUIForFindResult, which will take care of clearing

// the search text and the results label.

- [self updateUIForFindResult:results withText:string16()];

+ [self updateUIForFindResult:results withText:base::string16()];

}

- (void)updateUIForFindResult:(const FindNotificationDetails&)result