Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Side by Side Diff: chrome/browser/ui/search/instant_search_prerenderer_unittest.cc

Issue 114883004: Add base:: namespace to straggling string16s left in chrome/browser/ui. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: found more Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/search/instant_search_prerenderer.h" 5 #include "chrome/browser/ui/search/instant_search_prerenderer.h"
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "base/metrics/field_trial.h" 10 #include "base/metrics/field_trial.h"
(...skipping 175 matching lines...) Expand 10 before | Expand all | Expand 10 after
186 } 186 }
187 187
188 InstantSearchPrerenderer* GetInstantSearchPrerenderer() { 188 InstantSearchPrerenderer* GetInstantSearchPrerenderer() {
189 return instant_service_->instant_search_prerenderer(); 189 return instant_service_->instant_search_prerenderer();
190 } 190 }
191 191
192 const GURL& GetPrerenderURL() { 192 const GURL& GetPrerenderURL() {
193 return GetInstantSearchPrerenderer()->prerender_url_; 193 return GetInstantSearchPrerenderer()->prerender_url_;
194 } 194 }
195 195
196 void SetLastQuery(const string16& query) { 196 void SetLastQuery(const base::string16& query) {
197 GetInstantSearchPrerenderer()->last_instant_suggestion_ = 197 GetInstantSearchPrerenderer()->last_instant_suggestion_ =
198 InstantSuggestion(query, std::string()); 198 InstantSuggestion(query, std::string());
199 } 199 }
200 200
201 content::WebContents* prerender_contents() { 201 content::WebContents* prerender_contents() {
202 return GetInstantSearchPrerenderer()->prerender_contents(); 202 return GetInstantSearchPrerenderer()->prerender_contents();
203 } 203 }
204 204
205 bool MessageWasSent(uint32 id) { 205 bool MessageWasSent(uint32 id) {
206 content::MockRenderProcessHost* process = 206 content::MockRenderProcessHost* process =
207 static_cast<content::MockRenderProcessHost*>( 207 static_cast<content::MockRenderProcessHost*>(
208 prerender_contents()->GetRenderViewHost()->GetProcess()); 208 prerender_contents()->GetRenderViewHost()->GetProcess());
209 return process->sink().GetFirstMessageMatching(id) != NULL; 209 return process->sink().GetFirstMessageMatching(id) != NULL;
210 } 210 }
211 211
212 content::WebContents* GetActiveWebContents() const { 212 content::WebContents* GetActiveWebContents() const {
213 return browser()->tab_strip_model()->GetWebContentsAt(0); 213 return browser()->tab_strip_model()->GetWebContentsAt(0);
214 } 214 }
215 215
216 PrerenderHandle* prerender_handle() { 216 PrerenderHandle* prerender_handle() {
217 return GetInstantSearchPrerenderer()->prerender_handle_.get(); 217 return GetInstantSearchPrerenderer()->prerender_handle_.get();
218 } 218 }
219 219
220 void PrerenderSearchQuery(const string16& query) { 220 void PrerenderSearchQuery(const base::string16& query) {
221 Init(true, true); 221 Init(true, true);
222 InstantSearchPrerenderer* prerenderer = GetInstantSearchPrerenderer(); 222 InstantSearchPrerenderer* prerenderer = GetInstantSearchPrerenderer();
223 prerenderer->Prerender(InstantSuggestion(query, std::string())); 223 prerenderer->Prerender(InstantSuggestion(query, std::string()));
224 CommitPendingLoad(&prerender_contents()->GetController()); 224 CommitPendingLoad(&prerender_contents()->GetController());
225 EXPECT_TRUE(prerenderer->CanCommitQuery(GetActiveWebContents(), query)); 225 EXPECT_TRUE(prerenderer->CanCommitQuery(GetActiveWebContents(), query));
226 EXPECT_NE(static_cast<PrerenderHandle*>(NULL), prerender_handle()); 226 EXPECT_NE(static_cast<PrerenderHandle*>(NULL), prerender_handle());
227 } 227 }
228 }; 228 };
229 229
230 TEST_F(InstantSearchPrerendererTest, GetSearchTermsFromPrerenderedPage) { 230 TEST_F(InstantSearchPrerendererTest, GetSearchTermsFromPrerenderedPage) {
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
263 prerenderer->Prerender( 263 prerenderer->Prerender(
264 InstantSuggestion(ASCIIToUTF16("flowers"), std::string())); 264 InstantSuggestion(ASCIIToUTF16("flowers"), std::string()));
265 EXPECT_EQ("", UTF16ToASCII(prerenderer->get_last_query())); 265 EXPECT_EQ("", UTF16ToASCII(prerenderer->get_last_query()));
266 EXPECT_FALSE(MessageWasSent( 266 EXPECT_FALSE(MessageWasSent(
267 ChromeViewMsg_SearchBoxSetSuggestionToPrefetch::ID)); 267 ChromeViewMsg_SearchBoxSetSuggestionToPrefetch::ID));
268 } 268 }
269 269
270 TEST_F(InstantSearchPrerendererTest, CanCommitQuery) { 270 TEST_F(InstantSearchPrerendererTest, CanCommitQuery) {
271 Init(true, true); 271 Init(true, true);
272 InstantSearchPrerenderer* prerenderer = GetInstantSearchPrerenderer(); 272 InstantSearchPrerenderer* prerenderer = GetInstantSearchPrerenderer();
273 string16 query = ASCIIToUTF16("flowers"); 273 base::string16 query = ASCIIToUTF16("flowers");
274 prerenderer->Prerender(InstantSuggestion(query, std::string())); 274 prerenderer->Prerender(InstantSuggestion(query, std::string()));
275 EXPECT_TRUE(prerenderer->CanCommitQuery(GetActiveWebContents(), query)); 275 EXPECT_TRUE(prerenderer->CanCommitQuery(GetActiveWebContents(), query));
276 276
277 // Make sure InstantSearchPrerenderer::CanCommitQuery() returns false for 277 // Make sure InstantSearchPrerenderer::CanCommitQuery() returns false for
278 // invalid search queries. 278 // invalid search queries.
279 EXPECT_FALSE(prerenderer->CanCommitQuery(GetActiveWebContents(), 279 EXPECT_FALSE(prerenderer->CanCommitQuery(GetActiveWebContents(),
280 ASCIIToUTF16("joy"))); 280 ASCIIToUTF16("joy")));
281 EXPECT_FALSE(prerenderer->CanCommitQuery(GetActiveWebContents(), string16())); 281 EXPECT_FALSE(prerenderer->CanCommitQuery(GetActiveWebContents(),
282 base::string16()));
282 } 283 }
283 284
284 TEST_F(InstantSearchPrerendererTest, CommitQuery) { 285 TEST_F(InstantSearchPrerendererTest, CommitQuery) {
285 string16 query = ASCIIToUTF16("flowers"); 286 base::string16 query = ASCIIToUTF16("flowers");
286 PrerenderSearchQuery(query); 287 PrerenderSearchQuery(query);
287 InstantSearchPrerenderer* prerenderer = GetInstantSearchPrerenderer(); 288 InstantSearchPrerenderer* prerenderer = GetInstantSearchPrerenderer();
288 prerenderer->Commit(query); 289 prerenderer->Commit(query);
289 EXPECT_TRUE(MessageWasSent(ChromeViewMsg_SearchBoxSubmit::ID)); 290 EXPECT_TRUE(MessageWasSent(ChromeViewMsg_SearchBoxSubmit::ID));
290 } 291 }
291 292
292 TEST_F(InstantSearchPrerendererTest, CancelPrerenderRequestOnTabChangeEvent) { 293 TEST_F(InstantSearchPrerendererTest, CancelPrerenderRequestOnTabChangeEvent) {
293 Init(true, true); 294 Init(true, true);
294 EXPECT_NE(static_cast<PrerenderHandle*>(NULL), prerender_handle()); 295 EXPECT_NE(static_cast<PrerenderHandle*>(NULL), prerender_handle());
295 296
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
392 // Open a search results page. Make sure the InstantSearchPrerenderer cancels 393 // Open a search results page. Make sure the InstantSearchPrerenderer cancels
393 // the active prerender request upon the receipt of empty search query. 394 // the active prerender request upon the receipt of empty search query.
394 GURL url("https://www.google.com/alt#quux=&strk"); 395 GURL url("https://www.google.com/alt#quux=&strk");
395 browser()->OpenURL(content::OpenURLParams(url, Referrer(), CURRENT_TAB, 396 browser()->OpenURL(content::OpenURLParams(url, Referrer(), CURRENT_TAB,
396 content::PAGE_TRANSITION_TYPED, 397 content::PAGE_TRANSITION_TYPED,
397 false)); 398 false));
398 EXPECT_NE(GetPrerenderURL(), GetActiveWebContents()->GetURL()); 399 EXPECT_NE(GetPrerenderURL(), GetActiveWebContents()->GetURL());
399 EXPECT_EQ(url, GetActiveWebContents()->GetURL()); 400 EXPECT_EQ(url, GetActiveWebContents()->GetURL());
400 EXPECT_EQ(static_cast<PrerenderHandle*>(NULL), prerender_handle()); 401 EXPECT_EQ(static_cast<PrerenderHandle*>(NULL), prerender_handle());
401 } 402 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/search/instant_search_prerenderer.cc ('k') | chrome/browser/ui/search/search_tab_helper_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698