Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: chrome/browser/ui/cocoa/one_click_signin_bubble_controller.mm

Issue 114883004: Add base:: namespace to straggling string16s left in chrome/browser/ui. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: found more Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "chrome/browser/ui/cocoa/one_click_signin_bubble_controller.h" 5 #import "chrome/browser/ui/cocoa/one_click_signin_bubble_controller.h"
6 6
7 #include "base/strings/sys_string_conversions.h" 7 #include "base/strings/sys_string_conversions.h"
8 #import "chrome/browser/ui/cocoa/browser_window_controller.h" 8 #import "chrome/browser/ui/cocoa/browser_window_controller.h"
9 #import "chrome/browser/ui/cocoa/info_bubble_window.h" 9 #import "chrome/browser/ui/cocoa/info_bubble_window.h"
10 #import "chrome/browser/ui/cocoa/one_click_signin_view_controller.h" 10 #import "chrome/browser/ui/cocoa/one_click_signin_view_controller.h"
(...skipping 13 matching lines...) Expand all
24 webContents:(content::WebContents*)webContents 24 webContents:(content::WebContents*)webContents
25 errorMessage:(NSString*)errorMessage 25 errorMessage:(NSString*)errorMessage
26 callback:(const BrowserWindow::StartSyncCallback&) 26 callback:(const BrowserWindow::StartSyncCallback&)
27 syncCallback{ 27 syncCallback{
28 viewController_.reset([[OneClickSigninViewController alloc] 28 viewController_.reset([[OneClickSigninViewController alloc]
29 initWithNibName:@"OneClickSigninBubble" 29 initWithNibName:@"OneClickSigninBubble"
30 webContents:webContents 30 webContents:webContents
31 syncCallback:syncCallback 31 syncCallback:syncCallback
32 closeCallback:base::Bind(PerformClose, self) 32 closeCallback:base::Bind(PerformClose, self)
33 isSyncDialog:NO 33 isSyncDialog:NO
34 email:string16() 34 email:base::string16()
35 errorMessage:errorMessage]); 35 errorMessage:errorMessage]);
36 36
37 NSWindow* parentWindow = [controller window]; 37 NSWindow* parentWindow = [controller window];
38 38
39 // Set the anchor point to right below the wrench menu. 39 // Set the anchor point to right below the wrench menu.
40 NSView* wrenchButton = [[controller toolbarController] wrenchButton]; 40 NSView* wrenchButton = [[controller toolbarController] wrenchButton];
41 const NSRect bounds = [wrenchButton bounds]; 41 const NSRect bounds = [wrenchButton bounds];
42 NSPoint anchorPoint = NSMakePoint(NSMidX(bounds), NSMaxY(bounds)); 42 NSPoint anchorPoint = NSMakePoint(NSMidX(bounds), NSMaxY(bounds));
43 anchorPoint = [wrenchButton convertPoint:anchorPoint toView:nil]; 43 anchorPoint = [wrenchButton convertPoint:anchorPoint toView:nil];
44 anchorPoint = [parentWindow convertBaseToScreen:anchorPoint]; 44 anchorPoint = [parentWindow convertBaseToScreen:anchorPoint];
(...skipping 20 matching lines...) Expand all
65 - (OneClickSigninViewController*)viewController { 65 - (OneClickSigninViewController*)viewController {
66 return viewController_; 66 return viewController_;
67 } 67 }
68 68
69 - (void)windowWillClose:(NSNotification*)notification { 69 - (void)windowWillClose:(NSNotification*)notification {
70 [viewController_ viewWillClose]; 70 [viewController_ viewWillClose];
71 [super windowWillClose:notification]; 71 [super windowWillClose:notification];
72 } 72 }
73 73
74 @end // OneClickSigninBubbleController 74 @end // OneClickSigninBubbleController
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698