chrome/browser/ui/webui/history_ui.cc - Issue 114883004: Add base:: namespace to straggling string16s left in chrome/browser/ui.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/history_ui.cc

Issue 114883004: Add base:: namespace to straggling string16s left in chrome/browser/ui. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: found more Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/toolbar/site_chip_view.cc ('k') | chrome/browser/ui/webui/performance_monitor/performance_monitor_l10n.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/history_ui.cc

diff --git a/chrome/browser/ui/webui/history_ui.cc b/chrome/browser/ui/webui/history_ui.cc

index 9f53d384a876773a929ec4047df5a94a9170f5a2..47a6dd005eb70eff165052630c5e3275a67732f5 100644

--- a/chrome/browser/ui/webui/history_ui.cc

+++ b/chrome/browser/ui/webui/history_ui.cc

@@ -317,7 +317,7 @@ scoped_ptr<DictionaryValue> BrowsingHistoryHandler::HistoryEntry::ToValue(

scoped_ptr<DictionaryValue> result(new DictionaryValue());

SetUrlAndTitle(result.get());

- string16 domain = net::IDNToUnicode(url.host(), accept_languages);

+ base::string16 domain = net::IDNToUnicode(url.host(), accept_languages);

// When the domain is empty, use the scheme instead. This allows for a

// sensible treatment of e.g. file: URLs when group by domain is on.

if (domain.empty())