Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 11444028: Make more GL stuff auto-generated (Closed)

Created:
8 years ago by greggman
Modified:
8 years ago
Reviewers:
apatrick_chromium
CC:
chromium-reviews, apatrick_chromium
Visibility:
Public.

Description

Make more GL stuff auto-generated I moved gl_mock.h/cc from gpu to gl and made them mostly autogenned BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171744

Patch Set 1 #

Patch Set 2 : fix content tests #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -1209 lines) Patch
M content/gpu/gpu_info_collector_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/common/debug_marker_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D gpu/command_buffer/common/gl_mock.h View 1 chunk +0 lines, -537 lines 0 comments Download
D gpu/command_buffer/common/gl_mock.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M gpu/command_buffer/service/buffer_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/context_group_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/feature_info_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/framebuffer_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_1.cc View 2 chunks +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_2.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_3.cc View 2 chunks +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h View 1 2 2 chunks +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/memory_program_cache_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/program_manager_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/query_manager_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/renderbuffer_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/shader_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/test_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/test_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/texture_manager_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/vertex_array_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/vertex_attrib_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/gpu.gyp View 1 chunk +1 line, -3 lines 0 comments Download
M ui/gl/generate_bindings.py View 2 chunks +64 lines, -0 lines 0 comments Download
M ui/gl/gl.gyp View 3 chunks +37 lines, -0 lines 0 comments Download
M ui/gl/gl_interface.h View 1 chunk +4 lines, -631 lines 0 comments Download
A ui/gl/gl_mock.h View 1 chunk +29 lines, -0 lines 0 comments Download
A + ui/gl/gl_mock.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
greggman
Hey Al, PTAL It looks worse than it is. Mostly it's just several files changing ...
8 years ago (2012-12-06 11:11:25 UTC) #1
apatrick_chromium
Hooray, I've been meaning to do this for years! LGTM.
8 years ago (2012-12-06 20:13:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/11444028/3002
8 years ago (2012-12-06 20:37:49 UTC) #3
commit-bot: I haz the power
8 years ago (2012-12-06 20:38:34 UTC) #4
Presubmit check for 11444028-3002 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Warnings **
Your #include order seems to be broken. Send mail to
marja@chromium.org if this is not the case.
      gpu/command_buffer/service/gles2_cmd_decoder_unittest_1.cc:256 \
      gpu/command_buffer/service/gles2_cmd_decoder_unittest_2.cc:381 \
      gpu/command_buffer/service/gles2_cmd_decoder_unittest_3.cc:65 \
      gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h:25 \
      ui/gl/gl_interface.h:27 \
      ui/gl/gl_mock.h:24

Presubmit checks took 2.2s to calculate.

Powered by Google App Engine
This is Rietveld 408576698