Issue 11441013: Fix isolate bug introduced by generated code stubs

Issue 11441013: Fix isolate bug introduced by generated code stubs (Closed)

Created:
8 years ago by danno

Modified:
8 years ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix isolate bug introduced by generated code stubs Committed: https://code.google.com/p/v8/source/detail?r=13145

Patch Set 3 : Remove extraneous change #

Patch Set 4 : Correct structness #

Total comments: 6

Patch Set 5 : Review feedback #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -71 lines)			Patch
M	src/arm/code-stubs-arm.cc	View		1 chunk	+8 lines, -14 lines	0 comments	Download
M	src/arm/deoptimizer-arm.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/arm/lithium-arm.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/code-stubs.h	View	1 2 3 4	3 chunks	+16 lines, -7 lines	0 comments	Download
M	src/code-stubs-hydrogen.cc	View	1 2 3 4	1 chunk	+6 lines, -8 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View		1 chunk	+8 lines, -14 lines	0 comments	Download
M	src/ia32/deoptimizer-ia32.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/isolate.h	View	1	2 chunks	+3 lines, -4 lines	0 comments	Download
M	src/isolate.cc	View	1 2 3 4	2 chunks	+7 lines, -1 line	0 comments	Download
M	src/x64/code-stubs-x64.cc	View		1 chunk	+8 lines, -14 lines	0 comments	Download
M	src/x64/deoptimizer-x64.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with nits https://codereview.chromium.org/11441013/diff/16/src/code-stubs-hydrogen.cc File src/code-stubs-hydrogen.cc (right): https://codereview.chromium.org/11441013/diff/16/src/code-stubs-hydrogen.cc#newcode85 src/code-stubs-hydrogen.cc:85: descriptor); nit: fits on one line? ...

8 years ago (2012-12-05 16:14:33 UTC) #2

danno

8 years ago (2012-12-05 16:16:51 UTC) #3

Feedback addressed, landing.

https://codereview.chromium.org/11441013/diff/16/src/code-stubs-hydrogen.cc
File src/code-stubs-hydrogen.cc (right):

https://codereview.chromium.org/11441013/diff/16/src/code-stubs-hydrogen.cc#n...
src/code-stubs-hydrogen.cc:85: descriptor);
On 2012/12/05 16:14:33, Jakob wrote:
> nit: fits on one line?

Done.

https://codereview.chromium.org/11441013/diff/16/src/code-stubs.h
File src/code-stubs.h (right):

https://codereview.chromium.org/11441013/diff/16/src/code-stubs.h#newcode245
src/code-stubs.h:245: public:
On 2012/12/05 16:14:33, Jakob wrote:
> no need for "public:"?

Done.

https://codereview.chromium.org/11441013/diff/16/src/isolate.cc
File src/isolate.cc (right):

https://codereview.chromium.org/11441013/diff/16/src/isolate.cc#newcode2198
src/isolate.cc:2198: Isolate::code_stub_interface_descriptor(int index) {
On 2012/12/05 16:14:33, Jakob wrote:
> nit: 4 space indentation please

Done.

Expand Messages | Collapse Messages