Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: src/ia32/lithium-ia32.cc

Issue 11441013: Fix isolate bug introduced by generated code stubs (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Review feedback Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/deoptimizer-ia32.cc ('k') | src/isolate.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2255 matching lines...) Expand 10 before | Expand all | Expand 10 after
2266 2266
2267 LInstruction* LChunkBuilder::DoParameter(HParameter* instr) { 2267 LInstruction* LChunkBuilder::DoParameter(HParameter* instr) {
2268 LParameter* result = new(zone()) LParameter; 2268 LParameter* result = new(zone()) LParameter;
2269 if (info()->IsOptimizing()) { 2269 if (info()->IsOptimizing()) {
2270 int spill_index = chunk()->GetParameterStackSlot(instr->index()); 2270 int spill_index = chunk()->GetParameterStackSlot(instr->index());
2271 return DefineAsSpilled(result, spill_index); 2271 return DefineAsSpilled(result, spill_index);
2272 } else { 2272 } else {
2273 ASSERT(info()->IsStub()); 2273 ASSERT(info()->IsStub());
2274 CodeStubInterfaceDescriptor* descriptor = 2274 CodeStubInterfaceDescriptor* descriptor =
2275 info()->code_stub()->GetInterfaceDescriptor(info()->isolate()); 2275 info()->code_stub()->GetInterfaceDescriptor(info()->isolate());
2276 Register reg = descriptor->register_params[instr->index()]; 2276 Register reg = descriptor->register_params_[instr->index()];
2277 return DefineFixed(result, reg); 2277 return DefineFixed(result, reg);
2278 } 2278 }
2279 } 2279 }
2280 2280
2281 2281
2282 LInstruction* LChunkBuilder::DoUnknownOSRValue(HUnknownOSRValue* instr) { 2282 LInstruction* LChunkBuilder::DoUnknownOSRValue(HUnknownOSRValue* instr) {
2283 int spill_index = chunk()->GetNextSpillIndex(false); // Not double-width. 2283 int spill_index = chunk()->GetNextSpillIndex(false); // Not double-width.
2284 if (spill_index > LUnallocated::kMaxFixedIndex) { 2284 if (spill_index > LUnallocated::kMaxFixedIndex) {
2285 Abort("Too many spill slots needed for OSR"); 2285 Abort("Too many spill slots needed for OSR");
2286 spill_index = 0; 2286 spill_index = 0;
(...skipping 173 matching lines...) Expand 10 before | Expand all | Expand 10 after
2460 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2460 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2461 LOperand* object = UseRegister(instr->object()); 2461 LOperand* object = UseRegister(instr->object());
2462 LOperand* index = UseTempRegister(instr->index()); 2462 LOperand* index = UseTempRegister(instr->index());
2463 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2463 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2464 } 2464 }
2465 2465
2466 2466
2467 } } // namespace v8::internal 2467 } } // namespace v8::internal
2468 2468
2469 #endif // V8_TARGET_ARCH_IA32 2469 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/deoptimizer-ia32.cc ('k') | src/isolate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698