Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/ia32/code-stubs-ia32.cc

Issue 11441013: Fix isolate bug introduced by generated code stubs (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Review feedback Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/code-stubs-hydrogen.cc ('k') | src/ia32/deoptimizer-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 23 matching lines...) Expand all
34 #include "isolate.h" 34 #include "isolate.h"
35 #include "jsregexp.h" 35 #include "jsregexp.h"
36 #include "regexp-macro-assembler.h" 36 #include "regexp-macro-assembler.h"
37 #include "stub-cache.h" 37 #include "stub-cache.h"
38 #include "codegen.h" 38 #include "codegen.h"
39 39
40 namespace v8 { 40 namespace v8 {
41 namespace internal { 41 namespace internal {
42 42
43 43
44 CodeStubInterfaceDescriptor* 44 void KeyedLoadFastElementStub::InitializeInterfaceDescriptor(
45 KeyedLoadFastElementStub::GetInterfaceDescriptor(Isolate* isolate) { 45 Isolate* isolate,
46 static CodeStubInterfaceDescriptor* result = NULL; 46 CodeStubInterfaceDescriptor* descriptor) {
47 if (result == NULL) { 47 static Register registers[] = { edx, ecx };
48 Handle<Code> miss = isolate->builtins()->KeyedLoadIC_Miss(); 48 descriptor->register_param_count_ = 2;
49 static Register registers[] = { edx, ecx }; 49 descriptor->register_params_ = registers;
50 static CodeStubInterfaceDescriptor info = { 50 descriptor->deoptimization_handler_ =
51 2, 51 isolate->builtins()->KeyedLoadIC_Miss();
52 registers,
53 miss
54 };
55 result = &info;
56 }
57 return result;
58 } 52 }
59 53
60 54
61 #define __ ACCESS_MASM(masm) 55 #define __ ACCESS_MASM(masm)
62 56
63 void ToNumberStub::Generate(MacroAssembler* masm) { 57 void ToNumberStub::Generate(MacroAssembler* masm) {
64 // The ToNumber stub takes one argument in eax. 58 // The ToNumber stub takes one argument in eax.
65 Label check_heap_number, call_builtin; 59 Label check_heap_number, call_builtin;
66 __ JumpIfNotSmi(eax, &check_heap_number, Label::kNear); 60 __ JumpIfNotSmi(eax, &check_heap_number, Label::kNear);
67 __ ret(0); 61 __ ret(0);
(...skipping 7411 matching lines...) Expand 10 before | Expand all | Expand 10 after
7479 // Restore ecx. 7473 // Restore ecx.
7480 __ pop(ecx); 7474 __ pop(ecx);
7481 __ ret(0); 7475 __ ret(0);
7482 } 7476 }
7483 7477
7484 #undef __ 7478 #undef __
7485 7479
7486 } } // namespace v8::internal 7480 } } // namespace v8::internal
7487 7481
7488 #endif // V8_TARGET_ARCH_IA32 7482 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/code-stubs-hydrogen.cc ('k') | src/ia32/deoptimizer-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698