Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Side by Side Diff: src/arm/lithium-arm.cc

Issue 11441013: Fix isolate bug introduced by generated code stubs (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Review feedback Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/deoptimizer-arm.cc ('k') | src/code-stubs.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2185 matching lines...) Expand 10 before | Expand all | Expand 10 after
2196 2196
2197 LInstruction* LChunkBuilder::DoParameter(HParameter* instr) { 2197 LInstruction* LChunkBuilder::DoParameter(HParameter* instr) {
2198 LParameter* result = new(zone()) LParameter; 2198 LParameter* result = new(zone()) LParameter;
2199 if (info()->IsOptimizing()) { 2199 if (info()->IsOptimizing()) {
2200 int spill_index = chunk()->GetParameterStackSlot(instr->index()); 2200 int spill_index = chunk()->GetParameterStackSlot(instr->index());
2201 return DefineAsSpilled(result, spill_index); 2201 return DefineAsSpilled(result, spill_index);
2202 } else { 2202 } else {
2203 ASSERT(info()->IsStub()); 2203 ASSERT(info()->IsStub());
2204 CodeStubInterfaceDescriptor* descriptor = 2204 CodeStubInterfaceDescriptor* descriptor =
2205 info()->code_stub()->GetInterfaceDescriptor(info()->isolate()); 2205 info()->code_stub()->GetInterfaceDescriptor(info()->isolate());
2206 Register reg = descriptor->register_params[instr->index()]; 2206 Register reg = descriptor->register_params_[instr->index()];
2207 return DefineFixed(result, reg); 2207 return DefineFixed(result, reg);
2208 } 2208 }
2209 } 2209 }
2210 2210
2211 2211
2212 LInstruction* LChunkBuilder::DoUnknownOSRValue(HUnknownOSRValue* instr) { 2212 LInstruction* LChunkBuilder::DoUnknownOSRValue(HUnknownOSRValue* instr) {
2213 int spill_index = chunk()->GetNextSpillIndex(false); // Not double-width. 2213 int spill_index = chunk()->GetNextSpillIndex(false); // Not double-width.
2214 if (spill_index > LUnallocated::kMaxFixedIndex) { 2214 if (spill_index > LUnallocated::kMaxFixedIndex) {
2215 Abort("Too many spill slots needed for OSR"); 2215 Abort("Too many spill slots needed for OSR");
2216 spill_index = 0; 2216 spill_index = 0;
(...skipping 160 matching lines...) Expand 10 before | Expand all | Expand 10 after
2377 2377
2378 2378
2379 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2379 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2380 LOperand* object = UseRegister(instr->object()); 2380 LOperand* object = UseRegister(instr->object());
2381 LOperand* index = UseRegister(instr->index()); 2381 LOperand* index = UseRegister(instr->index());
2382 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index)); 2382 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index));
2383 } 2383 }
2384 2384
2385 2385
2386 } } // namespace v8::internal 2386 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/deoptimizer-arm.cc ('k') | src/code-stubs.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698