Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Side by Side Diff: src/x64/code-stubs-x64.cc

Issue 11441013: Fix isolate bug introduced by generated code stubs (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Review feedback Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/isolate.cc ('k') | src/x64/deoptimizer-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 19 matching lines...) Expand all
30 #if defined(V8_TARGET_ARCH_X64) 30 #if defined(V8_TARGET_ARCH_X64)
31 31
32 #include "bootstrapper.h" 32 #include "bootstrapper.h"
33 #include "code-stubs.h" 33 #include "code-stubs.h"
34 #include "regexp-macro-assembler.h" 34 #include "regexp-macro-assembler.h"
35 35
36 namespace v8 { 36 namespace v8 {
37 namespace internal { 37 namespace internal {
38 38
39 39
40 CodeStubInterfaceDescriptor* 40 void KeyedLoadFastElementStub::InitializeInterfaceDescriptor(
41 KeyedLoadFastElementStub::GetInterfaceDescriptor(Isolate* isolate) { 41 Isolate* isolate,
42 static CodeStubInterfaceDescriptor* result = NULL; 42 CodeStubInterfaceDescriptor* descriptor) {
43 if (result == NULL) { 43 static Register registers[] = { rdx, rax };
44 Handle<Code> miss = isolate->builtins()->KeyedLoadIC_Miss(); 44 descriptor->register_param_count_ = 2;
45 static Register registers[] = { rdx, rax }; 45 descriptor->register_params_ = registers;
46 static CodeStubInterfaceDescriptor info = { 46 descriptor->deoptimization_handler_ =
47 2, 47 isolate->builtins()->KeyedLoadIC_Miss();
48 registers,
49 miss
50 };
51 result = &info;
52 }
53 return result;
54 } 48 }
55 49
56 50
57 #define __ ACCESS_MASM(masm) 51 #define __ ACCESS_MASM(masm)
58 52
59 void ToNumberStub::Generate(MacroAssembler* masm) { 53 void ToNumberStub::Generate(MacroAssembler* masm) {
60 // The ToNumber stub takes one argument in eax. 54 // The ToNumber stub takes one argument in eax.
61 Label check_heap_number, call_builtin; 55 Label check_heap_number, call_builtin;
62 __ SmiTest(rax); 56 __ SmiTest(rax);
63 __ j(not_zero, &check_heap_number, Label::kNear); 57 __ j(not_zero, &check_heap_number, Label::kNear);
(...skipping 6423 matching lines...) Expand 10 before | Expand all | Expand 10 after
6487 #endif 6481 #endif
6488 6482
6489 __ Ret(); 6483 __ Ret();
6490 } 6484 }
6491 6485
6492 #undef __ 6486 #undef __
6493 6487
6494 } } // namespace v8::internal 6488 } } // namespace v8::internal
6495 6489
6496 #endif // V8_TARGET_ARCH_X64 6490 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/isolate.cc ('k') | src/x64/deoptimizer-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698