cc: Rework overlays to not use the ResourceProvider and pass texture size

cc: Rework overlays to not use the ResourceProvider and pass texture size

Instead of querying the ResourceProvider, the size & overlay flag are
stored in the quads directly. This eliminates the lookups that were
otherwise required
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=jam (approved interface change)

Committed: https://crrev.com/f89f594219da597c20b749fee195977052c6f709
Cr-Commit-Position: refs/heads/master@{#333748}

[achaulk, 2015-05-28 16:11:39]

achaulk@chromium.org changed reviewers:
+ danakj@chromium.org

[achaulk, 2015-05-28 16:11:41]

This combines both of the other CLs

[danakj, 2015-05-29 20:04:16]

Oops, sorry for slowness. I got halfway thru review and then distracted. I like
this a lot.

https://codereview.chromium.org/1142343008/diff/1/cc/blink/web_external_textu...
File cc/blink/web_external_texture_layer_impl.cc (right):

https://codereview.chromium.org/1142343008/diff/1/cc/blink/web_external_textu...
cc/blink/web_external_texture_layer_impl.cc:91: gfx::Size(),
client_mailbox.allowOverlay);
TODO to pass a valid size and DCHECK allowOverlay => non-empty size?

https://codereview.chromium.org/1142343008/diff/1/cc/layers/texture_layer_imp...
File cc/layers/texture_layer_impl.cc (right):

https://codereview.chromium.org/1142343008/diff/1/cc/layers/texture_layer_imp...
cc/layers/texture_layer_impl.cc:183: quad->resource_size =
external_texture_resource_size_;
could you just pull these from the texture_mailbox_?

https://codereview.chromium.org/1142343008/diff/1/cc/layers/video_layer_impl.h
File cc/layers/video_layer_impl.h (right):

https://codereview.chromium.org/1142343008/diff/1/cc/layers/video_layer_impl....
cc/layers/video_layer_impl.h:66: FrameResource(ResourceId id, gfx::Size size,
bool allow_overlay);
you could inline this constructor, the type is simple enough

https://codereview.chromium.org/1142343008/diff/1/cc/layers/video_layer_impl....
cc/layers/video_layer_impl.h:68: gfx::Size size;
size_in_pixels?

https://codereview.chromium.org/1142343008/diff/1/cc/output/overlay_candidate.h
File cc/output/overlay_candidate.h (right):

https://codereview.chromium.org/1142343008/diff/1/cc/output/overlay_candidate...
cc/output/overlay_candidate.h:38: gfx::Size resource_size;
resource_size_in_pixels?

https://codereview.chromium.org/1142343008/diff/1/cc/quads/stream_video_draw_...
File cc/quads/stream_video_draw_quad.h (right):

https://codereview.chromium.org/1142343008/diff/1/cc/quads/stream_video_draw_...
cc/quads/stream_video_draw_quad.h:35: gfx::Size resource_size;
_in_pixels?

https://codereview.chromium.org/1142343008/diff/1/cc/quads/texture_draw_quad.h
File cc/quads/texture_draw_quad.h (right):

https://codereview.chromium.org/1142343008/diff/1/cc/quads/texture_draw_quad....
cc/quads/texture_draw_quad.h:32: void SetAll(const SharedQuadState*
shared_quad_state,
You'll need to add any new fields on any DrawQuad class to the SetAll functions.
That should find you some new places you need to change in the IPC code (so this
shouldn't actually work right now as these new fields would never get to the
browser).

https://codereview.chromium.org/1142343008/diff/1/cc/quads/texture_draw_quad....
cc/quads/texture_draw_quad.h:47: gfx::Size resource_size;
_in_pixels?

https://codereview.chromium.org/1142343008/diff/1/cc/quads/texture_draw_quad....
cc/quads/texture_draw_quad.h:48: bool allow_overlay;
you'll need to add these to cc_messages

https://codereview.chromium.org/1142343008/diff/1/cc/resources/resource_provi...
File cc/resources/resource_provider.cc (right):

https://codereview.chromium.org/1142343008/diff/1/cc/resources/resource_provi...
cc/resources/resource_provider.cc:566: id, Resource(0, mailbox.size(),
Resource::EXTERNAL, mailbox.target(),
if we're not going to use the size maybe just leave this empty here?

https://codereview.chromium.org/1142343008/diff/1/cc/resources/texture_mailbo...
File cc/resources/texture_mailbox.cc (right):

https://codereview.chromium.org/1142343008/diff/1/cc/resources/texture_mailbo...
cc/resources/texture_mailbox.cc:37: shared_bitmap_(NULL),
nullptr

https://codereview.chromium.org/1142343008/diff/1/cc/resources/texture_mailbo...
cc/resources/texture_mailbox.cc:41: }
can you DCHECK_IMPLIES(allow_overlay, !size.IsEmpty()); ?

https://codereview.chromium.org/1142343008/diff/1/cc/resources/texture_mailbox.h
File cc/resources/texture_mailbox.h (right):

https://codereview.chromium.org/1142343008/diff/1/cc/resources/texture_mailbo...
cc/resources/texture_mailbox.h:28: const gfx::Size& size,
size_in_pixels?

https://codereview.chromium.org/1142343008/diff/1/cc/resources/texture_mailbo...
cc/resources/texture_mailbox.h:53: gfx::Size size() const { return size_; }
size_in_pixels?

Can you comment when this is valid? ie, valid when IsSharedMemory() or when
allow_overlay() are true?

[achaulk, 2015-06-01 15:43:10]

https://codereview.chromium.org/1142343008/diff/1/cc/blink/web_external_textu...
File cc/blink/web_external_texture_layer_impl.cc (right):

https://codereview.chromium.org/1142343008/diff/1/cc/blink/web_external_textu...
cc/blink/web_external_texture_layer_impl.cc:91: gfx::Size(),
client_mailbox.allowOverlay);
On 2015/05/29 20:04:14, danakj wrote:
> TODO to pass a valid size and DCHECK allowOverlay => non-empty size?

Done.

https://codereview.chromium.org/1142343008/diff/1/cc/layers/texture_layer_imp...
File cc/layers/texture_layer_impl.cc (right):

https://codereview.chromium.org/1142343008/diff/1/cc/layers/texture_layer_imp...
cc/layers/texture_layer_impl.cc:183: quad->resource_size =
external_texture_resource_size_;
On 2015/05/29 20:04:14, danakj wrote:
> could you just pull these from the texture_mailbox_?

Done.

https://codereview.chromium.org/1142343008/diff/1/cc/layers/video_layer_impl.h
File cc/layers/video_layer_impl.h (right):

https://codereview.chromium.org/1142343008/diff/1/cc/layers/video_layer_impl....
cc/layers/video_layer_impl.h:66: FrameResource(ResourceId id, gfx::Size size,
bool allow_overlay);
On 2015/05/29 20:04:14, danakj wrote:
> you could inline this constructor, the type is simple enough

Done.

https://codereview.chromium.org/1142343008/diff/1/cc/layers/video_layer_impl....
cc/layers/video_layer_impl.h:68: gfx::Size size;
On 2015/05/29 20:04:14, danakj wrote:
> size_in_pixels?

Done.

https://codereview.chromium.org/1142343008/diff/1/cc/output/overlay_candidate.h
File cc/output/overlay_candidate.h (right):

https://codereview.chromium.org/1142343008/diff/1/cc/output/overlay_candidate...
cc/output/overlay_candidate.h:38: gfx::Size resource_size;
On 2015/05/29 20:04:14, danakj wrote:
> resource_size_in_pixels?

Done.

https://codereview.chromium.org/1142343008/diff/1/cc/quads/stream_video_draw_...
File cc/quads/stream_video_draw_quad.h (right):

https://codereview.chromium.org/1142343008/diff/1/cc/quads/stream_video_draw_...
cc/quads/stream_video_draw_quad.h:35: gfx::Size resource_size;
On 2015/05/29 20:04:14, danakj wrote:
> _in_pixels?

Done.

https://codereview.chromium.org/1142343008/diff/1/cc/quads/texture_draw_quad.h
File cc/quads/texture_draw_quad.h (right):

https://codereview.chromium.org/1142343008/diff/1/cc/quads/texture_draw_quad....
cc/quads/texture_draw_quad.h:47: gfx::Size resource_size;
On 2015/05/29 20:04:14, danakj wrote:
> _in_pixels?

Done.

https://codereview.chromium.org/1142343008/diff/1/cc/quads/texture_draw_quad....
cc/quads/texture_draw_quad.h:48: bool allow_overlay;
On 2015/05/29 20:04:14, danakj wrote:
> you'll need to add these to cc_messages

Done.

https://codereview.chromium.org/1142343008/diff/1/cc/resources/resource_provi...
File cc/resources/resource_provider.cc (right):

https://codereview.chromium.org/1142343008/diff/1/cc/resources/resource_provi...
cc/resources/resource_provider.cc:566: id, Resource(0, mailbox.size(),
Resource::EXTERNAL, mailbox.target(),
On 2015/05/29 20:04:15, danakj wrote:
> if we're not going to use the size maybe just leave this empty here?

Done.

https://codereview.chromium.org/1142343008/diff/1/cc/resources/texture_mailbo...
File cc/resources/texture_mailbox.cc (right):

https://codereview.chromium.org/1142343008/diff/1/cc/resources/texture_mailbo...
cc/resources/texture_mailbox.cc:37: shared_bitmap_(NULL),
On 2015/05/29 20:04:15, danakj wrote:
> nullptr

Done.

https://codereview.chromium.org/1142343008/diff/1/cc/resources/texture_mailbo...
cc/resources/texture_mailbox.cc:41: }
On 2015/05/29 20:04:15, danakj wrote:
> can you DCHECK_IMPLIES(allow_overlay, !size.IsEmpty()); ?

Done.

https://codereview.chromium.org/1142343008/diff/1/cc/resources/texture_mailbox.h
File cc/resources/texture_mailbox.h (right):

https://codereview.chromium.org/1142343008/diff/1/cc/resources/texture_mailbo...
cc/resources/texture_mailbox.h:28: const gfx::Size& size,
On 2015/05/29 20:04:15, danakj wrote:
> size_in_pixels?

Done.

https://codereview.chromium.org/1142343008/diff/1/cc/resources/texture_mailbo...
cc/resources/texture_mailbox.h:53: gfx::Size size() const { return size_; }
On 2015/05/29 20:04:15, danakj wrote:
> size_in_pixels?
> 
> Can you comment when this is valid? ie, valid when IsSharedMemory() or when
> allow_overlay() are true?

Done.

[danakj, 2015-06-01 17:31:30]

https://codereview.chromium.org/1142343008/diff/20001/cc/layers/video_layer_i...
File cc/layers/video_layer_impl.cc (right):

https://codereview.chromium.org/1142343008/diff/20001/cc/layers/video_layer_i...
cc/layers/video_layer_impl.cc:317: stream_video_quad->resource_size_in_pixels =
Can you add these to the SetNew function?

https://codereview.chromium.org/1142343008/diff/20001/cc/output/overlay_unitt...
File cc/output/overlay_unittest.cc (right):

https://codereview.chromium.org/1142343008/diff/20001/cc/output/overlay_unitt...
cc/output/overlay_unittest.cc:198: overlay_quad->allow_overlay = allow_overlay;
can you add these to SetNew for this quad type too?

https://codereview.chromium.org/1142343008/diff/20001/cc/quads/draw_quad_unit...
File cc/quads/draw_quad_unittest.cc (right):

https://codereview.chromium.org/1142343008/diff/20001/cc/quads/draw_quad_unit...
cc/quads/draw_quad_unittest.cc:520: gfx::Size resource_size_in_pixels =
gfx::Size(32, 32);
use non-symmetrical numbers

https://codereview.chromium.org/1142343008/diff/20001/cc/quads/draw_quad_unit...
cc/quads/draw_quad_unittest.cc:562: gfx::Size resource_size_in_pixels =
gfx::Size(32, 32);
non-symmetrical

https://codereview.chromium.org/1142343008/diff/20001/cc/resources/texture_ma...
File cc/resources/texture_mailbox.h (right):

https://codereview.chromium.org/1142343008/diff/20001/cc/resources/texture_ma...
cc/resources/texture_mailbox.h:54: // This is valid if allow_overlau() or
IsSharedMemory() is true.
overlay

https://codereview.chromium.org/1142343008/diff/20001/content/common/cc_messa...
File content/common/cc_messages.h (right):

https://codereview.chromium.org/1142343008/diff/20001/content/common/cc_messa...
content/common/cc_messages.h:210:
IPC_STRUCT_TRAITS_MEMBER(resource_size_in_pixels)
can you add them to the cc_messages_unittests also?

[achaulk, 2015-06-01 21:27:22]

https://codereview.chromium.org/1142343008/diff/20001/cc/output/overlay_unitt...
File cc/output/overlay_unittest.cc (right):

https://codereview.chromium.org/1142343008/diff/20001/cc/output/overlay_unitt...
cc/output/overlay_unittest.cc:198: overlay_quad->allow_overlay = allow_overlay;
On 2015/06/01 17:31:29, danakj wrote:
> can you add these to SetNew for this quad type too?

It seems a bit of a waste to add them everywhere for only one code path. Maybe
have SetNew auto-clear the flag & size and then it can be set after if needed?

[danakj, 2015-06-01 21:36:43]

https://codereview.chromium.org/1142343008/diff/20001/cc/output/overlay_unitt...
File cc/output/overlay_unittest.cc (right):

https://codereview.chromium.org/1142343008/diff/20001/cc/output/overlay_unitt...
cc/output/overlay_unittest.cc:198: overlay_quad->allow_overlay = allow_overlay;
On 2015/06/01 21:27:22, achaulk wrote:
> On 2015/06/01 17:31:29, danakj wrote:
> > can you add these to SetNew for this quad type too?
> 
> It seems a bit of a waste to add them everywhere for only one code path. Maybe
> have SetNew auto-clear the flag & size and then it can be set after if needed?

Oh, I figured all the code paths are setting these now. Like the SetNew in
TextureLayerImpl is setting these now. I guess the VideoLayer texture quad paths
don't. OK!

The constructor initializes them to empty, SetNew doesn't need to do anything
else.

[achaulk, 2015-06-02 19:06:51]

https://codereview.chromium.org/1142343008/diff/20001/cc/layers/video_layer_i...
File cc/layers/video_layer_impl.cc (right):

https://codereview.chromium.org/1142343008/diff/20001/cc/layers/video_layer_i...
cc/layers/video_layer_impl.cc:317: stream_video_quad->resource_size_in_pixels =
On 2015/06/01 17:31:29, danakj wrote:
> Can you add these to the SetNew function?

Done.

https://codereview.chromium.org/1142343008/diff/20001/cc/quads/draw_quad_unit...
File cc/quads/draw_quad_unittest.cc (right):

https://codereview.chromium.org/1142343008/diff/20001/cc/quads/draw_quad_unit...
cc/quads/draw_quad_unittest.cc:520: gfx::Size resource_size_in_pixels =
gfx::Size(32, 32);
On 2015/06/01 17:31:29, danakj wrote:
> use non-symmetrical numbers 

Done.

https://codereview.chromium.org/1142343008/diff/20001/cc/quads/draw_quad_unit...
cc/quads/draw_quad_unittest.cc:562: gfx::Size resource_size_in_pixels =
gfx::Size(32, 32);
On 2015/06/01 17:31:29, danakj wrote:
> non-symmetrical

Done.

https://codereview.chromium.org/1142343008/diff/20001/content/common/cc_messa...
File content/common/cc_messages.h (right):

https://codereview.chromium.org/1142343008/diff/20001/content/common/cc_messa...
content/common/cc_messages.h:210:
IPC_STRUCT_TRAITS_MEMBER(resource_size_in_pixels)
On 2015/06/01 17:31:30, danakj wrote:
> can you add them to the cc_messages_unittests also?

Done.

[danakj, 2015-06-02 19:55:41]

LGTM

[achaulk, 2015-06-05 17:05:49]

The CQ bit was checked by achaulk@chromium.org

[achaulk, 2015-06-05 17:05:50]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/1142343008/#ps60001
(title: "remove ozone change (in another CL) / fix pre presubmits")

[commit-bot: I haz the power, 2015-06-05 17:06:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1142343008/60001

[commit-bot: I haz the power, 2015-06-05 17:12:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-05 17:12:15]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[achaulk, 2015-06-05 18:07:31]

dana PTAL at rebase with the resource_id being moved. I just added the overlay
properties into the resources struct

[danakj, 2015-06-05 18:10:03]

Sorry which struct? Can you point me to it?

[achaulk, 2015-06-05 18:11:02]

Resources struct in draw_quad.h, the resource_ids recently got moved into there

[danakj, 2015-06-05 18:13:26]

https://codereview.chromium.org/1142343008/diff/80001/cc/quads/draw_quad.h
File cc/quads/draw_quad.h (right):

https://codereview.chromium.org/1142343008/diff/80001/cc/quads/draw_quad.h#ne...
cc/quads/draw_quad.h:128: gfx::Size size_in_pixels[kMaxResourceIdCount];
I don't think we should put this on every quad when it's only 2 types. Just put
these arrays on the quads that we can use them for?

You could comment/DCHECK or whatever that they'll have the same number of
members as resources.count?

[achaulk, 2015-06-05 18:14:31]

https://codereview.chromium.org/1142343008/diff/80001/cc/quads/draw_quad.h
File cc/quads/draw_quad.h (right):

https://codereview.chromium.org/1142343008/diff/80001/cc/quads/draw_quad.h#ne...
cc/quads/draw_quad.h:128: gfx::Size size_in_pixels[kMaxResourceIdCount];
On 2015/06/05 18:13:26, danakj wrote:
> I don't think we should put this on every quad when it's only 2 types. Just
put
> these arrays on the quads that we can use them for?
> 
> You could comment/DCHECK or whatever that they'll have the same number of
> members as resources.count?

Ok

[achaulk, 2015-06-05 20:02:05]

achaulk@chromium.org changed reviewers:
+ palmer@chromium.org

[achaulk, 2015-06-05 20:02:06]

+palmer for IPC

[palmer, 2015-06-08 21:50:23]

https://codereview.chromium.org/1142343008/diff/100001/content/common/cc_mess...
File content/common/cc_messages.cc (right):

https://codereview.chromium.org/1142343008/diff/100001/content/common/cc_mess...
content/common/cc_messages.cc:860: for (size_t i = 0; i <
cc::DrawQuad::Resources::kMaxResourceIdCount; ++i) {
I don't know cc well/at all, so this question might have an answer that is
obvious to those who do: What guarantee is there that |size_in_pixels| and
|allow_overlay| have at least |kMaxResourceIdCount| elements?

https://codereview.chromium.org/1142343008/diff/100001/content/common/cc_mess...
content/common/cc_messages.cc:882:
l->append("StreamVideoDrawQuad::OverlayResources(");
Nit: could combine this with the "[" on the next line.

[achaulk, 2015-06-08 21:52:47]

https://codereview.chromium.org/1142343008/diff/100001/content/common/cc_mess...
File content/common/cc_messages.cc (right):

https://codereview.chromium.org/1142343008/diff/100001/content/common/cc_mess...
content/common/cc_messages.cc:860: for (size_t i = 0; i <
cc::DrawQuad::Resources::kMaxResourceIdCount; ++i) {
On 2015/06/08 21:50:22, palmer wrote:
> I don't know cc well/at all, so this question might have an answer that is
> obvious to those who do: What guarantee is there that |size_in_pixels| and
> |allow_overlay| have at least |kMaxResourceIdCount| elements?

They're defined as static arrays with that size. I suppose I could use an
arraysize() macro here instead though

[palmer, 2015-06-08 22:28:13]

https://codereview.chromium.org/1142343008/diff/100001/cc/quads/stream_video_...
File cc/quads/stream_video_draw_quad.cc (right):

https://codereview.chromium.org/1142343008/diff/100001/cc/quads/stream_video_...
cc/quads/stream_video_draw_quad.cc:66: for (unsigned i = 0; i <
Resources::kMaxResourceIdCount; i++)
Nit: ++i

Nit: declare |i| as size_t, since |kMaxResourceIdCount| is declared as size_t.

116   struct CC_EXPORT Resources {
117     enum : size_t { kMaxResourceIdCount = 4 };

https://codereview.chromium.org/1142343008/diff/100001/content/common/cc_mess...
File content/common/cc_messages.cc (right):

https://codereview.chromium.org/1142343008/diff/100001/content/common/cc_mess...
content/common/cc_messages.cc:860: for (size_t i = 0; i <
cc::DrawQuad::Resources::kMaxResourceIdCount; ++i) {
> They're defined as static arrays with that size. I suppose I could use an
> arraysize() macro here instead though

Either way is fine, from a security point of view.

But, what processes formulate these messages, and what processes accept them?
I'm concerned about an untrustworthy process purposefully sending a malformed
object to this code. And, again, perhaps my concern is off-base.

[danakj, 2015-06-08 22:34:21]

https://codereview.chromium.org/1142343008/diff/100001/content/common/cc_mess...
File content/common/cc_messages.cc (right):

https://codereview.chromium.org/1142343008/diff/100001/content/common/cc_mess...
content/common/cc_messages.cc:860: for (size_t i = 0; i <
cc::DrawQuad::Resources::kMaxResourceIdCount; ++i) {
On 2015/06/08 22:28:13, palmer wrote:
> > They're defined as static arrays with that size. I suppose I could use an
> > arraysize() macro here instead though
> 
> Either way is fine, from a security point of view.
> 
> But, what processes formulate these messages, and what processes accept them?
> I'm concerned about an untrustworthy process purposefully sending a malformed
> object to this code. And, again, perhaps my concern is off-base.

The renderer sends them to the browser. If there are more resources in the
stream than this, they'd be read as other fields, and we validate other fields
as usual. That's the same problem as constructing any arbitrary stream. What
kind of problem are you imagining from using a constant here?

[palmer, 2015-06-09 00:01:50]

I think I understand this better now. LGTM % nits.

[achaulk, 2015-06-09 19:24:10]

The CQ bit was checked by achaulk@chromium.org

[achaulk, 2015-06-09 19:24:11]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
palmer@chromium.org
Link to the patchset: https://codereview.chromium.org/1142343008/#ps120001
(title: "fix nits")

[commit-bot: I haz the power, 2015-06-09 19:25:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1142343008/120001

[commit-bot: I haz the power, 2015-06-09 19:34:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-09 19:34:47]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[achaulk, 2015-06-10 16:21:15]

The CQ bit was checked by achaulk@chromium.org

[achaulk, 2015-06-10 16:21:15]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
palmer@chromium.org
Link to the patchset: https://codereview.chromium.org/1142343008/#ps180001
(title: "fix more tests")

[commit-bot: I haz the power, 2015-06-10 16:21:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1142343008/180001

[commit-bot: I haz the power, 2015-06-10 17:01:42]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2015-06-10 17:02:40]

Patchset 10 (id:??) landed as
https://crrev.com/f89f594219da597c20b749fee195977052c6f709
Cr-Commit-Position: refs/heads/master@{#333748}

[Nico, 2015-07-29 19:35:50]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2015-07-29 19:35:52]

https://codereview.chromium.org/1142343008/diff/180001/cc/quads/texture_draw_...
File cc/quads/texture_draw_quad.cc (right):

https://codereview.chromium.org/1142343008/diff/180001/cc/quads/texture_draw_...
cc/quads/texture_draw_quad.cc:48: this->vertex_opacity[0] = vertex_opacity[0];
Does SetNew() intentionally not write overlay_resources?

[danakj, 2015-07-29 20:05:31]

https://codereview.chromium.org/1142343008/diff/180001/cc/quads/texture_draw_...
File cc/quads/texture_draw_quad.cc (right):

https://codereview.chromium.org/1142343008/diff/180001/cc/quads/texture_draw_...
cc/quads/texture_draw_quad.cc:48: this->vertex_opacity[0] = vertex_opacity[0];
On 2015/07/29 19:35:51, Nico wrote:
> Does SetNew() intentionally not write overlay_resources?

Ya they take default values. SetNew is like "most things only wanna set these
and leave others default".