cc: Rework overlays to not use the ResourceProvider and pass texture size

cc/resources/texture_mailbox.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_RESOURCES_TEXTURE_MAILBOX_H_
 #define CC_RESOURCES_TEXTURE_MAILBOX_H_
 
 #include <string>
 
 #include "base/memory/shared_memory.h"
 #include "cc/base/cc_export.h"
 #include "gpu/command_buffer/common/mailbox_holder.h"
 #include "ui/gfx/geometry/size.h"
 
 namespace cc {
 class SharedBitmap;
 
 // TODO(skaslev, danakj) Rename this class more apropriately since now it
 // can hold a shared memory resource as well as a texture mailbox.
 class CC_EXPORT TextureMailbox {
  public:
   TextureMailbox();
   explicit TextureMailbox(const gpu::MailboxHolder& mailbox_holder);
   TextureMailbox(const gpu::Mailbox& mailbox, uint32 target, uint32 sync_point);
+  TextureMailbox(const gpu::Mailbox& mailbox,
+                 uint32 target,
+                 uint32 sync_point,
+                 const gfx::Size& size,

[danakj, 2015/05/29 20:04:15]

size_in_pixels?

[achaulk, 2015/06/01 15:43:10]

Done.

+                 bool allow_overlay);
   TextureMailbox(SharedBitmap* shared_bitmap, const gfx::Size& size);
 
   ~TextureMailbox();
 
   bool IsValid() const { return IsTexture() || IsSharedMemory(); }
   bool IsTexture() const { return !mailbox_holder_.mailbox.IsZero(); }
   bool IsSharedMemory() const { return shared_bitmap_ != NULL; }
 
   bool Equals(const TextureMailbox&) const;
 
   const gpu::Mailbox& mailbox() const { return mailbox_holder_.mailbox; }
   const int8* name() const { return mailbox().name; }
   uint32 target() const { return mailbox_holder_.texture_target; }
   uint32 sync_point() const { return mailbox_holder_.sync_point; }
   void set_sync_point(int32 sync_point) {
     mailbox_holder_.sync_point = sync_point;
   }
 
   bool allow_overlay() const { return allow_overlay_; }
-  void set_allow_overlay(bool allow_overlay) { allow_overlay_ = allow_overlay; }
   bool nearest_neighbor() const { return nearest_neighbor_; }
   void set_nearest_neighbor(bool nearest_neighbor) {
     nearest_neighbor_ = nearest_neighbor;
   }
+  gfx::Size size() const { return size_; }

[danakj, 2015/05/29 20:04:15]

size_in_pixels?

Can you comment when this is valid? ie, valid when IsSharedMemory() or when
allow_overlay() are true?

[achaulk, 2015/06/01 15:43:10]

Done.

 
   SharedBitmap* shared_bitmap() const { return shared_bitmap_; }
-  gfx::Size shared_memory_size() const { return shared_memory_size_; }
   size_t SharedMemorySizeInBytes() const;
 
  private:
   gpu::MailboxHolder mailbox_holder_;
   SharedBitmap* shared_bitmap_;
-  gfx::Size shared_memory_size_;
+  gfx::Size size_;
   bool allow_overlay_;
   bool nearest_neighbor_;
 };
 
 }  // namespace cc
 
 #endif  // CC_RESOURCES_TEXTURE_MAILBOX_H_