Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 1141643004: Remove arm_float_abi=hard from GYP_DEFINES (Closed)

Created:
5 years, 7 months ago by Sam Clegg
Modified:
5 years, 7 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, kjellander-cc_chromium.org, stip+watch_chromium.org
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Remove arm_float_abi=hard from GYP_DEFINES This is now the default for Linux ARM builds as of https://codereview.chromium.org/1140503004/. R=phajdan.jr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=295355

Patch Set 1 #

Messages

Total messages: 14 (5 generated)
Sam Clegg
5 years, 7 months ago (2015-05-20 21:57:57 UTC) #2
Paweł Hajdan Jr.
LGTM
5 years, 7 months ago (2015-05-21 10:10:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141643004/1
5 years, 7 months ago (2015-05-21 18:13:50 UTC) #5
commit-bot: I haz the power
Presubmit check for 1141643004-1 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 7 months ago (2015-05-21 18:16:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141643004/1
5 years, 7 months ago (2015-05-21 18:43:23 UTC) #9
commit-bot: I haz the power
Presubmit check for 1141643004-1 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 7 months ago (2015-05-21 18:46:15 UTC) #11
Sam Clegg
Committed patchset #1 (id:1) manually as 295355.
5 years, 7 months ago (2015-05-21 18:47:17 UTC) #12
Michael Achenbach
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1152193002/ by machenbach@chromium.org. ...
5 years, 7 months ago (2015-05-22 08:11:32 UTC) #13
Michael Achenbach
5 years, 7 months ago (2015-05-22 08:17:43 UTC) #14
Message was sent while issue was closed.
Making a partial revert: https://codereview.chromium.org/1150253002/

Powered by Google App Engine
This is Rietveld 408576698