Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1152193002: Revert of Remove arm_float_abi=hard from GYP_DEFINES (Closed)

Created:
5 years, 7 months ago by Michael Achenbach
Modified:
5 years, 7 months ago
CC:
chromium-reviews, kjellander-cc_chromium.org, stip+watch_chromium.org
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Revert of Remove arm_float_abi=hard from GYP_DEFINES (patchset #1 id:1 of https://codereview.chromium.org/1141643004/) Reason for revert: This causes build breakages in v8: http://build.chromium.org/p/client.v8/builders/V8%20Arm/builds/2109 The dependent CL https://codereview.chromium.org/1140503004/ takes care of chromium, but not v8. Original issue's description: > Remove arm_float_abi=hard from GYP_DEFINES > > This is now the default for Linux ARM builds as > of https://codereview.chromium.org/1140503004/. > > R=phajdan.jr@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=295355 TBR=phajdan.jr@chromium.org,sbc@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true

Patch Set 1 #

Messages

Total messages: 5 (1 generated)
Michael Achenbach
Created Revert of Remove arm_float_abi=hard from GYP_DEFINES
5 years, 7 months ago (2015-05-22 08:11:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1152193002/1
5 years, 7 months ago (2015-05-22 08:11:41 UTC) #2
commit-bot: I haz the power
Failed to apply patch for build/scripts/slave/recipe_modules/chromium/chromium_fyi.py: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
5 years, 7 months ago (2015-05-22 08:11:48 UTC) #4
Michael Achenbach
5 years, 7 months ago (2015-05-22 08:14:53 UTC) #5
Since this doesn't apply, I'll manually make a partial revert of the v8 stuff.

Powered by Google App Engine
This is Rietveld 408576698