scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_arm_compile_analyze.json - Issue 1141643004: Remove arm_float_abi=hard from GYP_DEFINES

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_arm_compile_analyze.json

Issue 1141643004: Remove arm_float_abi=hard from GYP_DEFINES (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_arm_compile.json ('k') | scripts/slave/recipes/v8.expected/full_client_v8_V8_Arm___builder.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_arm_compile_analyze.json

diff --git a/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_arm_compile_analyze.json b/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_arm_compile_analyze.json

index ddfbcd1e44ff374e5ce724f6139d32eee2810fa8..421eee707a3ee804da0332a84c774ab1fdee2b68 100644

--- a/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_arm_compile_analyze.json

+++ b/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_arm_compile_analyze.json

@@ -77,7 +77,7 @@

"cwd": "[SLAVE_BUILD]",

"env": {

"GYP_CROSSCOMPILE": "1",

- "GYP_DEFINES": "arm_float_abi=hard component=static_library dcheck_always_on=1 fastbuild=1 gomadir='[BUILD]/goma' target_arch=arm test_isolation_mode=prepare use_goma=1"

+ "GYP_DEFINES": "component=static_library dcheck_always_on=1 fastbuild=1 gomadir='[BUILD]/goma' target_arch=arm test_isolation_mode=prepare use_goma=1"

"name": "gclient runhooks (with patch)"

@@ -172,7 +172,7 @@

"cwd": "[SLAVE_BUILD]",

"env": {

"GYP_CROSSCOMPILE": "1",

- "GYP_DEFINES": "arm_float_abi=hard component=static_library dcheck_always_on=1 fastbuild=1 gomadir='[BUILD]/goma' target_arch=arm test_isolation_mode=prepare use_goma=1"

+ "GYP_DEFINES": "component=static_library dcheck_always_on=1 fastbuild=1 gomadir='[BUILD]/goma' target_arch=arm test_isolation_mode=prepare use_goma=1"

"name": "analyze",

"~followup_annotations": [