Issue 1150253002: Partial revert of Remove arm_float_abi=hard from GYP_DEFINES

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1150253002: Partial revert of Remove arm_float_abi=hard from GYP_DEFINES (Closed)

Created:
5 years, 7 months ago by Michael Achenbach

Modified:
5 years, 7 months ago

Reviewers:
Sam Clegg, Paweł Hajdan Jr.

CC:
chromium-reviews, kjellander-cc_chromium.org, stip+watch_chromium.org, ulan

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/build

Target Ref:
refs/heads/master

Project:
tools

Visibility:
Public.

Partial revert of Remove arm_float_abi=hard from GYP_DEFINES Revert the v8 part from https://codereview.chromium.org/1141643004/ There are no defaults for hard-float on the v8-side gyp yet. TBR=phajdan.jr@chromium.org, sbc@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295373

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -2 lines)			Patch
M	scripts/slave/recipe_modules/v8/chromium_config.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	scripts/slave/recipes/v8.expected/full_client_v8_V8_Arm___builder.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	scripts/slave/recipes/v8.expected/full_client_v8_V8_Arm___debug_builder.json	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1150253002/1

5 years, 7 months ago (2015-05-22 08:17:41 UTC) #4

commit-bot: I haz the power

5 years, 7 months ago (2015-05-22 08:20:33 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=295373