Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11375004: [NaCl Addin] Fix to PNaCl lib creation from MSVS (Closed)

Created:
8 years, 1 month ago by Sam Clegg
Modified:
8 years, 1 month ago
Reviewers:
noelallen1, binji
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

[NaCl Addin] Fix to PNaCl lib creation from MSVS Enable PNaCl in the addin for recent pepper builds. Fix path to httpd.py (it was moved in pepper_canary). BUG= Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1466

Patch Set 1 #

Total comments: 12

Patch Set 2 : #

Messages

Total messages: 4 (0 generated)
Sam Clegg
8 years, 1 month ago (2012-11-12 20:06:40 UTC) #1
Sam Clegg
http://codereview.chromium.org/11375004/diff/1/visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClCompile.cs File visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClCompile.cs (left): http://codereview.chromium.org/11375004/diff/1/visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClCompile.cs#oldcode20 visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClCompile.cs:20: { Code lifted into the superclass. http://codereview.chromium.org/11375004/diff/1/visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClLink.cs File visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClLink.cs ...
8 years, 1 month ago (2012-11-12 20:10:35 UTC) #2
binji
lgtm http://codereview.chromium.org/11375004/diff/1/visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClToolTask.cs File visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClToolTask.cs (right): http://codereview.chromium.org/11375004/diff/1/visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClToolTask.cs#newcode156 visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClToolTask.cs:156: protected virtual void OutputReadTLog(ITaskItem[] compiledSources, CanonicalTrackedOutputFiles outputs) nit: ...
8 years, 1 month ago (2012-11-12 21:27:02 UTC) #3
Sam Clegg
8 years, 1 month ago (2012-11-12 21:56:22 UTC) #4 
http://codereview.chromium.org/11375004/diff/1/visual_studio/NativeClientVSAd...
File visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClToolTask.cs
(right):

http://codereview.chromium.org/11375004/diff/1/visual_studio/NativeClientVSAd...
visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClToolTask.cs:156:
protected virtual void OutputReadTLog(ITaskItem[] compiledSources,
CanonicalTrackedOutputFiles outputs)
On 2012/11/12 21:27:02, binji wrote:
> nit: wrap at 100

Done.

http://codereview.chromium.org/11375004/diff/1/visual_studio/NativeClientVSAd...
visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClToolTask.cs:181: using
(StreamWriter writer = new StreamWriter(TLogCommandFile.GetMetadata("FullPath"),
false, Encoding.Unicode))
On 2012/11/12 21:27:02, binji wrote:
> nit: wrap at 100

Done.

http://codereview.chromium.org/11375004/diff/1/visual_studio/NativeClientVSAd...
File visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/SDKUtilities.cs
(right):

http://codereview.chromium.org/11375004/diff/1/visual_studio/NativeClientVSAd...
visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/SDKUtilities.cs:17: //
TODO(sbc): update this value once we release one.
On 2012/11/12 21:27:02, binji wrote:
> remove TODO and comment

Done.

http://codereview.chromium.org/11375004/diff/1/visual_studio/NativeClientVSAd...
File visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/WebServer.cs (right):

http://codereview.chromium.org/11375004/diff/1/visual_studio/NativeClientVSAd...
visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/WebServer.cs:8: using
System.IO;
On 2012/11/12 21:27:02, binji wrote:
> weird indent... but it kinda makes sense. Typo?

Done.

Powered by Google App Engine
This is Rietveld 408576698