visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/SDKUtilities.cs - Issue 11375004: [NaCl Addin] Fix to PNaCl lib creation from MSVS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/SDKUtilities.cs

Issue 11375004: [NaCl Addin] Fix to PNaCl lib creation from MSVS (Closed) Base URL: http://nativeclient-sdk.googlecode.com/svn/trunk/src

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClToolTask.cs ('k') | visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/WebServer.cs » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/SDKUtilities.cs

diff --git a/visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/SDKUtilities.cs b/visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/SDKUtilities.cs

index a91029e285e60b5cfe8669ec1fc6c4b4e9299d97..6d2d2e6095acdc0aef5ef168f6294f9af7cb2ff5 100644

--- a/visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/SDKUtilities.cs

+++ b/visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/SDKUtilities.cs

@@ -13,9 +13,8 @@ namespace NaCl.Build.CPPTasks

/// </summary>

public class SDKUtilities

{

- // No known SDK version has working PNaC toolchain yet

- // TODO(sbc): update this value once we release one.

- public const int MinPNaCLSDKVersion = 999999;

+ // The first version of pepper with a known working PNaCl toolchain

+ public const int MinPNaCLSDKVersion = 166868;

/// <summary>

/// Find python executable in user's PATH.