Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Unified Diff: visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClCompile.cs

Issue 11375004: [NaCl Addin] Fix to PNaCl lib creation from MSVS (Closed) Base URL: http://nativeclient-sdk.googlecode.com/svn/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClCompile.cs
diff --git a/visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClCompile.cs b/visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClCompile.cs
index 8696e23b9db75369ba78db83293065d728c965a0..1f763dcef41f1cef7fabacb9fe2568beabd79e90 100644
--- a/visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClCompile.cs
+++ b/visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClCompile.cs
@@ -20,20 +20,12 @@ namespace NaCl.Build.CPPTasks
{
public class NaClCompile : NaClToolTask
{
- public bool BuildingInIDE { get; set; }
-
[Required]
public string PropertiesFile { get; set; }
[Required]
public string NaCLCompilerPath { get; set; }
- [Required]
- public bool OutputCommandLine { get; set; }
-
- [Required]
- public string Platform { get; set; }
-
public int ProcessorNumber { get; set; }
public bool MultiProcessorCompilation { get; set; }
@@ -54,11 +46,6 @@ namespace NaCl.Build.CPPTasks
}
}
- protected override string GenerateFullPathToTool()
- {
- return ToolName;
- }
-
public NaClCompile()
: base(new ResourceManager("NaCl.Build.CPPTasks.Properties.Resources", Assembly.GetExecutingAssembly()))
{

Powered by Google App Engine
This is Rietveld 408576698