Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Side by Side Diff: visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/SDKUtilities.cs

Issue 11375004: [NaCl Addin] Fix to PNaCl lib creation from MSVS (Closed) Base URL: http://nativeclient-sdk.googlecode.com/svn/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 namespace NaCl.Build.CPPTasks 5 namespace NaCl.Build.CPPTasks
6 { 6 {
7 using System; 7 using System;
8 using System.IO; 8 using System.IO;
9 using System.Collections.Generic; 9 using System.Collections.Generic;
10 10
11 /// <summary> 11 /// <summary>
12 /// TODO: Update summary. 12 /// TODO: Update summary.
13 /// </summary> 13 /// </summary>
14 public class SDKUtilities 14 public class SDKUtilities
15 { 15 {
16 // No known SDK version has working PNaC toolchain yet 16 // No known SDK version has working PNaC toolchain yet
17 // TODO(sbc): update this value once we release one. 17 // TODO(sbc): update this value once we release one.
binji 2012/11/12 21:27:02 remove TODO and comment
Sam Clegg 2012/11/12 21:56:22 Done.
18 public const int MinPNaCLSDKVersion = 999999; 18 public const int MinPNaCLSDKVersion = 166868;
Sam Clegg 2012/11/12 20:10:36 This is the first pepper version with working PNaC
19 19
20 /// <summary> 20 /// <summary>
21 /// Find python executable in user's PATH. 21 /// Find python executable in user's PATH.
22 /// </summary> 22 /// </summary>
23 public static bool FindPython() 23 public static bool FindPython()
24 { 24 {
25 string envvar = Environment.GetEnvironmentVariable("Path", Environme ntVariableTarget.Process); 25 string envvar = Environment.GetEnvironmentVariable("Path", Environme ntVariableTarget.Process);
26 List<string> pathList = new List<string>(envvar.Split(';')); 26 List<string> pathList = new List<string>(envvar.Split(';'));
27 foreach (string path in pathList) 27 foreach (string path in pathList)
28 { 28 {
(...skipping 26 matching lines...) Expand all
55 { 55 {
56 if (line.StartsWith("Revision")) 56 if (line.StartsWith("Revision"))
57 revision = Convert.ToInt32(line.Split(':')[1]); 57 revision = Convert.ToInt32(line.Split(':')[1]);
58 if (line.StartsWith("Version")) 58 if (line.StartsWith("Version"))
59 version = Convert.ToInt32(line.Split(':')[1]); 59 version = Convert.ToInt32(line.Split(':')[1]);
60 } 60 }
61 return version; 61 return version;
62 } 62 }
63 } 63 }
64 } 64 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698