[NaCl Addin] Fix to PNaCl lib creation from MSVS

visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClCompile.cs

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 using System;
 using System.Collections.Generic;
 using System.Text;
 using System.Collections;
 using System.IO;
 using System.Reflection;
 using System.Resources;
 using System.Windows.Forms;
 using Microsoft.Build.Framework;
 using Microsoft.Win32;
 using Microsoft.Build.Utilities;
 using System.Collections.Specialized;
 
 using System.Diagnostics;
 
 namespace NaCl.Build.CPPTasks
 {

[Sam Clegg, 2012/11/12 20:10:36]

Code lifted into the superclass.

     public class NaClCompile : NaClToolTask
     {
-        public bool BuildingInIDE { get; set; }
-
         [Required]
         public string PropertiesFile { get; set; }
 
         [Required]
         public string NaCLCompilerPath { get; set; }
 
-        [Required]
-        public bool OutputCommandLine { get; set; }
-
-        [Required]
-        public string Platform { get; set; }
-
         public int ProcessorNumber { get; set; }
 
         public bool MultiProcessorCompilation { get; set; }
 
         [Required]
         public string ConfigurationType { get; set; }
 
         [Obsolete]
         protected override StringDictionary EnvironmentOverride
         {
             get {
                 string show = OutputCommandLine ? "1" : "0";
                 string cores = Convert.ToString(ProcessorNumber);
                 return new StringDictionary() {
                       {"NACL_GCC_CORES", cores},
                       {"NACL_GCC_SHOW_COMMANDS", show }
                 };
             }
         }
 
-        protected override string GenerateFullPathToTool()
-        {
-            return ToolName;
-        }
-
         public NaClCompile()
             : base(new ResourceManager("NaCl.Build.CPPTasks.Properties.Resources", Assembly.GetExecutingAssembly()))
         {
             this.EnvironmentVariables = new string[] { "CYGWIN=nodosfilewarning", "LC_CTYPE=C" };
         }
 
         protected IDictionary<string, string> GenerateCommandLinesFromTlog()
         {
             IDictionary<string, string> cmdLineDictionary = new Dictionary<string, string>(StringComparer.OrdinalIgnoreCase);
             string tlogFilename = this.TLogCommandFile.GetMetadata("FullPath");
@@ skipping 479 matching lines @@
         protected override string ToolName
         {
             get
             {
                 return NaCLCompilerPath;
             }
         }
 
     }
 }