Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 11369258: Revert 167808 - Get rid of use of CreateStringValue in chromeos/ directory. (Closed)

Created:
8 years, 1 month ago by kinaba
Modified:
8 years, 1 month ago
Reviewers:
Evan Stade
CC:
chromium-reviews, nkostylev+watch_chromium.org, feature-media-reviews_chromium.org, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Revert 167808 - Get rid of use of CreateStringValue in chromeos/ directory. Reverting because the patch makes clang build failing: > chrome/browser/chromeos/cros/network_library.cc:380:26:error: C++98 requires an > accessible copy constructor for class 'base::StringValue' when binding a > reference to a temporary; was private [-Werror,-Wbind-to-temporary-copy] > SetValueProperty(prop, base::StringValue(str)); etc. BUG=160586 Review URL: https://chromiumcodereview.appspot.com/11363203 TBR=estade@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=167826

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -119 lines) Patch
M base/values.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/cros/cros_network_functions.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/cros/cros_network_functions_unittest.cc View 15 chunks +45 lines, -45 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/cros/network_library.cc View 4 chunks +10 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/cros/network_ui_data_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/extensions/echo_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_private_api.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_handler_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/info_private_api.h View 2 chunks +1 line, -6 lines 0 comments Download
M chrome/browser/chromeos/extensions/info_private_api.cc View 2 chunks +13 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/login/user_image_manager_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/user_manager_impl.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/wallpaper_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/media/media_player_extension_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/proxy_cros_settings_parser.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/settings/cros_settings_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_provider.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/settings/system_settings_provider.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/settings/system_settings_provider.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kinaba
8 years, 1 month ago (2012-11-15 02:22:00 UTC) #1
Evan Stade
8 years, 1 month ago (2012-11-15 18:03:08 UTC) #2
thanks for reverting.

Powered by Google App Engine
This is Rietveld 408576698