Revert 167808 - Get rid of use of CreateStringValue in chromeos/ directory.

chrome/browser/chromeos/login/user_manager_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/user_manager_impl.h"
 
 #include "ash/shell.h"
 #include "base/bind.h"
 #include "base/chromeos/chromeos_version.h"
 #include "base/command_line.h"
@@ skipping 156 matching lines @@
   }
 
   EnsureUsersLoaded();
 
   // Clear the prefs view of the users.
   PrefService* prefs = g_browser_process->local_state();
   ListPrefUpdate prefs_users_update(prefs, kLoggedInUsers);
   prefs_users_update->Clear();
 
   // Make sure this user is first.
-  prefs_users_update->Append(new base::StringValue(email));
+  prefs_users_update->Append(Value::CreateStringValue(email));
   UserList::iterator logged_in_user = users_.end();
   for (UserList::iterator it = users_.begin(); it != users_.end(); ++it) {
     std::string user_email = (*it)->email();
     // Skip the most recent user.
     if (email != user_email)
-      prefs_users_update->Append(new base::StringValue(user_email));
+      prefs_users_update->Append(Value::CreateStringValue(user_email));
     else
       logged_in_user = it;
   }
 
   if (logged_in_user == users_.end()) {
     is_current_user_new_ = true;
     logged_in_user_ = CreateUser(email, /* is_ephemeral= */ false);
   } else {
     logged_in_user_ = *logged_in_user;
     users_.erase(logged_in_user);
@@ skipping 168 matching lines @@
 
   // Do not update local store if the user is ephemeral.
   if (IsEphemeralUser(username))
     return;
 
   PrefService* local_state = g_browser_process->local_state();
 
   DictionaryPrefUpdate display_name_update(local_state, kUserDisplayName);
   display_name_update->SetWithoutPathExpansion(
       username,
-      new base::StringValue(display_name));
+      base::Value::CreateStringValue(display_name));
 }
 
 string16 UserManagerImpl::GetUserDisplayName(
     const std::string& username) const {
   const User* user = FindUser(username);
   return user ? user->display_name() : string16();
 }
 
 void UserManagerImpl::SaveUserDisplayEmail(const std::string& username,
                                            const std::string& display_email) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
   User* user = const_cast<User*>(FindUser(username));
   if (!user)
     return;  // Ignore if there is no such user.
 
   user->set_display_email(display_email);
 
   // Do not update local store if the user is ephemeral.
   if (IsEphemeralUser(username))
     return;
 
   PrefService* local_state = g_browser_process->local_state();
 
   DictionaryPrefUpdate display_email_update(local_state, kUserDisplayEmail);
   display_email_update->SetWithoutPathExpansion(
       username,
-      new base::StringValue(display_email));
+      base::Value::CreateStringValue(display_email));
 }
 
 std::string UserManagerImpl::GetUserDisplayEmail(
     const std::string& username) const {
   const User* user = FindUser(username);
   return user ? user->display_email() : username;
 }
 
 void UserManagerImpl::SetLoggedInUserCustomWallpaperLayout(
     ash::WallpaperLayout layout) {
@@ skipping 311 matching lines @@
   // Clear the prefs view of the users.
   PrefService* prefs = g_browser_process->local_state();
   ListPrefUpdate prefs_users_update(prefs, kLoggedInUsers);
   prefs_users_update->Clear();
 
   UserList::iterator user_to_remove = users_.end();
   for (UserList::iterator it = users_.begin(); it != users_.end(); ++it) {
     std::string user_email = (*it)->email();
     // Skip user that we would like to delete.
     if (email != user_email)
-      prefs_users_update->Append(new base::StringValue(user_email));
+      prefs_users_update->Append(Value::CreateStringValue(user_email));
     else
       user_to_remove = it;
   }
 
   WallpaperManager::Get()->RemoveUserWallpaperInfo(email);
 
   DictionaryPrefUpdate prefs_oauth_update(prefs, kUserOAuthTokenStatus);
   int oauth_status;
   prefs_oauth_update->GetIntegerWithoutPathExpansion(email, &oauth_status);
   prefs_oauth_update->RemoveWithoutPathExpansion(email, NULL);
 
   DictionaryPrefUpdate prefs_display_name_update(prefs, kUserDisplayName);
   prefs_display_name_update->RemoveWithoutPathExpansion(email, NULL);
 
   DictionaryPrefUpdate prefs_display_email_update(prefs, kUserDisplayEmail);
   prefs_display_email_update->RemoveWithoutPathExpansion(email, NULL);
 
   if (user_to_remove != users_.end()) {
     delete *user_to_remove;
     users_.erase(user_to_remove);
   }
 }
 
 }  // namespace chromeos