Revert 167808 - Get rid of use of CreateStringValue in chromeos/ directory.

chrome/browser/chromeos/login/user_image_manager_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/memory/ref_counted_memory.h"
 #include "base/path_service.h"
@@ skipping 54 matching lines @@
   }
 
   // UserManager::Observer overrides:
   virtual void LocalStateChanged(UserManager* user_manager) OVERRIDE {
     MessageLoopForUI::current()->Quit();
   }
 
   // Adds given user to Local State, if not there.
   void AddUser(const std::string& username) {
     ListPrefUpdate users_pref(local_state_, "LoggedInUsers");
-    users_pref->AppendIfNotPresent(new base::StringValue(username));
+    users_pref->AppendIfNotPresent(base::Value::CreateStringValue(username));
   }
 
   // Logs in |username|.
   void LogIn(const std::string& username) {
     UserManager::Get()->UserLoggedIn(username, false);
   }
 
   // Subscribes for image change notification.
   void ExpectImageChange() {
     registrar_.Add(this, chrome::NOTIFICATION_LOGIN_USER_IMAGE_CHANGED,
                    content::NotificationService::AllSources());
   }
 
   // Stores old (pre-migration) user image info.
   void SetOldUserImageInfo(const std::string& username,
                            int image_index,
                            const FilePath& image_path) {
     AddUser(username);
     DictionaryPrefUpdate images_pref(local_state_, "UserImages");
     base::DictionaryValue* image_properties = new base::DictionaryValue();
     image_properties->Set(
         "index", base::Value::CreateIntegerValue(image_index));
     image_properties->Set(
-        "path" , new base::StringValue(image_path.value()));
+        "path" , base::Value::CreateStringValue(image_path.value()));
     images_pref->SetWithoutPathExpansion(username, image_properties);
   }
 
   // Verifies user image info in |images_pref| dictionary.
   void ExpectUserImageInfo(const base::DictionaryValue* images_pref,
                            const std::string& username,
                            int image_index,
                            const FilePath& image_path) {
     ASSERT_TRUE(images_pref);
     const base::DictionaryValue* image_properties = NULL;
@@ skipping 143 matching lines @@
   const User* user = UserManager::Get()->FindUser(kTestUser1);
   ASSERT_TRUE(user);
   EXPECT_TRUE(user->image_is_safe_format());
   // Check image dimensions. Images can't be compared since JPEG is lossy.
   const gfx::ImageSkia& saved_image = GetDefaultImage(kFirstDefaultImageIndex);
   EXPECT_EQ(saved_image.width(), user->image().width());
   EXPECT_EQ(saved_image.height(), user->image().height());
 }
 
 }  // namespace chromeos