chrome/browser/chromeos/settings/device_settings_provider.cc - Issue 11369258: Revert 167808 - Get rid of use of CreateStringValue in chromeos/ directory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/settings/device_settings_provider.cc

Issue 11369258: Revert 167808 - Get rid of use of CreateStringValue in chromeos/ directory. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/settings/cros_settings_unittest.cc ('k') | chrome/browser/chromeos/settings/system_settings_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/settings/device_settings_provider.cc

===================================================================

--- chrome/browser/chromeos/settings/device_settings_provider.cc (revision 167824)

+++ chrome/browser/chromeos/settings/device_settings_provider.cc (working copy)

@@ -358,7 +358,7 @@

whitelist_proto.user_whitelist();

for (RepeatedPtrField<std::string>::const_iterator it = whitelist.begin();

it != whitelist.end(); ++it) {

- list->Append(new base::StringValue(*it));

+ list->Append(base::Value::CreateStringValue(*it));

}

new_values_cache->SetValue(kAccountsPrefUsers, list);

}

@@ -418,7 +418,7 @@

const RepeatedPtrField<std::string>& urls = urls_proto.start_up_urls();

for (RepeatedPtrField<std::string>::const_iterator it = urls.begin();

it != urls.end(); ++it) {

- list->Append(new base::StringValue(*it));

+ list->Append(base::Value::CreateStringValue(*it));

}

new_values_cache->SetValue(kStartUpUrls, list);

}