Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Unified Diff: chrome/browser/chromeos/extensions/info_private_api.h

Issue 11369258: Revert 167808 - Get rid of use of CreateStringValue in chromeos/ directory. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/info_private_api.h
===================================================================
--- chrome/browser/chromeos/extensions/info_private_api.h (revision 167824)
+++ chrome/browser/chromeos/extensions/info_private_api.h (working copy)
@@ -10,10 +10,6 @@
#include "base/compiler_specific.h"
#include "chrome/browser/extensions/extension_function.h"
-namespace base {
-class Value;
-}
-
namespace extensions {
class GetChromeosInfoFunction : public AsyncExtensionFunction {
@@ -26,8 +22,7 @@
virtual bool RunImpl() OVERRIDE;
private:
- // Returns a newly allocate value, or null.
- base::Value* GetValue(const std::string& property_name);
+ bool GetValue(const std::string& property_name, Value** value);
DECLARE_EXTENSION_FUNCTION_NAME("chromeosInfoPrivate.get");
};
« no previous file with comments | « chrome/browser/chromeos/extensions/file_manager_util.cc ('k') | chrome/browser/chromeos/extensions/info_private_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698