Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 11360066: cc: Remove WebCore rect use from the compositor, except within Region. (Closed)

Created:
8 years, 1 month ago by danakj
Modified:
8 years, 1 month ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

cc: Remove WebCore rect use from the compositor, except within Region. This replaces the last cases of FloatRect with gfx::RectF. It depends on the IsExpressibleAsRect() method in https://codereview.chromium.org/11364054/ and removes the stubs as well! We add an API to the Region class that is intended to be our final Region class interface. It uses an iterator to walk the rects in the Region, which is compatible with the SkRegion API, but can also hide the IntRects exposed by the WebCore Region API. Once this is done, there is no need to use cc::IntRect, and we can remove it entirely. Covered by existing tests; no change in behaviour. BUG=147395 R=enne Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=165837

Patch Set 1 #

Patch Set 2 : Fix bindings #

Patch Set 3 : Signs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+255 lines, -409 lines) Patch
M cc/cc.gyp View 2 chunks +0 lines, -4 lines 0 comments Download
M cc/gl_renderer.cc View 2 chunks +1 line, -2 lines 0 comments Download
M cc/layer.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/layer_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/layer_tree_host_unittest.cc View 11 chunks +39 lines, -39 lines 0 comments Download
M cc/occlusion_tracker.cc View 5 chunks +10 lines, -14 lines 0 comments Download
M cc/occlusion_tracker_unittest.cc View 51 chunks +136 lines, -134 lines 0 comments Download
M cc/render_pass.cc View 1 chunk +2 lines, -3 lines 0 comments Download
D cc/stubs/FloatRect.h View 1 chunk +0 lines, -6 lines 0 comments Download
D cc/stubs/IntRect.h View 1 chunk +0 lines, -6 lines 0 comments Download
M cc/stubs/Region.h View 1 2 3 chunks +50 lines, -24 lines 0 comments Download
D cc/stubs/float_rect.h View 1 chunk +0 lines, -73 lines 0 comments Download
D cc/stubs/int_rect.h View 1 chunk +0 lines, -61 lines 0 comments Download
M cc/test/layer_test_common.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M cc/tiled_layer.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M cc/tiled_layer_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M webkit/compositor_bindings/web_content_layer_impl.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M webkit/compositor_bindings/web_layer_impl.cc View 1 2 chunks +7 lines, -9 lines 0 comments Download
M webkit/compositor_bindings/webcore_convert.h View 1 2 chunks +0 lines, -6 lines 0 comments Download
M webkit/compositor_bindings/webcore_convert.cc View 1 2 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
danakj
A potential combination of http://codereview.chromium.org/11369051/ and https://codereview.chromium.org/11361072/
8 years, 1 month ago (2012-11-02 20:16:41 UTC) #1
enne (OOO)
Rubber stamp lgtm
8 years, 1 month ago (2012-11-02 21:05:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/11360066/8001
8 years, 1 month ago (2012-11-02 21:50:38 UTC) #3
commit-bot: I haz the power
8 years, 1 month ago (2012-11-03 00:51:39 UTC) #4

Powered by Google App Engine
This is Rietveld 408576698