cc: Remove WebCore rect use from the compositor, except within Region.

cc/layer_tree_host_unittest.cc

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 
 #include "cc/layer_tree_host.h"
 
 #include "base/synchronization/lock.h"
 #include "cc/content_layer.h"
@@ skipping 1671 matching lines @@
         setTestLayerPropertiesForTesting(grandChild.get(), child.get(), identityMatrix, gfx::PointF(0, 0), gfx::PointF(10, 10), gfx::Size(500, 500), true);
 
         m_layerTreeHost->setRootLayer(rootLayer);
         m_layerTreeHost->setViewportSize(rootLayer->bounds(), rootLayer->bounds());
         ASSERT_TRUE(m_layerTreeHost->initializeRendererIfNeeded());
         ResourceUpdateQueue queue;
         m_layerTreeHost->updateLayers(queue, std::numeric_limits<size_t>::max());
         m_layerTreeHost->commitComplete();
 
         EXPECT_RECT_EQ(gfx::Rect(), grandChild->occludedScreenSpace().bounds());
-        EXPECT_EQ(0u, grandChild->occludedScreenSpace().rects().size());
+        EXPECT_EQ(0u, Region::Iterator(grandChild->occludedScreenSpace()).size());
         EXPECT_RECT_EQ(gfx::Rect(30, 40, 170, 160), child->occludedScreenSpace().bounds());
-        EXPECT_EQ(1u, child->occludedScreenSpace().rects().size());
+        EXPECT_EQ(1u, Region::Iterator(child->occludedScreenSpace()).size());
         EXPECT_RECT_EQ(gfx::Rect(30, 40, 170, 160), rootLayer->occludedScreenSpace().bounds());
-        EXPECT_EQ(1u, rootLayer->occludedScreenSpace().rects().size());
+        EXPECT_EQ(1u, Region::Iterator(rootLayer->occludedScreenSpace()).size());
 
         // If the child layer is opaque, then it adds to the occlusion seen by the rootLayer.
         setLayerPropertiesForTesting(rootLayer.get(), 0, identityMatrix, gfx::PointF(0, 0), gfx::PointF(0, 0), gfx::Size(200, 200), true);
         setLayerPropertiesForTesting(child.get(), rootLayer.get(), childTransform, gfx::PointF(0, 0), gfx::PointF(30, 30), gfx::Size(500, 500), true);
         setLayerPropertiesForTesting(grandChild.get(), child.get(), identityMatrix, gfx::PointF(0, 0), gfx::PointF(10, 10), gfx::Size(500, 500), true);
 
         m_layerTreeHost->setRootLayer(rootLayer);
         m_layerTreeHost->setViewportSize(rootLayer->bounds(), rootLayer->bounds());
         m_layerTreeHost->updateLayers(queue, std::numeric_limits<size_t>::max());
         m_layerTreeHost->commitComplete();
 
         EXPECT_RECT_EQ(gfx::Rect(), grandChild->occludedScreenSpace().bounds());
-        EXPECT_EQ(0u, grandChild->occludedScreenSpace().rects().size());
+        EXPECT_EQ(0u, Region::Iterator(grandChild->occludedScreenSpace()).size());
         EXPECT_RECT_EQ(gfx::Rect(30, 40, 170, 160), child->occludedScreenSpace().bounds());
-        EXPECT_EQ(1u, child->occludedScreenSpace().rects().size());
+        EXPECT_EQ(1u, Region::Iterator(child->occludedScreenSpace()).size());
         EXPECT_RECT_EQ(gfx::Rect(30, 30, 170, 170), rootLayer->occludedScreenSpace().bounds());
-        EXPECT_EQ(1u, rootLayer->occludedScreenSpace().rects().size());
+        EXPECT_EQ(1u, Region::Iterator(rootLayer->occludedScreenSpace()).size());
 
         // Add a second child to the root layer and the regions should merge
         setTestLayerPropertiesForTesting(rootLayer.get(), 0, identityMatrix, gfx::PointF(0, 0), gfx::PointF(0, 0), gfx::Size(200, 200), true);
         setTestLayerPropertiesForTesting(child2.get(), rootLayer.get(), identityMatrix, gfx::PointF(0, 0), gfx::PointF(70, 20), gfx::Size(500, 500), true);
         setTestLayerPropertiesForTesting(child.get(), rootLayer.get(), childTransform, gfx::PointF(0, 0), gfx::PointF(30, 30), gfx::Size(500, 500), true);
         setTestLayerPropertiesForTesting(grandChild.get(), child.get(), identityMatrix, gfx::PointF(0, 0), gfx::PointF(10, 10), gfx::Size(500, 500), true);
 
         m_layerTreeHost->setRootLayer(rootLayer);
         m_layerTreeHost->setViewportSize(rootLayer->bounds(), rootLayer->bounds());
         m_layerTreeHost->updateLayers(queue, std::numeric_limits<size_t>::max());
         m_layerTreeHost->commitComplete();
 
         EXPECT_RECT_EQ(gfx::Rect(), grandChild->occludedScreenSpace().bounds());
-        EXPECT_EQ(0u, grandChild->occludedScreenSpace().rects().size());
+        EXPECT_EQ(0u, Region::Iterator(grandChild->occludedScreenSpace()).size());
         EXPECT_RECT_EQ(gfx::Rect(30, 40, 170, 160), child->occludedScreenSpace().bounds());
-        EXPECT_EQ(1u, child->occludedScreenSpace().rects().size());
+        EXPECT_EQ(1u, Region::Iterator(child->occludedScreenSpace()).size());
         EXPECT_RECT_EQ(gfx::Rect(30, 30, 170, 170), child2->occludedScreenSpace().bounds());
-        EXPECT_EQ(1u, child2->occludedScreenSpace().rects().size());
+        EXPECT_EQ(1u, Region::Iterator(child2->occludedScreenSpace()).size());
         EXPECT_RECT_EQ(gfx::Rect(30, 20, 170, 180), rootLayer->occludedScreenSpace().bounds());
-        EXPECT_EQ(2u, rootLayer->occludedScreenSpace().rects().size());
+        EXPECT_EQ(2u, Region::Iterator(rootLayer->occludedScreenSpace()).size());
 
         // Move the second child to be sure.
         setTestLayerPropertiesForTesting(rootLayer.get(), 0, identityMatrix, gfx::PointF(0, 0), gfx::PointF(0, 0), gfx::Size(200, 200), true);
         setTestLayerPropertiesForTesting(child2.get(), rootLayer.get(), identityMatrix, gfx::PointF(0, 0), gfx::PointF(10, 70), gfx::Size(500, 500), true);
         setTestLayerPropertiesForTesting(child.get(), rootLayer.get(), childTransform, gfx::PointF(0, 0), gfx::PointF(30, 30), gfx::Size(500, 500), true);
         setTestLayerPropertiesForTesting(grandChild.get(), child.get(), identityMatrix, gfx::PointF(0, 0), gfx::PointF(10, 10), gfx::Size(500, 500), true);
 
         m_layerTreeHost->setRootLayer(rootLayer);
         m_layerTreeHost->setViewportSize(rootLayer->bounds(), rootLayer->bounds());
         m_layerTreeHost->updateLayers(queue, std::numeric_limits<size_t>::max());
         m_layerTreeHost->commitComplete();
 
         EXPECT_RECT_EQ(gfx::Rect(), grandChild->occludedScreenSpace().bounds());
-        EXPECT_EQ(0u, grandChild->occludedScreenSpace().rects().size());
+        EXPECT_EQ(0u, Region::Iterator(grandChild->occludedScreenSpace()).size());
         EXPECT_RECT_EQ(gfx::Rect(30, 40, 170, 160), child->occludedScreenSpace().bounds());
-        EXPECT_EQ(1u, child->occludedScreenSpace().rects().size());
+        EXPECT_EQ(1u, Region::Iterator(child->occludedScreenSpace()).size());
         EXPECT_RECT_EQ(gfx::Rect(30, 30, 170, 170), child2->occludedScreenSpace().bounds());
-        EXPECT_EQ(1u, child2->occludedScreenSpace().rects().size());
+        EXPECT_EQ(1u, Region::Iterator(child2->occludedScreenSpace()).size());
         EXPECT_RECT_EQ(gfx::Rect(10, 30, 190, 170), rootLayer->occludedScreenSpace().bounds());
-        EXPECT_EQ(2u, rootLayer->occludedScreenSpace().rects().size());
+        EXPECT_EQ(2u, Region::Iterator(rootLayer->occludedScreenSpace()).size());
 
         // If the child layer has a mask on it, then it shouldn't contribute to occlusion on stuff below it
         setLayerPropertiesForTesting(rootLayer.get(), 0, identityMatrix, gfx::PointF(0, 0), gfx::PointF(0, 0), gfx::Size(200, 200), true);
         setLayerPropertiesForTesting(child2.get(), rootLayer.get(), identityMatrix, gfx::PointF(0, 0), gfx::PointF(10, 70), gfx::Size(500, 500), true);
         setLayerPropertiesForTesting(child.get(), rootLayer.get(), childTransform, gfx::PointF(0, 0), gfx::PointF(30, 30), gfx::Size(500, 500), true);
         setLayerPropertiesForTesting(grandChild.get(), child.get(), identityMatrix, gfx::PointF(0, 0), gfx::PointF(10, 10), gfx::Size(500, 500), true);
 
         child->setMaskLayer(mask.get());
 
         m_layerTreeHost->setRootLayer(rootLayer);
         m_layerTreeHost->setViewportSize(rootLayer->bounds(), rootLayer->bounds());
         m_layerTreeHost->updateLayers(queue, std::numeric_limits<size_t>::max());
         m_layerTreeHost->commitComplete();
 
         EXPECT_RECT_EQ(gfx::Rect(), grandChild->occludedScreenSpace().bounds());
-        EXPECT_EQ(0u, grandChild->occludedScreenSpace().rects().size());
+        EXPECT_EQ(0u, Region::Iterator(grandChild->occludedScreenSpace()).size());
         EXPECT_RECT_EQ(gfx::Rect(30, 40, 170, 160), child->occludedScreenSpace().bounds());
-        EXPECT_EQ(1u, child->occludedScreenSpace().rects().size());
+        EXPECT_EQ(1u, Region::Iterator(child->occludedScreenSpace()).size());
         EXPECT_RECT_EQ(gfx::Rect(), child2->occludedScreenSpace().bounds());
-        EXPECT_EQ(0u, child2->occludedScreenSpace().rects().size());
+        EXPECT_EQ(0u, Region::Iterator(child2->occludedScreenSpace()).size());
         EXPECT_RECT_EQ(gfx::Rect(10, 70, 190, 130), rootLayer->occludedScreenSpace().bounds());
-        EXPECT_EQ(1u, rootLayer->occludedScreenSpace().rects().size());
+        EXPECT_EQ(1u, Region::Iterator(rootLayer->occludedScreenSpace()).size());
 
         // If the child layer with a mask is below child2, then child2 should contribute to occlusion on everything, and child shouldn't contribute to the rootLayer
         setLayerPropertiesForTesting(rootLayer.get(), 0, identityMatrix, gfx::PointF(0, 0), gfx::PointF(0, 0), gfx::Size(200, 200), true);
         setLayerPropertiesForTesting(child.get(), rootLayer.get(), childTransform, gfx::PointF(0, 0), gfx::PointF(30, 30), gfx::Size(500, 500), true);
         setLayerPropertiesForTesting(grandChild.get(), child.get(), identityMatrix, gfx::PointF(0, 0), gfx::PointF(10, 10), gfx::Size(500, 500), true);
         setLayerPropertiesForTesting(child2.get(), rootLayer.get(), identityMatrix, gfx::PointF(0, 0), gfx::PointF(10, 70), gfx::Size(500, 500), true);
 
         child->setMaskLayer(mask.get());
 
         m_layerTreeHost->setRootLayer(rootLayer);
         m_layerTreeHost->setViewportSize(rootLayer->bounds(), rootLayer->bounds());
         m_layerTreeHost->updateLayers(queue, std::numeric_limits<size_t>::max());
         m_layerTreeHost->commitComplete();
 
         EXPECT_RECT_EQ(gfx::Rect(), child2->occludedScreenSpace().bounds());
-        EXPECT_EQ(0u, child2->occludedScreenSpace().rects().size());
+        EXPECT_EQ(0u, Region::Iterator(child2->occludedScreenSpace()).size());
         EXPECT_RECT_EQ(gfx::Rect(10, 70, 190, 130), grandChild->occludedScreenSpace().bounds());
-        EXPECT_EQ(1u, grandChild->occludedScreenSpace().rects().size());
+        EXPECT_EQ(1u, Region::Iterator(grandChild->occludedScreenSpace()).size());
         EXPECT_RECT_EQ(gfx::Rect(10, 40, 190, 160), child->occludedScreenSpace().bounds());
-        EXPECT_EQ(2u, child->occludedScreenSpace().rects().size());
+        EXPECT_EQ(2u, Region::Iterator(child->occludedScreenSpace()).size());
         EXPECT_RECT_EQ(gfx::Rect(10, 70, 190, 130), rootLayer->occludedScreenSpace().bounds());
-        EXPECT_EQ(1u, rootLayer->occludedScreenSpace().rects().size());
+        EXPECT_EQ(1u, Region::Iterator(rootLayer->occludedScreenSpace()).size());
 
         // If the child layer has a non-opaque drawOpacity, then it shouldn't contribute to occlusion on stuff below it
         setTestLayerPropertiesForTesting(rootLayer.get(), 0, identityMatrix, gfx::PointF(0, 0), gfx::PointF(0, 0), gfx::Size(200, 200), true);
         setTestLayerPropertiesForTesting(child2.get(), rootLayer.get(), identityMatrix, gfx::PointF(0, 0), gfx::PointF(10, 70), gfx::Size(500, 500), true);
         setTestLayerPropertiesForTesting(child.get(), rootLayer.get(), childTransform, gfx::PointF(0, 0), gfx::PointF(30, 30), gfx::Size(500, 500), true);
         setTestLayerPropertiesForTesting(grandChild.get(), child.get(), identityMatrix, gfx::PointF(0, 0), gfx::PointF(10, 10), gfx::Size(500, 500), true);
 
         child->setMaskLayer(0);
         child->setOpacity(0.5);
 
         m_layerTreeHost->setRootLayer(rootLayer);
         m_layerTreeHost->setViewportSize(rootLayer->bounds(), rootLayer->bounds());
         m_layerTreeHost->updateLayers(queue, std::numeric_limits<size_t>::max());
         m_layerTreeHost->commitComplete();
 
         EXPECT_RECT_EQ(gfx::Rect(), grandChild->occludedScreenSpace().bounds());
-        EXPECT_EQ(0u, grandChild->occludedScreenSpace().rects().size());
+        EXPECT_EQ(0u, Region::Iterator(grandChild->occludedScreenSpace()).size());
         EXPECT_RECT_EQ(gfx::Rect(30, 40, 170, 160), child->occludedScreenSpace().bounds());
-        EXPECT_EQ(1u, child->occludedScreenSpace().rects().size());
+        EXPECT_EQ(1u, Region::Iterator(child->occludedScreenSpace()).size());
         EXPECT_RECT_EQ(gfx::Rect(), child2->occludedScreenSpace().bounds());
-        EXPECT_EQ(0u, child2->occludedScreenSpace().rects().size());
+        EXPECT_EQ(0u, Region::Iterator(child2->occludedScreenSpace()).size());
         EXPECT_RECT_EQ(gfx::Rect(10, 70, 190, 130), rootLayer->occludedScreenSpace().bounds());
-        EXPECT_EQ(1u, rootLayer->occludedScreenSpace().rects().size());
+        EXPECT_EQ(1u, Region::Iterator(rootLayer->occludedScreenSpace()).size());
 
         // If the child layer with non-opaque drawOpacity is below child2, then child2 should contribute to occlusion on everything, and child shouldn't contribute to the rootLayer
         setTestLayerPropertiesForTesting(rootLayer.get(), 0, identityMatrix, gfx::PointF(0, 0), gfx::PointF(0, 0), gfx::Size(200, 200), true);
         setTestLayerPropertiesForTesting(child.get(), rootLayer.get(), childTransform, gfx::PointF(0, 0), gfx::PointF(30, 30), gfx::Size(500, 500), true);
         setTestLayerPropertiesForTesting(grandChild.get(), child.get(), identityMatrix, gfx::PointF(0, 0), gfx::PointF(10, 10), gfx::Size(500, 500), true);
         setTestLayerPropertiesForTesting(child2.get(), rootLayer.get(), identityMatrix, gfx::PointF(0, 0), gfx::PointF(10, 70), gfx::Size(500, 500), true);
 
         child->setMaskLayer(0);
         child->setOpacity(0.5);
 
         m_layerTreeHost->setRootLayer(rootLayer);
         m_layerTreeHost->setViewportSize(rootLayer->bounds(), rootLayer->bounds());
         m_layerTreeHost->updateLayers(queue, std::numeric_limits<size_t>::max());
         m_layerTreeHost->commitComplete();
 
         EXPECT_RECT_EQ(gfx::Rect(), child2->occludedScreenSpace().bounds());
-        EXPECT_EQ(0u, child2->occludedScreenSpace().rects().size());
+        EXPECT_EQ(0u, Region::Iterator(child2->occludedScreenSpace()).size());
         EXPECT_RECT_EQ(gfx::Rect(10, 70, 190, 130), grandChild->occludedScreenSpace().bounds());
-        EXPECT_EQ(1u, grandChild->occludedScreenSpace().rects().size());
+        EXPECT_EQ(1u, Region::Iterator(grandChild->occludedScreenSpace()).size());
         EXPECT_RECT_EQ(gfx::Rect(10, 40, 190, 160), child->occludedScreenSpace().bounds());
-        EXPECT_EQ(2u, child->occludedScreenSpace().rects().size());
+        EXPECT_EQ(2u, Region::Iterator(child->occludedScreenSpace()).size());
         EXPECT_RECT_EQ(gfx::Rect(10, 70, 190, 130), rootLayer->occludedScreenSpace().bounds());
-        EXPECT_EQ(1u, rootLayer->occludedScreenSpace().rects().size());
+        EXPECT_EQ(1u, Region::Iterator(rootLayer->occludedScreenSpace()).size());
 
         // Kill the layerTreeHost immediately.
         m_layerTreeHost->setRootLayer(0);
         m_layerTreeHost.reset();
 
         endTest();
     }
 
     virtual void afterTest() OVERRIDE
     {
@@ skipping 36 matching lines @@
         }
 
         m_layerTreeHost->setRootLayer(rootLayer);
         m_layerTreeHost->setViewportSize(rootLayer->bounds(), rootLayer->bounds());
         ASSERT_TRUE(m_layerTreeHost->initializeRendererIfNeeded());
         ResourceUpdateQueue queue;
         m_layerTreeHost->updateLayers(queue, std::numeric_limits<size_t>::max());
         m_layerTreeHost->commitComplete();
 
         EXPECT_RECT_EQ(gfx::Rect(), child2->occludedScreenSpace().bounds());
-        EXPECT_EQ(0u, child2->occludedScreenSpace().rects().size());
+        EXPECT_EQ(0u, Region::Iterator(child2->occludedScreenSpace()).size());
         EXPECT_RECT_EQ(gfx::Rect(10, 70, 190, 130), grandChild->occludedScreenSpace().bounds());
-        EXPECT_EQ(1u, grandChild->occludedScreenSpace().rects().size());
+        EXPECT_EQ(1u, Region::Iterator(grandChild->occludedScreenSpace()).size());
         EXPECT_RECT_EQ(gfx::Rect(10, 40, 190, 160), child->occludedScreenSpace().bounds());
-        EXPECT_EQ(2u, child->occludedScreenSpace().rects().size());
+        EXPECT_EQ(2u, Region::Iterator(child->occludedScreenSpace()).size());
         EXPECT_RECT_EQ(gfx::Rect(10, 70, 190, 130), rootLayer->occludedScreenSpace().bounds());
-        EXPECT_EQ(1u, rootLayer->occludedScreenSpace().rects().size());
+        EXPECT_EQ(1u, Region::Iterator(rootLayer->occludedScreenSpace()).size());
 
         // If the child layer has a filter that moves pixels/changes alpha, and is below child2, then child should not inherit occlusion from outside its subtree,
         // and should not contribute to the rootLayer
         setTestLayerPropertiesForTesting(rootLayer.get(), 0, identityMatrix, gfx::PointF(0, 0), gfx::PointF(0, 0), gfx::Size(200, 200), true);
         setTestLayerPropertiesForTesting(child.get(), rootLayer.get(), childTransform, gfx::PointF(0, 0), gfx::PointF(30, 30), gfx::Size(500, 500), true);
         setTestLayerPropertiesForTesting(grandChild.get(), child.get(), identityMatrix, gfx::PointF(0, 0), gfx::PointF(10, 10), gfx::Size(500, 500), true);
         setTestLayerPropertiesForTesting(child2.get(), rootLayer.get(), identityMatrix, gfx::PointF(0, 0), gfx::PointF(10, 70), gfx::Size(500, 500), true);
 
         {
             WebFilterOperations filters;
             filters.append(WebFilterOperation::createBlurFilter(10));
             child->setFilters(filters);
         }
 
         m_layerTreeHost->setRootLayer(rootLayer);
         m_layerTreeHost->setViewportSize(rootLayer->bounds(), rootLayer->bounds());
         m_layerTreeHost->updateLayers(queue, std::numeric_limits<size_t>::max());
         m_layerTreeHost->commitComplete();
 
         EXPECT_RECT_EQ(gfx::Rect(), child2->occludedScreenSpace().bounds());
-        EXPECT_EQ(0u, child2->occludedScreenSpace().rects().size());
+        EXPECT_EQ(0u, Region::Iterator(child2->occludedScreenSpace()).size());
         EXPECT_RECT_EQ(gfx::Rect(), grandChild->occludedScreenSpace().bounds());
-        EXPECT_EQ(0u, grandChild->occludedScreenSpace().rects().size());
+        EXPECT_EQ(0u, Region::Iterator(grandChild->occludedScreenSpace()).size());
         EXPECT_RECT_EQ(gfx::Rect(30, 40, 170, 160), child->occludedScreenSpace().bounds());
-        EXPECT_EQ(1u, child->occludedScreenSpace().rects().size());
+        EXPECT_EQ(1u, Region::Iterator(child->occludedScreenSpace()).size());
         EXPECT_RECT_EQ(gfx::Rect(10, 70, 190, 130), rootLayer->occludedScreenSpace().bounds());
-        EXPECT_EQ(1u, rootLayer->occludedScreenSpace().rects().size());
+        EXPECT_EQ(1u, Region::Iterator(rootLayer->occludedScreenSpace()).size());
 
         // Kill the layerTreeHost immediately.
         m_layerTreeHost->setRootLayer(0);
         m_layerTreeHost.reset();
 
         LayerTreeHost::setNeedsFilterContext(false);
         endTest();
     }
 
     virtual void afterTest() OVERRIDE
@@ skipping 38 matching lines @@
         m_layerTreeHost->setViewportSize(layers[0]->bounds(), layers[0]->bounds());
         ASSERT_TRUE(m_layerTreeHost->initializeRendererIfNeeded());
         ResourceUpdateQueue queue;
         m_layerTreeHost->updateLayers(queue, std::numeric_limits<size_t>::max());
         m_layerTreeHost->commitComplete();
 
         for (int i = 0; i < numSurfaces-1; ++i) {
             gfx::Rect expectedOcclusion(i+1, i+1, 200-i-1, 200-i-1);
 
             EXPECT_RECT_EQ(expectedOcclusion, layers[i]->occludedScreenSpace().bounds());
-            EXPECT_EQ(1u, layers[i]->occludedScreenSpace().rects().size());
+            EXPECT_EQ(1u, Region::Iterator(layers[i]->occludedScreenSpace()).size());
         }
 
         // Kill the layerTreeHost immediately.
         m_layerTreeHost->setRootLayer(0);
         m_layerTreeHost.reset();
 
         endTest();
     }
 
     virtual void afterTest() OVERRIDE
@@ skipping 1261 matching lines @@
     int m_numCommitsDeferred;
     int m_numCompleteCommits;
 };
 
 TEST_F(LayerTreeHostTestDeferCommits, runMultiThread)
 {
     runTest(true);
 }
 
 } // namespace