Issue 11348120: Remove tst+ldr, tst+str from checked-in nexes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11348120: Remove tst+ldr, tst+str from checked-in nexes. (Closed)

Created:
8 years, 1 month ago by JF

Modified:
8 years, 1 month ago

Reviewers:
Karl

CC:
native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/native_client/trunk/src/native_client

Visibility:
Public.

More Reviews

Description

Remove tst+ldr, tst+str from checked-in nexes. This is in preparation for my CL which conditionally supports this sandboxing sequence. This change would otherwise fail the trybots because they can't diff nexes properly. BUG=https://code.google.com/p/nativeclient/issues/detail?id=3117 R=kschimpf@google.com Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=10302

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -48 lines)			Patch
M	src/trusted/validator_arm/testdata/test_loads.S	View	1 chunk	+0 lines, -14 lines	0 comments	Download
M	src/trusted/validator_arm/testdata/test_loads.err	View	1 chunk	+10 lines, -13 lines	0 comments	Download
M	src/trusted/validator_arm/testdata/test_loads.nexe	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	src/trusted/validator_arm/testdata/test_stores.S	View	1 chunk	+0 lines, -13 lines	0 comments	Download
M	src/trusted/validator_arm/testdata/test_stores.err	View	1 chunk	+7 lines, -10 lines	0 comments	Download
M	src/trusted/validator_arm/testdata/test_stores.nexe	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages