Chromium Code Reviews
Help | Chromium Project | Sign in
(597)

Issue 11348120: Remove tst+ldr, tst+str from checked-in nexes. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 4 months ago by JF
Modified:
1 year, 4 months ago
Reviewers:
Karl
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Remove tst+ldr, tst+str from checked-in nexes.

This is in preparation for my CL which conditionally supports this
sandboxing sequence. This change would otherwise fail the trybots
because they can't diff nexes properly.

BUG=https://code.google.com/p/nativeclient/issues/detail?id=3117
R=kschimpf@google.com

Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=10302

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -48 lines) Lint Patch
M src/trusted/validator_arm/testdata/test_loads.S View 1 chunk +0 lines, -14 lines 0 comments ? errors Download
M src/trusted/validator_arm/testdata/test_loads.err View 1 chunk +10 lines, -13 lines 0 comments ? errors Download
M src/trusted/validator_arm/testdata/test_loads.nexe View 0 chunks +-1 lines, --1 lines 0 comments ? errors Download
M src/trusted/validator_arm/testdata/test_stores.S View 1 chunk +0 lines, -13 lines 0 comments ? errors Download
M src/trusted/validator_arm/testdata/test_stores.err View 1 chunk +7 lines, -10 lines 0 comments ? errors Download
M src/trusted/validator_arm/testdata/test_stores.nexe View 0 chunks +-1 lines, --1 lines 0 comments ? errors Download
Trybot results:
Commit:

Messages

Total messages: 2
JF
1 year, 4 months ago #1
Karl
1 year, 4 months ago #2
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1275:d14800f88434