Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11312228: Move extension_error_utils.* and url_pattern_set.* into (Closed)

Created:
8 years, 1 month ago by Aaron Boodman
Modified:
8 years, 1 month ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, oshima+watch_chromium.org, nkostylev+watch_chromium.org, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, kkania, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, robertshield, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, ctguil+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, zork+watch_chromium.org
Visibility:
Public.

Description

Move extension_error_utils.* and url_pattern_set.* into top-level extensions dir. BUG=159265 TBR=ben@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=168613

Patch Set 1 #

Patch Set 2 : move into extensions namespace #

Total comments: 1

Patch Set 3 : #

Patch Set 4 : hate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+455 lines, -1152 lines) Patch
M chrome/browser/accessibility/accessibility_extension_api.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_handler_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_crx_util.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/active_tab_permission_granter.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/alarms/alarms_api.cc View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/browsing_data/browsing_data_api.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/content_settings/content_settings_api.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/context_menu/context_menu_api.cc View 1 2 5 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/cookies/cookies_api.cc View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/debugger/debugger_api.cc View 1 2 8 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute.cc View 1 2 9 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/extensions/api/discovery/discovery_api.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/extension_action/extension_actions_api.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/extension_action/extension_page_actions_api.cc View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/font_settings/font_settings_api.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/management/management_api.cc View 1 2 10 chunks +13 lines, -12 lines 0 comments Download
M chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc View 1 2 6 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/permissions/permissions_api.cc View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/permissions/permissions_api_helpers.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/permissions/permissions_api_helpers_unittest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/permissions/permissions_apitest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/preference/preference_api.cc View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/processes/processes_api.cc View 1 2 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/proxy/proxy_api_helpers.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/tabs/execute_code_in_tab_function.cc View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs.cc View 1 2 13 chunks +12 lines, -11 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api.cc View 1 2 5 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/webstore_private/webstore_private_api.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/convert_user_script_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_prefs.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extensions_quota_service.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/menu_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/settings/settings_storage_quota_enforcer.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/user_script_master_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/infobars/infobar_extension_api.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/content_settings_handler.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_common.gypi View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/extension_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/command.cc View 1 2 12 chunks +13 lines, -11 lines 0 comments Download
M chrome/common/extensions/extension.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension.cc View 1 2 77 chunks +87 lines, -87 lines 0 comments Download
D chrome/common/extensions/extension_error_utils.h View 1 chunk +0 lines, -40 lines 0 comments Download
D chrome/common/extensions/extension_error_utils.cc View 1 chunk +0 lines, -69 lines 0 comments Download
M chrome/common/extensions/extension_messages.h View 1 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/common/extensions/extension_messages.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/extension_set.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension_set.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension_unittest.cc View 1 2 6 chunks +9 lines, -7 lines 0 comments Download
M chrome/common/extensions/file_browser_handler.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/manifest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifest_test.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifest_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_browseraction_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_contentscript_unittest.cc View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_filebrowser_unittest.cc View 1 2 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_launch_unittest.cc View 1 2 4 chunks +15 lines, -13 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_requirements_unittest.cc View 1 2 1 chunk +10 lines, -8 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_validapp_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_web_unittest.cc View 1 2 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/common/extensions/manifest_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/matcher/url_matcher_factory.cc View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/message_bundle.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/message_bundle_unittest.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/permissions/api_permission_set.cc View 1 2 6 chunks +6 lines, -5 lines 0 comments Download
M chrome/common/extensions/permissions/permission_set.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/permissions/permission_set.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M chrome/common/extensions/permissions/permission_set_unittest.cc View 1 2 3 chunks +4 lines, -2 lines 0 comments Download
D chrome/common/extensions/url_pattern_set.h View 1 chunk +0 lines, -97 lines 0 comments Download
D chrome/common/extensions/url_pattern_set.cc View 1 chunk +0 lines, -215 lines 0 comments Download
D chrome/common/extensions/url_pattern_set_unittest.cc View 1 chunk +0 lines, -392 lines 0 comments Download
M chrome/common/extensions/user_script.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/user_script_scheduler.cc View 1 2 3 chunks +2 lines, -2 lines 0 comments Download
M extensions/DEPS View 1 chunk +2 lines, -1 line 0 comments Download
A + extensions/common/error_utils.h View 1 2 2 chunks +8 lines, -4 lines 0 comments Download
A extensions/common/error_utils.cc View 1 2 1 chunk +66 lines, -0 lines 0 comments Download
A + extensions/common/url_pattern_set.h View 1 3 chunks +7 lines, -3 lines 0 comments Download
A + extensions/common/url_pattern_set.cc View 1 2 4 chunks +8 lines, -4 lines 0 comments Download
A + extensions/common/url_pattern_set_unittest.cc View 1 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Aaron Boodman
Easy one. Pure move of extension_error_util.* and url_pattern_set.*.
8 years, 1 month ago (2012-11-14 02:07:46 UTC) #1
Yoyo Zhou
LGTM At some point, these should go into the extensions namespace too.
8 years, 1 month ago (2012-11-14 18:26:36 UTC) #2
Yoyo Zhou
https://codereview.chromium.org/11312228/diff/20001/extensions/common/extension_error_utils.h File extensions/common/extension_error_utils.h (right): https://codereview.chromium.org/11312228/diff/20001/extensions/common/extension_error_utils.h#newcode5 extensions/common/extension_error_utils.h:5: #ifndef EXTENSIONS_COMMON_EXTENSION_ERROR_UTILS_H_ LGTM, but this could be renamed to ...
8 years, 1 month ago (2012-11-15 23:14:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aa@chromium.org/11312228/15003
8 years, 1 month ago (2012-11-16 02:22:28 UTC) #4
commit-bot: I haz the power
8 years, 1 month ago (2012-11-16 02:23:07 UTC) #5 
Presubmit check for 11312228-15003 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    
    chrome/browser/automation
    chrome/browser/ui/webui/options
    chrome
    chrome/browser/tab_contents
    chrome/browser/infobars
    chrome/browser/download
    chrome/common/extensions/extension_messages.h
    chrome/browser/accessibility

Presubmit checks took 7.2s to calculate.

Powered by Google App Engine
This is Rietveld 408576698